ValgrindRunner: Establish connections in private c'tor

Change-Id: I3238c1dc09008484b270a0904688bc4a7b6e10cc
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 10 insertions, 9 deletions

diff --git a/src/plugins/valgrind/valgrindrunner.cpp b/src/plugins/valgrind/valgrindrunner.cpp
index 1447cf1e4d9..d6dd5eb7496 100644
--- a/src/plugins/valgrind/valgrindrunner.cpp
+++ b/src/plugins/valgrind/valgrindrunner.cpp
@@ -43,6 +43,13 @@ public:
 
         connect(&m_xmlServer, &QTcpServer::newConnection, this, &Private::xmlSocketConnected);
         connect(&m_logServer, &QTcpServer::newConnection, this, &Private::logSocketConnected);
+
+        connect(&m_parser, &Parser::status, q, &ValgrindRunner::status);
+        connect(&m_parser, &Parser::error, q, &ValgrindRunner::error);
+        connect(&m_parser, &Parser::done, this, [this](bool success, const QString &err) {
+            if (!success)
+                emit q->internalError(err);
+        });
     }
 
     void xmlSocketConnected();
@@ -159,15 +166,9 @@ bool ValgrindRunner::Private::run()
 }
 
 ValgrindRunner::ValgrindRunner(QObject *parent)
-    : QObject(parent), d(new Private(this))
-{
-    connect(&d->m_parser, &Parser::status, this, &ValgrindRunner::status);
-    connect(&d->m_parser, &Parser::error, this, &ValgrindRunner::error);
-    connect(&d->m_parser, &Parser::done, this, [this](bool success, const QString &err) {
-        if (!success)
-            emit internalError(err);
-    });
-}
+    : QObject(parent)
+    , d(new Private(this))
+{}
 
 ValgrindRunner::~ValgrindRunner()
 {