aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind
diff options
context:
space:
mode:
authorJarek Kobus <jaroslaw.kobus@qt.io>2023-11-03 15:53:01 +0100
committerJarek Kobus <jaroslaw.kobus@qt.io>2023-11-07 14:07:52 +0000
commitfbe359308dc3946bb68b6dedca237f353fa279f0 (patch)
tree248fc0d93885c4bcbde907b4db5ab42ec5c40555 /src/plugins/valgrind
parentd2500dc77b905a885d351367cf9154316ac73acf (diff)
TaskTree: Unify done / errorOccurred signals
Get rid of TaskTree::errorOccurred signal. Provide additional DoneResult arg for done signal. Task-number: QTCREATORBUG-29834 Change-Id: I31a3a0701a14246b01f65303a1295f014c855ecf Reviewed-by: hjk <hjk@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Diffstat (limited to 'src/plugins/valgrind')
-rw-r--r--src/plugins/valgrind/valgrindprocess.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/plugins/valgrind/valgrindprocess.cpp b/src/plugins/valgrind/valgrindprocess.cpp
index c62fb46891b..d8581f94d92 100644
--- a/src/plugins/valgrind/valgrindprocess.cpp
+++ b/src/plugins/valgrind/valgrindprocess.cpp
@@ -213,12 +213,10 @@ bool ValgrindProcessPrivate::run()
{
m_taskTree.reset(new TaskTree);
m_taskTree->setRecipe(runRecipe());
- const auto finalize = [this](bool success) {
+ connect(m_taskTree.get(), &TaskTree::done, this, [this](DoneWith result) {
m_taskTree.release()->deleteLater();
- emit q->done(success);
- };
- connect(m_taskTree.get(), &TaskTree::done, this, [finalize] { finalize(true); });
- connect(m_taskTree.get(), &TaskTree::errorOccurred, this, [finalize] { finalize(false); });
+ emit q->done(result == DoneWith::Success);
+ });
m_taskTree->start();
return bool(m_taskTree);
}