diff options
author | hjk <hjk@qt.io> | 2019-07-23 10:58:00 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-07-23 11:55:59 +0000 |
commit | 251287f0d35dd82e68dabed8214ef8af893aff91 (patch) | |
tree | a3ba843c1c23f4aea06bc01bf7ab0dd69d6fc741 /src/plugins/vcsbase | |
parent | 2b26eca80f9ebcdc2f1dc0d890a39a4fbc2d129c (diff) |
Avoid warning on empty expressions
For some reason, Q_UNUSED includes already a semicolon, adding one
on the user side creates an additional empty statement.
Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/vcsbase')
-rw-r--r-- | src/plugins/vcsbase/vcsbaseclientsettings.cpp | 2 | ||||
-rw-r--r-- | src/plugins/vcsbase/vcsbaseeditor.cpp | 12 | ||||
-rw-r--r-- | src/plugins/vcsbase/wizard/vcscommandpage.cpp | 2 | ||||
-rw-r--r-- | src/plugins/vcsbase/wizard/vcsconfigurationpage.cpp | 2 |
4 files changed, 9 insertions, 9 deletions
diff --git a/src/plugins/vcsbase/vcsbaseclientsettings.cpp b/src/plugins/vcsbase/vcsbaseclientsettings.cpp index 96571e57827..ebf81d5123d 100644 --- a/src/plugins/vcsbase/vcsbaseclientsettings.cpp +++ b/src/plugins/vcsbase/vcsbaseclientsettings.cpp @@ -394,7 +394,7 @@ QVariant VcsBaseClientSettings::keyDefaultValue(const QString &key) const void VcsBaseClientSettings::readLegacySettings(const QSettings *settings) { - Q_UNUSED(settings); + Q_UNUSED(settings) } } // namespace VcsBase diff --git a/src/plugins/vcsbase/vcsbaseeditor.cpp b/src/plugins/vcsbase/vcsbaseeditor.cpp index 885b0c7cd14..fee6dbc72c0 100644 --- a/src/plugins/vcsbase/vcsbaseeditor.cpp +++ b/src/plugins/vcsbase/vcsbaseeditor.cpp @@ -460,7 +460,7 @@ void UrlTextCursorHandler::handleCurrentContents() void UrlTextCursorHandler::fillContextMenu(QMenu *menu, EditorContentType type) const { - Q_UNUSED(type); + Q_UNUSED(type) menu->addSeparator(); menu->addAction(createOpenUrlAction(tr("Open URL in Browser..."))); menu->addAction(createCopyUrlAction(tr("Copy URL Location"))); @@ -527,7 +527,7 @@ EmailTextCursorHandler::EmailTextCursorHandler(VcsBaseEditorWidget *editorWidget void EmailTextCursorHandler::fillContextMenu(QMenu *menu, EditorContentType type) const { - Q_UNUSED(type); + Q_UNUSED(type) menu->addSeparator(); menu->addAction(createOpenUrlAction(tr("Send Email To..."))); menu->addAction(createCopyUrlAction(tr("Copy Email Address"))); @@ -673,7 +673,7 @@ bool VcsBaseEditorWidget::supportChangeLinks() const QString VcsBaseEditorWidget::fileNameForLine(int line) const { - Q_UNUSED(line); + Q_UNUSED(line) return source(); } @@ -1212,7 +1212,7 @@ DiffChunk VcsBaseEditorWidget::diffChunk(QTextCursor cursor) const void VcsBaseEditorWidget::reportCommandFinished(bool ok, int exitCode, const QVariant &data) { - Q_UNUSED(exitCode); + Q_UNUSED(exitCode) hideProgressIndicator(); if (!ok) { @@ -1549,13 +1549,13 @@ QString VcsBaseEditorWidget::decorateVersion(const QString &revision) const bool VcsBaseEditorWidget::isValidRevision(const QString &revision) const { - Q_UNUSED(revision); + Q_UNUSED(revision) return true; } QString VcsBaseEditorWidget::revisionSubject(const QTextBlock &inBlock) const { - Q_UNUSED(inBlock); + Q_UNUSED(inBlock) return QString(); } diff --git a/src/plugins/vcsbase/wizard/vcscommandpage.cpp b/src/plugins/vcsbase/wizard/vcscommandpage.cpp index 653df132fd3..c08077e9029 100644 --- a/src/plugins/vcsbase/wizard/vcscommandpage.cpp +++ b/src/plugins/vcsbase/wizard/vcscommandpage.cpp @@ -71,7 +71,7 @@ VcsCommandPageFactory::VcsCommandPageFactory() WizardPage *VcsCommandPageFactory::create(JsonWizard *wizard, Id typeId, const QVariant &data) { - Q_UNUSED(wizard); + Q_UNUSED(wizard) QTC_ASSERT(canCreate(typeId), return 0); diff --git a/src/plugins/vcsbase/wizard/vcsconfigurationpage.cpp b/src/plugins/vcsbase/wizard/vcsconfigurationpage.cpp index 22b69ac5910..894d1155ba7 100644 --- a/src/plugins/vcsbase/wizard/vcsconfigurationpage.cpp +++ b/src/plugins/vcsbase/wizard/vcsconfigurationpage.cpp @@ -78,7 +78,7 @@ VcsConfigurationPageFactory::VcsConfigurationPageFactory() Utils::WizardPage *VcsConfigurationPageFactory::create(JsonWizard *wizard, Id typeId, const QVariant &data) { - Q_UNUSED(wizard); + Q_UNUSED(wizard) QTC_ASSERT(canCreate(typeId), return 0); |