aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/vcsbase
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2020-01-31 17:21:51 +0100
committerhjk <hjk@qt.io>2020-02-03 07:15:38 +0000
commitb1f5b18ac5e545fd8ebbea5b24693e0c7f362573 (patch)
treeec1b01d03be1355a20a94a8e6e13aaf561a2fd40 /src/plugins/vcsbase
parent039e70c727de74368c0f7f00d36f83cc91de5ed4 (diff)
Vcs: Provide default implementations for some pure methods
Saves empty re-implementations in some cases. Change-Id: I4ffa039d70257f2256942e09fcabe790943e1578 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/vcsbase')
-rw-r--r--src/plugins/vcsbase/vcsbaseclient.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/vcsbase/vcsbaseclient.h b/src/plugins/vcsbase/vcsbaseclient.h
index f538dfc16e8..164838fb9f2 100644
--- a/src/plugins/vcsbase/vcsbaseclient.h
+++ b/src/plugins/vcsbase/vcsbaseclient.h
@@ -192,7 +192,7 @@ public:
const QString &commitMessageFile,
const QStringList &extraOptions = QStringList());
- virtual QString findTopLevelForFile(const QFileInfo &file) const = 0;
+ virtual QString findTopLevelForFile(const QFileInfo &/*file*/) const { return {}; }
virtual void view(const QString &source, const QString &id,
const QStringList &extraOptions = QStringList());
@@ -226,13 +226,13 @@ protected:
virtual Core::Id vcsEditorKind(VcsCommandTag cmd) const = 0;
virtual Utils::ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const;
- virtual QStringList revisionSpec(const QString &revision) const = 0;
+ virtual QStringList revisionSpec(const QString &/*revision*/) const { return {}; }
typedef std::function<VcsBaseEditorConfig *(QToolBar *)> ConfigCreator;
void setDiffConfigCreator(ConfigCreator creator);
void setLogConfigCreator(ConfigCreator creator);
- virtual StatusItem parseStatusLine(const QString &line) const = 0;
+ virtual StatusItem parseStatusLine(const QString &/*line*/) const { return {}; }
QString vcsEditorTitle(const QString &vcsCmd, const QString &sourceId) const;