diff options
| author | Kai Koehne <kai.koehne@digia.com> | 2013-07-08 08:35:18 +0200 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@digia.com> | 2013-07-08 11:33:32 +0200 |
| commit | 108899ef8f69ecb84d3756abf5cd64513637d804 (patch) | |
| tree | 77cd92fffdeecbf81c96a00fcb4917d5a4dcecdf /src/tools/sdktool/addtoolchainoperation.cpp | |
| parent | 486b5c4739a0b9278cbee3c2b642f39b24ed3b36 (diff) | |
Don't return negative numbers in sdktool
Negative return values are interpreted as 'process crashed' on
Windows: QTBUG-28735 . This in turn means the installer framework
always shows an error dialog.
By using positive numbers even for error conditions the installer
can decide to ignore certain errors instead.
Change-Id: Ib5cdd461372ac13fe417feb6ff43a7424c159f68
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Diffstat (limited to 'src/tools/sdktool/addtoolchainoperation.cpp')
| -rw-r--r-- | src/tools/sdktool/addtoolchainoperation.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/sdktool/addtoolchainoperation.cpp b/src/tools/sdktool/addtoolchainoperation.cpp index 3506b1ae69..7279169660 100644 --- a/src/tools/sdktool/addtoolchainoperation.cpp +++ b/src/tools/sdktool/addtoolchainoperation.cpp @@ -151,9 +151,9 @@ int AddToolChainOperation::execute() const QVariantMap result = addToolChain(map, m_id, m_displayName, m_path, m_targetAbi, m_supportedAbis, m_extra); if (result.isEmpty() || map == result) - return -2; + return 2; - return save(result, QLatin1String("toolchains")) ? 0 : -3; + return save(result, QLatin1String("toolchains")) ? 0 : 3; } #ifdef WITH_TESTS |