CodeStylePool: Avoid using sender()

Change-Id: I72bf94a7d0a3c4e583016e1cffacba4b246bd858
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

2 files changed, 4 insertions, 17 deletions

diff --git a/src/plugins/texteditor/codestylepool.cpp b/src/plugins/texteditor/codestylepool.cpp
index 3ed439d98f..7cf1fbf60e 100644
--- a/src/plugins/texteditor/codestylepool.cpp
+++ b/src/plugins/texteditor/codestylepool.cpp
@@ -174,12 +174,10 @@ void CodeStylePool::addCodeStyle(ICodeStylePreferences *codeStyle)
     // take ownership
     codeStyle->setParent(this);
 
-    connect(codeStyle, &ICodeStylePreferences::valueChanged,
-            this, &CodeStylePool::slotSaveCodeStyle);
-    connect(codeStyle, &ICodeStylePreferences::tabSettingsChanged,
-            this, &CodeStylePool::slotSaveCodeStyle);
-    connect(codeStyle, &ICodeStylePreferences::displayNameChanged,
-            this, &CodeStylePool::slotSaveCodeStyle);
+    auto doSaveStyle = [this, codeStyle] { saveCodeStyle(codeStyle); };
+    connect(codeStyle, &ICodeStylePreferences::valueChanged, this, doSaveStyle);
+    connect(codeStyle, &ICodeStylePreferences::tabSettingsChanged, this, doSaveStyle);
+    connect(codeStyle, &ICodeStylePreferences::displayNameChanged, this, doSaveStyle);
     emit codeStyleAdded(codeStyle);
 }
 
@@ -250,15 +248,6 @@ ICodeStylePreferences *CodeStylePool::loadCodeStyle(const Utils::FilePath &fileN
     return codeStyle;
 }
 
-void CodeStylePool::slotSaveCodeStyle()
-{
-    auto codeStyle = qobject_cast<ICodeStylePreferences *>(sender());
-    if (!codeStyle)
-        return;
-
-    saveCodeStyle(codeStyle);
-}
-
 void CodeStylePool::saveCodeStyle(ICodeStylePreferences *codeStyle) const
 {
     const QString codeStylesPath = customCodeStylesPath().toString();
diff --git a/src/plugins/texteditor/codestylepool.h b/src/plugins/texteditor/codestylepool.h
index 150e57013a..3e2ce4ff98 100644
--- a/src/plugins/texteditor/codestylepool.h
+++ b/src/plugins/texteditor/codestylepool.h
@@ -69,8 +69,6 @@ signals:
     void codeStyleRemoved(ICodeStylePreferences *);
 
 private:
-    void slotSaveCodeStyle();
-
     QString settingsDir() const;
     Utils::FilePath settingsPath(const QByteArray &id) const;
     ICodeStylePreferences *loadCodeStyle(const Utils::FilePath &fileName);