diff options
author | hjk <hjk@qt.io> | 2018-05-15 12:39:56 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2018-05-16 08:22:38 +0000 |
commit | 6585edf1433f0c38111d858c399f99fbb8b99a6d (patch) | |
tree | d343a767fbc6a3088105c8512f1edb483cf70600 /src | |
parent | cf01d20f95c586caf4441c2772fa5b34fe1c5a0f (diff) |
Android: Pass RunWorker to AndroidRunnerWorker
The RunWorker will carry the amPreStart/amPostFinish commands later,
and the run control is still accessible via worker->runControl().
Change-Id: Ieac1a1d2a5a8689025a7707b218df44ef2485b16
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Diffstat (limited to 'src')
-rw-r--r-- | src/plugins/android/androidrunner.cpp | 2 | ||||
-rw-r--r-- | src/plugins/android/androidrunnerworker.cpp | 6 | ||||
-rw-r--r-- | src/plugins/android/androidrunnerworker.h | 6 |
3 files changed, 5 insertions, 9 deletions
diff --git a/src/plugins/android/androidrunner.cpp b/src/plugins/android/androidrunner.cpp index c5c6cd2d74..ce4a0c918c 100644 --- a/src/plugins/android/androidrunner.cpp +++ b/src/plugins/android/androidrunner.cpp @@ -142,7 +142,7 @@ AndroidRunner::AndroidRunner(RunControl *runControl, } const int apiLevel = AndroidManager::deviceApiLevel(m_target); - m_worker.reset(new AndroidRunnerWorker(runControl, m_androidRunnable)); + m_worker.reset(new AndroidRunnerWorker(this, m_androidRunnable)); m_worker->setIntentName(intent); m_worker->setIsPreNougat(apiLevel <= 23); m_worker->setExtraAppParams(extraAppParams); diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp index 1759aa7fbe..05071d1d06 100644 --- a/src/plugins/android/androidrunnerworker.cpp +++ b/src/plugins/android/androidrunnerworker.cpp @@ -140,7 +140,7 @@ static void deleter(QProcess *p) p->deleteLater(); } -AndroidRunnerWorker::AndroidRunnerWorker(RunControl *runControl, const AndroidRunnable &runnable) +AndroidRunnerWorker::AndroidRunnerWorker(RunWorker *runner, const AndroidRunnable &runnable) : m_androidRunnable(runnable) , m_adbLogcatProcess(nullptr, deleter) , m_psIsAlive(nullptr, deleter) @@ -149,9 +149,9 @@ AndroidRunnerWorker::AndroidRunnerWorker(RunControl *runControl, const AndroidRu , m_jdbProcess(nullptr, deleter) { - auto runConfig = runControl->runConfiguration(); + auto runConfig = runner->runControl()->runConfiguration(); auto aspect = runConfig->extraAspect<Debugger::DebuggerRunConfigurationAspect>(); - Core::Id runMode = runControl->runMode(); + Core::Id runMode = runner->runMode(); const bool debuggingMode = runMode == ProjectExplorer::Constants::DEBUG_RUN_MODE; m_useCppDebugger = debuggingMode && aspect->useCppDebugger(); if (debuggingMode && aspect->useQmlDebugger()) diff --git a/src/plugins/android/androidrunnerworker.h b/src/plugins/android/androidrunnerworker.h index 9725ee785a..768b34a19c 100644 --- a/src/plugins/android/androidrunnerworker.h +++ b/src/plugins/android/androidrunnerworker.h @@ -32,10 +32,6 @@ #include "androidrunnable.h" -namespace ProjectExplorer { -class RunControl; -} - namespace Android { class AndroidDeviceInfo; @@ -48,7 +44,7 @@ class AndroidRunnerWorker : public QObject { Q_OBJECT public: - AndroidRunnerWorker(ProjectExplorer::RunControl *runControl, const AndroidRunnable &runnable); + AndroidRunnerWorker(ProjectExplorer::RunWorker *runner, const AndroidRunnable &runnable); ~AndroidRunnerWorker() override; bool adbShellAmNeedsQuotes(); bool runAdb(const QStringList &args, int timeoutS = 10); |