aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorHenning Gruendl <henning.gruendl@qt.io>2020-10-16 11:32:21 +0200
committerHenning Gründl <henning.gruendl@qt.io>2020-10-19 12:35:53 +0000
commit9f6eb972b7dccbefe86c1aae5fa3e0499da35318 (patch)
treedf815177436f3f7b7bd625489614b4620f6d5638 /src
parent4d39f2736f3012a3defbf4a7d80fc1a21a86bdfb (diff)
QmlDesigner: Fix reversed order on Navigator drop
Task-number: QDS-2910 Change-Id: Iab58b79b6f3cdb3f922824a7f608b633b019c9ae Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp
index 78d38c082d..602a0f7316 100644
--- a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp
+++ b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp
@@ -770,7 +770,8 @@ void NavigatorTreeModel::moveNodesInteractive(NodeAbstractProperty &parentProper
auto doMoveNodesInteractive = [&parentProperty, modelNodes, targetIndex](){
const TypeName propertyQmlType = parentProperty.parentModelNode().metaInfo().propertyTypeName(parentProperty.name());
- foreach (const ModelNode &modelNode, modelNodes) {
+ int idx = targetIndex;
+ for (const ModelNode &modelNode : modelNodes) {
if (modelNode.isValid()
&& modelNode != parentProperty.parentModelNode()
&& !modelNode.isAncestorOf(parentProperty.parentModelNode())
@@ -779,10 +780,9 @@ void NavigatorTreeModel::moveNodesInteractive(NodeAbstractProperty &parentProper
//once the MetaInfo is part of instances we can do this right
bool nodeCanBeMovedToParentProperty = removeModelNodeFromNodeProperty(parentProperty, modelNode);
-
if (nodeCanBeMovedToParentProperty) {
reparentModelNodeToNodeProperty(parentProperty, modelNode);
- slideModelNodeInList(parentProperty, modelNode, targetIndex);
+ slideModelNodeInList(parentProperty, modelNode, idx++);
}
}
}