diff options
| author | Alessandro Portale <alessandro.portale@qt.io> | 2020-01-23 13:32:41 +0100 |
|---|---|---|
| committer | Alessandro Portale <alessandro.portale@qt.io> | 2020-01-23 14:33:31 +0000 |
| commit | ae9fbd04dd932707e8538676343ec6c6d5bcd250 (patch) | |
| tree | afd11be811a16246e254b45a83246805b2c8b06e /src | |
| parent | bf7b16d9ca2da237b1eb915a7c2ff83bfa482d3a (diff) | |
Core: Make the revision sha in VersionDialog a clickable link
The base URL can be defined via the IDE branding mechanism. If omitted,
the revision is plain text, like before this change.
Change-Id: If1a74707a10c76e15d3d25b8e6b0c302219fb91d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/app/app_version.h.cmakein | 1 | ||||
| -rw-r--r-- | src/plugins/coreplugin/versiondialog.cpp | 7 |
2 files changed, 7 insertions, 1 deletions
diff --git a/src/app/app_version.h.cmakein b/src/app/app_version.h.cmakein index 86074a22e97..79ac4397ce2 100644 --- a/src/app/app_version.h.cmakein +++ b/src/app/app_version.h.cmakein @@ -44,6 +44,7 @@ const char IDE_CASED_ID[] = "${IDE_CASED_ID}"; const char IDE_VERSION_DISPLAY[] = "${IDE_VERSION_DISPLAY}"; const char IDE_REVISION_STR[] = "${IDE_REVISION_STR}"; +const char IDE_REVISION_URL[] = "${IDE_REVISION_URL}"; // changes the path where the settings are saved to const char IDE_SETTINGSVARIANT_STR[] = "${IDE_SETTINGSVARIANT}"; diff --git a/src/plugins/coreplugin/versiondialog.cpp b/src/plugins/coreplugin/versiondialog.cpp index 045bc60da38..90897ddb1fb 100644 --- a/src/plugins/coreplugin/versiondialog.cpp +++ b/src/plugins/coreplugin/versiondialog.cpp @@ -59,7 +59,12 @@ VersionDialog::VersionDialog(QWidget *parent) QString ideRev; #ifdef IDE_REVISION //: This gets conditionally inserted as argument %8 into the description string. - ideRev = tr("<br/>From revision %1<br/>").arg(QString::fromLatin1(Constants::IDE_REVISION_STR).left(10)); + const QString revUrl = QString::fromLatin1(Constants::IDE_REVISION_URL); + const QString revStr = QString::fromLatin1(Constants::IDE_REVISION_STR); + ideRev = tr("<br/>From revision %1<br/>") + .arg(revUrl.isEmpty() ? revStr.left(10) + : QString::fromLatin1("<a href=\"%1\">%2</a>") + .arg(revUrl.arg(revStr), revStr.left(10))); #endif QString buildDateInfo; #ifdef QTC_SHOW_BUILD_DATE |