diff options
| author | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2019-06-19 15:16:15 +0200 |
|---|---|---|
| committer | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2019-06-25 07:18:50 +0000 |
| commit | b52789bce0a32eb40396857fa975aef9f2c17f20 (patch) | |
| tree | cbfd8fc454ce02f44f48ad3800b155bf4f57a807 /src | |
| parent | 241c35272399f8e87ebeefc58f3d83ec808a8f61 (diff) | |
ClangTools: Make building before starting analysis default
...when switching to "Custom Settings" in Menu: Analyze > "Clang Tidy
and Clazy...".
Otherwise we might run into parse errors due not yet generated source
files (e.g. "fatal error: 'ui_mainwindow.h' file not found").
Task-number: QTCREATORBUG-22382
Change-Id: I6f499fa8f8ab2fff08d19165e474d14305cfded5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/clangtools/clangtoolsprojectsettings.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/plugins/clangtools/clangtoolsprojectsettings.cpp b/src/plugins/clangtools/clangtoolsprojectsettings.cpp index bc8a3cabb6..55573c8ee6 100644 --- a/src/plugins/clangtools/clangtoolsprojectsettings.cpp +++ b/src/plugins/clangtools/clangtoolsprojectsettings.cpp @@ -87,7 +87,9 @@ void ClangToolsProjectSettings::load() m_useGlobalSettings = useGlobalVariant.isValid() ? useGlobalVariant.toBool() : true; m_diagnosticConfig = Core::Id::fromSetting( m_project->namedSettings(SETTINGS_KEY_DIAGNOSTIC_CONFIG)); - m_buildBeforeAnalysis = m_project->namedSettings(SETTINGS_KEY_BUILD_BEFORE_ANALYSIS).toBool(); + + const QVariant value = m_project->namedSettings(SETTINGS_KEY_BUILD_BEFORE_ANALYSIS); + m_buildBeforeAnalysis = value.isValid() ? value.toBool() : true; auto toFileName = [](const QString &s) { return Utils::FilePath::fromString(s); }; |