aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2020-01-27 08:58:38 +0100
committerhjk <hjk@qt.io>2020-01-30 15:04:58 +0000
commitc3f7ef53408bf7ea18ae7eb1e0a3f6858f4041d2 (patch)
tree2c14af6044dfe634cdc2e4b74a9e594a3632932d /src
parent8b117bcd86a222c8a1ada6b3a182f4c488ff8d38 (diff)
Several SettingsPages: Code cosmetics
De-Q_OBJECT-ify, remove unnecessary #includes, final-ize, etc. Change-Id: I461d3e73400dacac90c22e7c84a40e3ea1718b6e Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/plugins/baremetal/debugserverproviderssettingspage.cpp2
-rw-r--r--src/plugins/baremetal/debugserverproviderssettingspage.h2
-rw-r--r--src/plugins/cmakeprojectmanager/cmakesettingspage.h2
-rw-r--r--src/plugins/cpptools/cppcodemodelsettingspage.h2
-rw-r--r--src/plugins/help/docsettingspage.cpp4
-rw-r--r--src/plugins/help/docsettingspage.h4
-rw-r--r--src/plugins/ios/iossettingspage.h2
-rw-r--r--src/plugins/mcusupport/mcusupportoptionspage.h2
-rw-r--r--src/plugins/nim/settings/nimcodestylesettingspage.cpp4
-rw-r--r--src/plugins/nim/settings/nimcodestylesettingspage.h6
-rw-r--r--src/plugins/nim/settings/nimtoolssettingspage.cpp2
-rw-r--r--src/plugins/nim/settings/nimtoolssettingspage.h8
-rw-r--r--src/plugins/perforce/settingspage.cpp2
-rw-r--r--src/plugins/perforce/settingspage.h6
-rw-r--r--src/plugins/perfprofiler/perfoptionspage.h3
-rw-r--r--src/plugins/projectexplorer/appoutputpane.cpp2
-rw-r--r--src/plugins/projectexplorer/appoutputpane.h4
-rw-r--r--src/plugins/projectexplorer/compileoutputwindow.cpp2
-rw-r--r--src/plugins/projectexplorer/compileoutputwindow.h4
-rw-r--r--src/plugins/projectexplorer/devicesupport/devicesettingspage.cpp2
-rw-r--r--src/plugins/projectexplorer/devicesupport/devicesettingspage.h4
-rw-r--r--src/plugins/projectexplorer/kitoptionspage.cpp4
-rw-r--r--src/plugins/projectexplorer/kitoptionspage.h6
-rw-r--r--src/plugins/projectexplorer/projectexplorersettingspage.cpp7
-rw-r--r--src/plugins/projectexplorer/projectexplorersettingspage.h3
-rw-r--r--src/plugins/qmakeprojectmanager/qmakesettings.cpp2
-rw-r--r--src/plugins/qmakeprojectmanager/qmakesettings.h3
-rw-r--r--src/plugins/qmldesigner/settingspage.cpp2
-rw-r--r--src/plugins/qmldesigner/settingspage.h4
-rw-r--r--src/plugins/qmljstools/qmljscodestylesettingspage.h2
-rw-r--r--src/plugins/qmlprofiler/qmlprofileroptionspage.cpp2
-rw-r--r--src/plugins/qmlprofiler/qmlprofileroptionspage.h3
-rw-r--r--src/plugins/qnx/qnxsettingspage.h2
33 files changed, 39 insertions, 70 deletions
diff --git a/src/plugins/baremetal/debugserverproviderssettingspage.cpp b/src/plugins/baremetal/debugserverproviderssettingspage.cpp
index dfb5a456c9..0c18aeaf38 100644
--- a/src/plugins/baremetal/debugserverproviderssettingspage.cpp
+++ b/src/plugins/baremetal/debugserverproviderssettingspage.cpp
@@ -449,7 +449,7 @@ QModelIndex DebugServerProvidersSettingsWidget::currentIndex() const
DebugServerProvidersSettingsPage::DebugServerProvidersSettingsPage()
{
setId(Constants::DEBUG_SERVER_PROVIDERS_SETTINGS_ID);
- setDisplayName(tr("Bare Metal"));
+ setDisplayName(DebugServerProvidersSettingsWidget::tr("Bare Metal"));
setCategory(ProjectExplorer::Constants::DEVICE_SETTINGS_CATEGORY);
setWidgetCreator([] { return new DebugServerProvidersSettingsWidget; });
}
diff --git a/src/plugins/baremetal/debugserverproviderssettingspage.h b/src/plugins/baremetal/debugserverproviderssettingspage.h
index 4e2d7d2337..5636107b83 100644
--- a/src/plugins/baremetal/debugserverproviderssettingspage.h
+++ b/src/plugins/baremetal/debugserverproviderssettingspage.h
@@ -84,8 +84,6 @@ private:
class DebugServerProvidersSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
DebugServerProvidersSettingsPage();
};
diff --git a/src/plugins/cmakeprojectmanager/cmakesettingspage.h b/src/plugins/cmakeprojectmanager/cmakesettingspage.h
index 6d1646545b..e3e6ad4b43 100644
--- a/src/plugins/cmakeprojectmanager/cmakesettingspage.h
+++ b/src/plugins/cmakeprojectmanager/cmakesettingspage.h
@@ -30,7 +30,7 @@
namespace CMakeProjectManager {
namespace Internal {
-class CMakeSettingsPage : public Core::IOptionsPage
+class CMakeSettingsPage final : public Core::IOptionsPage
{
public:
CMakeSettingsPage();
diff --git a/src/plugins/cpptools/cppcodemodelsettingspage.h b/src/plugins/cpptools/cppcodemodelsettingspage.h
index 3cfd1e3b39..7ca9b64f28 100644
--- a/src/plugins/cpptools/cppcodemodelsettingspage.h
+++ b/src/plugins/cpptools/cppcodemodelsettingspage.h
@@ -29,8 +29,6 @@
#include <coreplugin/dialogs/ioptionspage.h>
-#include <QPointer>
-
namespace CppTools {
namespace Internal {
diff --git a/src/plugins/help/docsettingspage.cpp b/src/plugins/help/docsettingspage.cpp
index 17c54c0827..cbb161d235 100644
--- a/src/plugins/help/docsettingspage.cpp
+++ b/src/plugins/help/docsettingspage.cpp
@@ -131,6 +131,8 @@ using namespace Help::Internal;
class DocSettingsPageWidget : public Core::IOptionsPageWidget
{
+ Q_DECLARE_TR_FUNCTIONS(Help::DocSettingsPage)
+
public:
DocSettingsPageWidget()
{
@@ -324,7 +326,7 @@ QList<QModelIndex> DocSettingsPageWidget::currentSelection() const
DocSettingsPage::DocSettingsPage()
{
setId("B.Documentation");
- setDisplayName(tr("Documentation"));
+ setDisplayName(DocSettingsPageWidget::tr("Documentation"));
setCategory(Help::Constants::HELP_CATEGORY);
setWidgetCreator([] { return new DocSettingsPageWidget; });
}
diff --git a/src/plugins/help/docsettingspage.h b/src/plugins/help/docsettingspage.h
index 3c5bc35960..eca3fd3c07 100644
--- a/src/plugins/help/docsettingspage.h
+++ b/src/plugins/help/docsettingspage.h
@@ -30,10 +30,8 @@
namespace Help {
namespace Internal {
-class DocSettingsPage : public Core::IOptionsPage
+class DocSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
DocSettingsPage();
};
diff --git a/src/plugins/ios/iossettingspage.h b/src/plugins/ios/iossettingspage.h
index 509ba5b8d3..f8a179f936 100644
--- a/src/plugins/ios/iossettingspage.h
+++ b/src/plugins/ios/iossettingspage.h
@@ -30,7 +30,7 @@
namespace Ios {
namespace Internal {
-class IosSettingsPage : public Core::IOptionsPage
+class IosSettingsPage final : public Core::IOptionsPage
{
public:
IosSettingsPage();
diff --git a/src/plugins/mcusupport/mcusupportoptionspage.h b/src/plugins/mcusupport/mcusupportoptionspage.h
index f273369a44..fdd5a1c586 100644
--- a/src/plugins/mcusupport/mcusupportoptionspage.h
+++ b/src/plugins/mcusupport/mcusupportoptionspage.h
@@ -30,7 +30,7 @@
namespace McuSupport {
namespace Internal {
-class McuSupportOptionsPage : public Core::IOptionsPage
+class McuSupportOptionsPage final : public Core::IOptionsPage
{
public:
McuSupportOptionsPage();
diff --git a/src/plugins/nim/settings/nimcodestylesettingspage.cpp b/src/plugins/nim/settings/nimcodestylesettingspage.cpp
index 25af75e087..ba94084ba9 100644
--- a/src/plugins/nim/settings/nimcodestylesettingspage.cpp
+++ b/src/plugins/nim/settings/nimcodestylesettingspage.cpp
@@ -42,6 +42,8 @@ namespace Nim {
class NimCodeStyleSettingsWidget : public Core::IOptionsPageWidget
{
+ Q_DECLARE_TR_FUNCTIONS(Nim::CodeStyleSettings)
+
public:
NimCodeStyleSettingsWidget()
{
@@ -72,7 +74,7 @@ NimCodeStyleSettingsPage::NimCodeStyleSettingsPage()
setId(Nim::Constants::C_NIMCODESTYLESETTINGSPAGE_ID);
setDisplayName(tr(Nim::Constants::C_NIMCODESTYLESETTINGSPAGE_DISPLAY));
setCategory(Nim::Constants::C_NIMCODESTYLESETTINGSPAGE_CATEGORY);
- setDisplayCategory(tr("Nim"));
+ setDisplayCategory(NimCodeStyleSettingsWidget::tr("Nim"));
setCategoryIconPath(":/nim/images/settingscategory_nim.png");
setWidgetCreator([] { return new NimCodeStyleSettingsWidget; });
}
diff --git a/src/plugins/nim/settings/nimcodestylesettingspage.h b/src/plugins/nim/settings/nimcodestylesettingspage.h
index 6341e298c0..0264c43ef8 100644
--- a/src/plugins/nim/settings/nimcodestylesettingspage.h
+++ b/src/plugins/nim/settings/nimcodestylesettingspage.h
@@ -29,12 +29,10 @@
namespace Nim {
-class NimCodeStyleSettingsPage : public Core::IOptionsPage
+class NimCodeStyleSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
NimCodeStyleSettingsPage();
};
-}
+} // Nim
diff --git a/src/plugins/nim/settings/nimtoolssettingspage.cpp b/src/plugins/nim/settings/nimtoolssettingspage.cpp
index 99be94460a..c487ab06d3 100644
--- a/src/plugins/nim/settings/nimtoolssettingspage.cpp
+++ b/src/plugins/nim/settings/nimtoolssettingspage.cpp
@@ -59,7 +59,7 @@ NimToolsSettingsPage::NimToolsSettingsPage(NimSettings *settings)
: m_settings(settings)
{
setId(Nim::Constants::C_NIMTOOLSSETTINGSPAGE_ID);
- setDisplayName(tr(Nim::Constants::C_NIMTOOLSSETTINGSPAGE_DISPLAY));
+ setDisplayName(NimToolsSettingsWidget::tr(Nim::Constants::C_NIMTOOLSSETTINGSPAGE_DISPLAY));
setCategory(Nim::Constants::C_NIMTOOLSSETTINGSPAGE_CATEGORY);
setDisplayCategory(tr("Nim"));
setCategoryIconPath(":/nim/images/settingscategory_nim.png");
diff --git a/src/plugins/nim/settings/nimtoolssettingspage.h b/src/plugins/nim/settings/nimtoolssettingspage.h
index e0de799960..3dbe3ea566 100644
--- a/src/plugins/nim/settings/nimtoolssettingspage.h
+++ b/src/plugins/nim/settings/nimtoolssettingspage.h
@@ -40,7 +40,7 @@ namespace Ui { class NimToolsSettingsWidget; }
class NimToolsSettingsWidget : public QWidget
{
- Q_OBJECT
+ Q_DECLARE_TR_FUNCTIONS(Nim::ToolSettingsPage)
public:
explicit NimToolsSettingsWidget(NimSettings *settings);
@@ -55,12 +55,10 @@ private:
NimSettings *m_settings = nullptr;
};
-class NimToolsSettingsPage : public Core::IOptionsPage
+class NimToolsSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
- NimToolsSettingsPage(NimSettings *settings);
+ explicit NimToolsSettingsPage(NimSettings *settings);
~NimToolsSettingsPage();
diff --git a/src/plugins/perforce/settingspage.cpp b/src/plugins/perforce/settingspage.cpp
index 09251e90ea..f5ca11d6f2 100644
--- a/src/plugins/perforce/settingspage.cpp
+++ b/src/plugins/perforce/settingspage.cpp
@@ -121,7 +121,7 @@ SettingsPage::SettingsPage(QObject *parent)
: Core::IOptionsPage(parent)
{
setId(VcsBase::Constants::VCS_ID_PERFORCE);
- setDisplayName(tr("Perforce"));
+ setDisplayName(SettingsPageWidget::tr("Perforce"));
setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY);
}
diff --git a/src/plugins/perforce/settingspage.h b/src/plugins/perforce/settingspage.h
index c3b5c6bb41..25c31e615f 100644
--- a/src/plugins/perforce/settingspage.h
+++ b/src/plugins/perforce/settingspage.h
@@ -38,7 +38,7 @@ struct Settings;
class SettingsPageWidget : public QWidget
{
- Q_OBJECT
+ Q_DECLARE_TR_FUNCTIONS(Perforce::Internal::SettingsPage)
public:
explicit SettingsPageWidget(QWidget *parent = nullptr);
@@ -57,10 +57,8 @@ private:
PerforceChecker *m_checker = nullptr;
};
-class SettingsPage : public Core::IOptionsPage
+class SettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
explicit SettingsPage(QObject *parent);
~SettingsPage() override;
diff --git a/src/plugins/perfprofiler/perfoptionspage.h b/src/plugins/perfprofiler/perfoptionspage.h
index c873fc8f7e..b4259a9e5d 100644
--- a/src/plugins/perfprofiler/perfoptionspage.h
+++ b/src/plugins/perfprofiler/perfoptionspage.h
@@ -33,9 +33,8 @@ class PerfSettings;
namespace Internal {
-class PerfOptionsPage : public Core::IOptionsPage
+class PerfOptionsPage final : public Core::IOptionsPage
{
- Q_OBJECT
public:
explicit PerfOptionsPage(PerfSettings *settings);
};
diff --git a/src/plugins/projectexplorer/appoutputpane.cpp b/src/plugins/projectexplorer/appoutputpane.cpp
index 5211ad277a..c777a61ee8 100644
--- a/src/plugins/projectexplorer/appoutputpane.cpp
+++ b/src/plugins/projectexplorer/appoutputpane.cpp
@@ -889,7 +889,7 @@ private:
AppOutputSettingsPage::AppOutputSettingsPage()
{
setId(OPTIONS_PAGE_ID);
- setDisplayName(tr("Application Output"));
+ setDisplayName(AppOutputSettingsWidget::tr("Application Output"));
setCategory(Constants::BUILD_AND_RUN_SETTINGS_CATEGORY);
setWidgetCreator([] { return new AppOutputSettingsWidget; });
}
diff --git a/src/plugins/projectexplorer/appoutputpane.h b/src/plugins/projectexplorer/appoutputpane.h
index 5c5a045508..f682cfe296 100644
--- a/src/plugins/projectexplorer/appoutputpane.h
+++ b/src/plugins/projectexplorer/appoutputpane.h
@@ -159,10 +159,8 @@ private:
AppOutputSettings m_settings;
};
-class AppOutputSettingsPage : public Core::IOptionsPage
+class AppOutputSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
AppOutputSettingsPage();
};
diff --git a/src/plugins/projectexplorer/compileoutputwindow.cpp b/src/plugins/projectexplorer/compileoutputwindow.cpp
index ed57c77af8..3eeedee281 100644
--- a/src/plugins/projectexplorer/compileoutputwindow.cpp
+++ b/src/plugins/projectexplorer/compileoutputwindow.cpp
@@ -411,7 +411,7 @@ private:
CompileOutputSettingsPage::CompileOutputSettingsPage()
{
setId(OPTIONS_PAGE_ID);
- setDisplayName(tr("Compile Output"));
+ setDisplayName(CompileOutputSettingsWidget::tr("Compile Output"));
setCategory(Constants::BUILD_AND_RUN_SETTINGS_CATEGORY);
setWidgetCreator([] { return new CompileOutputSettingsWidget; });
}
diff --git a/src/plugins/projectexplorer/compileoutputwindow.h b/src/plugins/projectexplorer/compileoutputwindow.h
index ea3c303071..71a619a76a 100644
--- a/src/plugins/projectexplorer/compileoutputwindow.h
+++ b/src/plugins/projectexplorer/compileoutputwindow.h
@@ -102,10 +102,8 @@ private:
CompileOutputSettings m_settings;
};
-class CompileOutputSettingsPage : public Core::IOptionsPage
+class CompileOutputSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
CompileOutputSettingsPage();
};
diff --git a/src/plugins/projectexplorer/devicesupport/devicesettingspage.cpp b/src/plugins/projectexplorer/devicesupport/devicesettingspage.cpp
index bc0285940e..2dbe8a2375 100644
--- a/src/plugins/projectexplorer/devicesupport/devicesettingspage.cpp
+++ b/src/plugins/projectexplorer/devicesupport/devicesettingspage.cpp
@@ -37,7 +37,7 @@ namespace Internal {
DeviceSettingsPage::DeviceSettingsPage()
{
setId(Constants::DEVICE_SETTINGS_PAGE_ID);
- setDisplayName(tr("Devices"));
+ setDisplayName(DeviceSettingsWidget::tr("Devices"));
setCategory(Constants::DEVICE_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Devices"));
setCategoryIconPath(":/projectexplorer/images/settingscategory_devices.png");
diff --git a/src/plugins/projectexplorer/devicesupport/devicesettingspage.h b/src/plugins/projectexplorer/devicesupport/devicesettingspage.h
index 6c1350314e..6dc91b59c3 100644
--- a/src/plugins/projectexplorer/devicesupport/devicesettingspage.h
+++ b/src/plugins/projectexplorer/devicesupport/devicesettingspage.h
@@ -30,10 +30,8 @@
namespace ProjectExplorer {
namespace Internal {
-class DeviceSettingsPage : public Core::IOptionsPage
+class DeviceSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
DeviceSettingsPage();
};
diff --git a/src/plugins/projectexplorer/kitoptionspage.cpp b/src/plugins/projectexplorer/kitoptionspage.cpp
index fc34abf450..433d2a2413 100644
--- a/src/plugins/projectexplorer/kitoptionspage.cpp
+++ b/src/plugins/projectexplorer/kitoptionspage.cpp
@@ -51,6 +51,8 @@ namespace Internal {
class KitOptionsPageWidget : public QWidget
{
+ Q_DECLARE_TR_FUNCTIONS(ProjextExplorer::Internal::KitOptionsPage)
+
public:
KitOptionsPageWidget();
@@ -269,7 +271,7 @@ KitOptionsPage::KitOptionsPage()
{
theKitOptionsPage = this;
setId(Constants::KITS_SETTINGS_PAGE_ID);
- setDisplayName(tr("Kits"));
+ setDisplayName(Internal::KitOptionsPageWidget::tr("Kits"));
setCategory(Constants::KITS_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Kits"));
setCategoryIconPath(":/projectexplorer/images/settingscategory_kits.png");
diff --git a/src/plugins/projectexplorer/kitoptionspage.h b/src/plugins/projectexplorer/kitoptionspage.h
index 7e7f02b363..57c593d680 100644
--- a/src/plugins/projectexplorer/kitoptionspage.h
+++ b/src/plugins/projectexplorer/kitoptionspage.h
@@ -37,14 +37,8 @@ namespace Internal { class KitOptionsPageWidget; }
class Kit;
-// --------------------------------------------------------------------------
-// KitOptionsPage:
-// --------------------------------------------------------------------------
-
class PROJECTEXPLORER_EXPORT KitOptionsPage : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
KitOptionsPage();
diff --git a/src/plugins/projectexplorer/projectexplorersettingspage.cpp b/src/plugins/projectexplorer/projectexplorersettingspage.cpp
index 113c070ae3..4172424160 100644
--- a/src/plugins/projectexplorer/projectexplorersettingspage.cpp
+++ b/src/plugins/projectexplorer/projectexplorersettingspage.cpp
@@ -33,7 +33,6 @@
#include <utils/hostosinfo.h>
#include <QCoreApplication>
-#include <QWidget>
namespace ProjectExplorer {
namespace Internal {
@@ -42,7 +41,7 @@ namespace Internal {
class ProjectExplorerSettingsWidget : public QWidget
{
- Q_OBJECT
+ Q_DECLARE_TR_FUNCTIONS(ProjextExplorer::Internal::ProjectExplorerSettings)
public:
explicit ProjectExplorerSettingsWidget(QWidget *parent = nullptr);
@@ -169,7 +168,7 @@ void ProjectExplorerSettingsWidget::slotDirectoryButtonGroupChanged()
ProjectExplorerSettingsPage::ProjectExplorerSettingsPage()
{
setId(Constants::BUILD_AND_RUN_SETTINGS_PAGE_ID);
- setDisplayName(tr("General"));
+ setDisplayName(ProjectExplorerSettingsWidget::tr("General"));
setCategory(Constants::BUILD_AND_RUN_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Build & Run"));
setCategoryIconPath(":/projectexplorer/images/settingscategory_buildrun.png");
@@ -203,5 +202,3 @@ void ProjectExplorerSettingsPage::finish()
} // namespace Internal
} // namespace ProjectExplorer
-
-#include "projectexplorersettingspage.moc"
diff --git a/src/plugins/projectexplorer/projectexplorersettingspage.h b/src/plugins/projectexplorer/projectexplorersettingspage.h
index 0f4d3ef7e7..2470e5d0aa 100644
--- a/src/plugins/projectexplorer/projectexplorersettingspage.h
+++ b/src/plugins/projectexplorer/projectexplorersettingspage.h
@@ -30,7 +30,6 @@
#include <coreplugin/dialogs/ioptionspage.h>
#include <QPointer>
-#include <QUuid>
namespace ProjectExplorer {
namespace Internal {
@@ -40,8 +39,6 @@ class ProjectExplorerSettingsWidget;
class ProjectExplorerSettingsPage : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
ProjectExplorerSettingsPage();
diff --git a/src/plugins/qmakeprojectmanager/qmakesettings.cpp b/src/plugins/qmakeprojectmanager/qmakesettings.cpp
index 37c0a4ce39..dd2fdb4e5d 100644
--- a/src/plugins/qmakeprojectmanager/qmakesettings.cpp
+++ b/src/plugins/qmakeprojectmanager/qmakesettings.cpp
@@ -132,7 +132,7 @@ private:
QmakeSettingsPage::QmakeSettingsPage()
{
setId("K.QmakeProjectManager.QmakeSettings");
- setDisplayName(tr("Qmake"));
+ setDisplayName(SettingsWidget::tr("Qmake"));
setCategory(ProjectExplorer::Constants::BUILD_AND_RUN_SETTINGS_CATEGORY);
}
diff --git a/src/plugins/qmakeprojectmanager/qmakesettings.h b/src/plugins/qmakeprojectmanager/qmakesettings.h
index 6918483595..b2b1a75a9d 100644
--- a/src/plugins/qmakeprojectmanager/qmakesettings.h
+++ b/src/plugins/qmakeprojectmanager/qmakesettings.h
@@ -59,9 +59,8 @@ private:
QmakeSettingsData m_settings;
};
-class QmakeSettingsPage : public Core::IOptionsPage
+class QmakeSettingsPage final : public Core::IOptionsPage
{
- Q_OBJECT
public:
QmakeSettingsPage();
diff --git a/src/plugins/qmldesigner/settingspage.cpp b/src/plugins/qmldesigner/settingspage.cpp
index 6cfc1ebf45..011f52c6e0 100644
--- a/src/plugins/qmldesigner/settingspage.cpp
+++ b/src/plugins/qmldesigner/settingspage.cpp
@@ -244,7 +244,7 @@ SettingsPage::SettingsPage() :
m_widget(nullptr)
{
setId("B.QmlDesigner");
- setDisplayName(tr("Qt Quick Designer"));
+ setDisplayName(SettingsPageWidget::tr("Qt Quick Designer"));
setCategory(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML);
}
diff --git a/src/plugins/qmldesigner/settingspage.h b/src/plugins/qmldesigner/settingspage.h
index 237b5d3107..095e8bc99b 100644
--- a/src/plugins/qmldesigner/settingspage.h
+++ b/src/plugins/qmldesigner/settingspage.h
@@ -44,7 +44,7 @@ namespace Internal {
class SettingsPageWidget : public QWidget
{
- Q_OBJECT
+ Q_DECLARE_TR_FUNCTIONS(QmlDesigner::Internal::SettingsPage)
public:
explicit SettingsPageWidget(QWidget *parent = nullptr);
@@ -59,8 +59,6 @@ private:
class SettingsPage : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
SettingsPage();
diff --git a/src/plugins/qmljstools/qmljscodestylesettingspage.h b/src/plugins/qmljstools/qmljscodestylesettingspage.h
index cdafb430fc..5f6bc2545a 100644
--- a/src/plugins/qmljstools/qmljscodestylesettingspage.h
+++ b/src/plugins/qmljstools/qmljscodestylesettingspage.h
@@ -68,8 +68,6 @@ private:
class QmlJSCodeStyleSettingsPage : public Core::IOptionsPage
{
- Q_OBJECT
-
public:
QmlJSCodeStyleSettingsPage();
diff --git a/src/plugins/qmlprofiler/qmlprofileroptionspage.cpp b/src/plugins/qmlprofiler/qmlprofileroptionspage.cpp
index c67d74fe58..3f75b0f9bd 100644
--- a/src/plugins/qmlprofiler/qmlprofileroptionspage.cpp
+++ b/src/plugins/qmlprofiler/qmlprofileroptionspage.cpp
@@ -36,7 +36,7 @@ namespace Internal {
QmlProfilerOptionsPage::QmlProfilerOptionsPage()
{
setId(Constants::SETTINGS);
- setDisplayName(tr("QML Profiler"));
+ setDisplayName(QmlProfilerConfigWidget::tr("QML Profiler"));
setCategory("T.Analyzer");
setDisplayCategory(tr("Analyzer"));
setCategoryIconPath(Analyzer::Icons::SETTINGSCATEGORY_ANALYZER);
diff --git a/src/plugins/qmlprofiler/qmlprofileroptionspage.h b/src/plugins/qmlprofiler/qmlprofileroptionspage.h
index f3497e398c..3278de15d7 100644
--- a/src/plugins/qmlprofiler/qmlprofileroptionspage.h
+++ b/src/plugins/qmlprofiler/qmlprofileroptionspage.h
@@ -31,9 +31,8 @@
namespace QmlProfiler {
namespace Internal {
-class QmlProfilerOptionsPage : public Core::IOptionsPage
+class QmlProfilerOptionsPage final : public Core::IOptionsPage
{
- Q_OBJECT
public:
QmlProfilerOptionsPage();
diff --git a/src/plugins/qnx/qnxsettingspage.h b/src/plugins/qnx/qnxsettingspage.h
index 3721c70222..d05f3d4c1c 100644
--- a/src/plugins/qnx/qnxsettingspage.h
+++ b/src/plugins/qnx/qnxsettingspage.h
@@ -30,7 +30,7 @@
namespace Qnx {
namespace Internal {
-class QnxSettingsPage : public Core::IOptionsPage
+class QnxSettingsPage final : public Core::IOptionsPage
{
public:
QnxSettingsPage();