diff options
| author | hjk <hjk@qt.io> | 2019-06-19 08:43:49 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-06-19 09:01:40 +0000 |
| commit | fa57e933a9763593eaf403c2a40038cb59903f4b (patch) | |
| tree | bfde599b0442d4c213a3e53768dcd1f3d938cd49 /src | |
| parent | 0b46371ca541155daf4899de39efc6a55184d489 (diff) | |
ProjectExplorer: Remove MsvcToolChainFactory::create()
This was doing effectively the same as the base constructor with
all code paths overriding the values set here.
Change-Id: I41e29bc5ae5ef7d99ff4adc7beed738c49a3139f
Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/projectexplorer/msvctoolchain.cpp | 7 | ||||
| -rw-r--r-- | src/plugins/projectexplorer/msvctoolchain.h | 1 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/plugins/projectexplorer/msvctoolchain.cpp b/src/plugins/projectexplorer/msvctoolchain.cpp index cf927acbe3..060334382a 100644 --- a/src/plugins/projectexplorer/msvctoolchain.cpp +++ b/src/plugins/projectexplorer/msvctoolchain.cpp @@ -2122,13 +2122,6 @@ bool MsvcToolChainFactory::canCreate() const return !g_availableMsvcToolchains.isEmpty(); } -ToolChain *MsvcToolChainFactory::create() -{ - auto tc = new MsvcToolChain(Constants::MSVC_TOOLCHAIN_TYPEID); - tc->setupVarsBat(Abi::hostAbi(), g_availableMsvcToolchains.first()->varsBat(), ""); - return tc; -} - MsvcToolChain::WarningFlagAdder::WarningFlagAdder(const QString &flag, WarningFlags &flags) : m_flags(flags) { diff --git a/src/plugins/projectexplorer/msvctoolchain.h b/src/plugins/projectexplorer/msvctoolchain.h index d540ed7933..3bc92241e4 100644 --- a/src/plugins/projectexplorer/msvctoolchain.h +++ b/src/plugins/projectexplorer/msvctoolchain.h @@ -210,7 +210,6 @@ public: QList<ToolChain *> autoDetect(const QList<ToolChain *> &alreadyKnown) override; bool canCreate() const override; - ToolChain *create() override; static QString vcVarsBatFor(const QString &basePath, MsvcToolChain::Platform platform, |