aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
Diffstat
-rw-r--r--src/libs/languageserverprotocol/workspace.cpp2
-rw-r--r--src/libs/utils/algorithm.h2
-rw-r--r--src/plugins/android/avddialog.cpp4
-rw-r--r--src/plugins/clangtools/clangtool.cpp2
-rw-r--r--src/plugins/clangtools/clangtoolsutils.cpp2
-rw-r--r--src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp3
-rw-r--r--src/plugins/cpptools/cppprojectinfogenerator.cpp2
-rw-r--r--src/plugins/ctfvisualizer/ctftimelinemodel.cpp2
-rw-r--r--src/plugins/debugger/commonoptionspage.cpp2
-rw-r--r--src/plugins/debugger/debuggerengine.cpp2
-rw-r--r--src/plugins/git/giteditor.cpp2
-rw-r--r--src/plugins/help/helpindexfilter.cpp2
-rw-r--r--src/plugins/help/helpmanager.cpp4
-rw-r--r--src/plugins/ios/iosbuildconfiguration.cpp2
-rw-r--r--src/plugins/python/pythonutils.cpp4
-rw-r--r--src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp4
-rw-r--r--src/plugins/qnx/qnxutils.cpp2
-rw-r--r--src/plugins/qtsupport/baseqtversion.cpp2
-rw-r--r--src/plugins/texteditor/textindenter.cpp2
-rw-r--r--src/plugins/valgrind/memchecktool.cpp2
20 files changed, 25 insertions, 24 deletions
diff --git a/src/libs/languageserverprotocol/workspace.cpp b/src/libs/languageserverprotocol/workspace.cpp
index 28af2cbafc..267566042e 100644
--- a/src/libs/languageserverprotocol/workspace.cpp
+++ b/src/libs/languageserverprotocol/workspace.cpp
@@ -104,7 +104,7 @@ LanguageServerProtocol::WorkSpaceFolderResult::operator const QJsonValue() const
if (!Utils::holds_alternative<QList<WorkSpaceFolder>>(*this))
return QJsonValue::Null;
QJsonArray array;
- for (auto folder : Utils::get<QList<WorkSpaceFolder>>(*this))
+ for (const auto &folder : Utils::get<QList<WorkSpaceFolder>>(*this))
array.append(QJsonValue(folder));
return array;
}
diff --git a/src/libs/utils/algorithm.h b/src/libs/utils/algorithm.h
index ec4d6e9002..75937b65aa 100644
--- a/src/libs/utils/algorithm.h
+++ b/src/libs/utils/algorithm.h
@@ -904,7 +904,7 @@ std::tuple<C, C> partition(const C &container, F predicate)
reserve(miss, container.size());
auto hitIns = inserter(hit);
auto missIns = inserter(miss);
- for (auto i : container) {
+ for (const auto &i : container) {
if (predicate(i))
hitIns = i;
else
diff --git a/src/plugins/android/avddialog.cpp b/src/plugins/android/avddialog.cpp
index 3e11cd1823..878ccad276 100644
--- a/src/plugins/android/avddialog.cpp
+++ b/src/plugins/android/avddialog.cpp
@@ -135,7 +135,7 @@ void AvdDialog::parseDeviceDefinitionsList()
QStringList avdDeviceInfo;
- for (QString line : output.split('\n')) {
+ for (const QString &line : output.split('\n')) {
if (line.startsWith("---------") || line.isEmpty()) {
DeviceDefinitionStruct deviceDefinition;
for (const QString &line : avdDeviceInfo) {
@@ -171,7 +171,7 @@ void AvdDialog::updateDeviceDefinitionComboBox()
m_avdDialog.deviceDefinitionTypeComboBox->currentText());
m_avdDialog.deviceDefinitionComboBox->clear();
- for (auto item : m_deviceDefinitionsList) {
+ for (const DeviceDefinitionStruct &item : m_deviceDefinitionsList) {
if (item.deviceType == curDeviceType)
m_avdDialog.deviceDefinitionComboBox->addItem(item.name_id);
}
diff --git a/src/plugins/clangtools/clangtool.cpp b/src/plugins/clangtools/clangtool.cpp
index bbebc3560f..8fa9ca8250 100644
--- a/src/plugins/clangtools/clangtool.cpp
+++ b/src/plugins/clangtools/clangtool.cpp
@@ -332,7 +332,7 @@ static FileInfos sortedFileInfos(const QVector<CppTools::ProjectPart::Ptr> &proj
{
FileInfos fileInfos;
- for (CppTools::ProjectPart::Ptr projectPart : projectParts) {
+ for (const CppTools::ProjectPart::Ptr projectPart : projectParts) {
QTC_ASSERT(projectPart, continue);
if (!projectPart->selectedForBuilding)
continue;
diff --git a/src/plugins/clangtools/clangtoolsutils.cpp b/src/plugins/clangtools/clangtoolsutils.cpp
index 661a2165d0..c7f7cac423 100644
--- a/src/plugins/clangtools/clangtoolsutils.cpp
+++ b/src/plugins/clangtools/clangtoolsutils.cpp
@@ -124,7 +124,7 @@ QString fullPath(const QString &executable)
static QString findValidExecutable(const QStringList &candidates)
{
- for (QString candidate : candidates) {
+ for (const QString &candidate : candidates) {
const QString expandedPath = fullPath(candidate);
if (isFileExecutable(expandedPath))
return expandedPath;
diff --git a/src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp b/src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp
index 697e0a33c2..36e981636f 100644
--- a/src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp
+++ b/src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp
@@ -297,7 +297,8 @@ int ReadOnlyFilesDialog::exec()
ReadOnlyResult result = RO_Cancel;
FilePaths failedToMakeWritable;
- for (ReadOnlyFilesDialogPrivate::ButtonGroupForFile buttongroup : qAsConst(d->buttonGroups)) {
+ for (const ReadOnlyFilesDialogPrivate::ButtonGroupForFile &buttongroup
+ : qAsConst(d->buttonGroups)) {
result = static_cast<ReadOnlyResult>(buttongroup.group->checkedId());
switch (result) {
case RO_MakeWritable:
diff --git a/src/plugins/cpptools/cppprojectinfogenerator.cpp b/src/plugins/cpptools/cppprojectinfogenerator.cpp
index ab82029d20..b740943a86 100644
--- a/src/plugins/cpptools/cppprojectinfogenerator.cpp
+++ b/src/plugins/cpptools/cppprojectinfogenerator.cpp
@@ -56,7 +56,7 @@ ProjectInfo ProjectInfoGenerator::generate()
if (m_futureInterface.isCanceled())
return ProjectInfo();
- for (ProjectPart::Ptr part : createProjectParts(rpp))
+ for (const ProjectPart::Ptr part : createProjectParts(rpp))
projectInfo.appendProjectPart(part);
}
diff --git a/src/plugins/ctfvisualizer/ctftimelinemodel.cpp b/src/plugins/ctfvisualizer/ctftimelinemodel.cpp
index 827f919055..918b309303 100644
--- a/src/plugins/ctfvisualizer/ctftimelinemodel.cpp
+++ b/src/plugins/ctfvisualizer/ctftimelinemodel.cpp
@@ -353,7 +353,7 @@ void CtfTimelineModel::addCounterValue(const json &event, qint64 normalizedTime,
if (!event.contains("args")) return;
// CTF documentation says all keys of 'args' should be displayed in
// one stacked graph, but we will display them separately:
- for (auto it: event["args"].items()) {
+ for (const auto it : event["args"].items()) {
std::string counterName = event.contains("id") ?
name + event.value("id", "") : name;
const std::string &key = it.key();
diff --git a/src/plugins/debugger/commonoptionspage.cpp b/src/plugins/debugger/commonoptionspage.cpp
index fc0f22e1a4..8bd42ed612 100644
--- a/src/plugins/debugger/commonoptionspage.cpp
+++ b/src/plugins/debugger/commonoptionspage.cpp
@@ -211,7 +211,7 @@ public:
GlobalDebuggerOptions *options = Internal::globalDebuggerOptions();
SourcePathMap allPathMap = options->sourcePathMap;
- for (auto regExpMap : qAsConst(options->sourcePathRegExpMap))
+ for (const auto &regExpMap : qAsConst(options->sourcePathRegExpMap))
allPathMap.insert(regExpMap.first.pattern(), regExpMap.second);
m_sourceMappingWidget->setSourcePathMap(allPathMap);
}
diff --git a/src/plugins/debugger/debuggerengine.cpp b/src/plugins/debugger/debuggerengine.cpp
index 1e0006f5d7..61f1b2f9e3 100644
--- a/src/plugins/debugger/debuggerengine.cpp
+++ b/src/plugins/debugger/debuggerengine.cpp
@@ -2811,7 +2811,7 @@ void CppDebuggerEngine::validateRunParameters(DebuggerRunParameters &rp)
const GlobalDebuggerOptions *options = Internal::globalDebuggerOptions();
SourcePathRegExpMap globalRegExpSourceMap;
globalRegExpSourceMap.reserve(options->sourcePathRegExpMap.size());
- for (auto entry : qAsConst(options->sourcePathRegExpMap)) {
+ for (const auto &entry : qAsConst(options->sourcePathRegExpMap)) {
const QString expanded = Utils::globalMacroExpander()->expand(entry.second);
if (!expanded.isEmpty())
globalRegExpSourceMap.push_back(qMakePair(entry.first, expanded));
diff --git a/src/plugins/git/giteditor.cpp b/src/plugins/git/giteditor.cpp
index 77d07d1258..fc6b74d358 100644
--- a/src/plugins/git/giteditor.cpp
+++ b/src/plugins/git/giteditor.cpp
@@ -214,7 +214,7 @@ void GitEditorWidget::setPlainText(const QString &text)
clear();
QTextCursor cursor = textCursor();
cursor.beginEditBlock();
- for (auto formattedChunk : formattedTextList)
+ for (const auto &formattedChunk : formattedTextList)
cursor.insertText(formattedChunk.text, formattedChunk.format);
cursor.endEditBlock();
diff --git a/src/plugins/help/helpindexfilter.cpp b/src/plugins/help/helpindexfilter.cpp
index 7b51f8812c..d3d78cf0f7 100644
--- a/src/plugins/help/helpindexfilter.cpp
+++ b/src/plugins/help/helpindexfilter.cpp
@@ -223,7 +223,7 @@ void HelpIndexFilter::accept(LocatorFilterEntry selection,
#else
QMultiMap<QString, QUrl> links;
const QList<QHelpLink> docs = LocalHelpManager::helpEngine().documentsForKeyword(key, QString());
- for (const auto doc : docs)
+ for (const auto &doc : docs)
links.insert(doc.title, doc.url);
#endif
emit linksActivated(links, key);
diff --git a/src/plugins/help/helpmanager.cpp b/src/plugins/help/helpmanager.cpp
index 4fff954512..d4c5243e2f 100644
--- a/src/plugins/help/helpmanager.cpp
+++ b/src/plugins/help/helpmanager.cpp
@@ -244,7 +244,7 @@ QMultiMap<QString, QUrl> HelpManager::linksForKeyword(const QString &key)
#else
QMultiMap<QString, QUrl> links;
const QList<QHelpLink> docs = d->m_helpEngine->documentsForKeyword(key, QString());
- for (const auto doc : docs)
+ for (const auto &doc : docs)
links.insert(doc.title, doc.url);
return links;
#endif
@@ -260,7 +260,7 @@ QMultiMap<QString, QUrl> HelpManager::linksForIdentifier(const QString &id)
#else
QMultiMap<QString, QUrl> links;
const QList<QHelpLink> docs = d->m_helpEngine->documentsForIdentifier(id, QString());
- for (const auto doc : docs)
+ for (const auto &doc : docs)
links.insert(doc.title, doc.url);
return links;
#endif
diff --git a/src/plugins/ios/iosbuildconfiguration.cpp b/src/plugins/ios/iosbuildconfiguration.cpp
index 37c19a5d51..602387cfce 100644
--- a/src/plugins/ios/iosbuildconfiguration.cpp
+++ b/src/plugins/ios/iosbuildconfiguration.cpp
@@ -275,7 +275,7 @@ void IosBuildSettingsWidget::populateProvisioningProfiles()
m_signEntityCombo->clear();
const ProvisioningProfiles profiles = IosConfigurations::provisioningProfiles();
if (!profiles.isEmpty()) {
- for (auto profile : profiles) {
+ for (const auto profile : profiles) {
m_signEntityCombo->addItem(profile->displayName());
const int index = m_signEntityCombo->count() - 1;
m_signEntityCombo->setItemData(index, profile->identifier(), IdentifierRole);
diff --git a/src/plugins/python/pythonutils.cpp b/src/plugins/python/pythonutils.cpp
index bae86fb4e1..364b97017c 100644
--- a/src/plugins/python/pythonutils.cpp
+++ b/src/plugins/python/pythonutils.cpp
@@ -118,8 +118,8 @@ FilePath getPylsModulePath(CommandLine pylsCommand)
QRegularExpression::MultilineOption);
const QString &output = response.allOutput();
- for (auto regex : {regexCached, regexNotCached}) {
- QRegularExpressionMatch result = regex.match(output);
+ for (const auto &regex : {regexCached, regexNotCached}) {
+ const QRegularExpressionMatch result = regex.match(output);
if (result.hasMatch()) {
const FilePath &modulePath = FilePath::fromUserInput(result.captured(1));
cache[pylsCommand.executable()] = modulePath;
diff --git a/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp b/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
index cb1f54e41f..e3979bbafb 100644
--- a/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
+++ b/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
@@ -1782,7 +1782,7 @@ void QmakeProFile::applyEvaluate(QmakeEvalResult *evalResult)
[this](const QString &path) {
return !m_wildcardWatcher->watchesDirectory(path);
});
- for (QString path : directoriesToAdd)
+ for (const QString &path : directoriesToAdd)
m_wildcardDirectoryContents.insert(path, QDir(path).entryList());
m_wildcardWatcher->addDirectories(directoriesToAdd,
Utils::FileSystemWatcher::WatchModifiedDate);
@@ -1799,7 +1799,7 @@ void QmakeProFile::applyEvaluate(QmakeEvalResult *evalResult)
return !result->directoriesWithWildcards.contains(path);
});
m_wildcardWatcher->removeDirectories(directoriesToRemove);
- for (QString path : directoriesToRemove)
+ for (const QString &path : directoriesToRemove)
m_wildcardDirectoryContents.remove(path);
}
}
diff --git a/src/plugins/qnx/qnxutils.cpp b/src/plugins/qnx/qnxutils.cpp
index 7dc57201a6..4bf8571495 100644
--- a/src/plugins/qnx/qnxutils.cpp
+++ b/src/plugins/qnx/qnxutils.cpp
@@ -237,7 +237,7 @@ QList<QnxTarget> QnxUtils::findTargets(const Utils::FilePath &basePath)
qWarning() << libc << "has more than one ABI ... processing all";
FilePath path = FilePath::fromString(iterator.filePath());
- for (Abi abi : abis)
+ for (const Abi &abi : abis)
result.append(QnxTarget(path, QnxUtils::convertAbi(abi)));
}
}
diff --git a/src/plugins/qtsupport/baseqtversion.cpp b/src/plugins/qtsupport/baseqtversion.cpp
index e6abb0ad88..28a130a78f 100644
--- a/src/plugins/qtsupport/baseqtversion.cpp
+++ b/src/plugins/qtsupport/baseqtversion.cpp
@@ -2216,7 +2216,7 @@ Abis BaseQtVersion::qtAbisFromLibrary(const FilePaths &coreLibraries)
{
Abis res;
for (const FilePath &library : coreLibraries) {
- for (Abi abi : Abi::abisOfBinary(library)) {
+ for (const Abi &abi : Abi::abisOfBinary(library)) {
Abi tmp = abi;
if (abi.osFlavor() == Abi::UnknownFlavor)
tmp = scanQtBinaryForBuildStringAndRefineAbi(library, abi);
diff --git a/src/plugins/texteditor/textindenter.cpp b/src/plugins/texteditor/textindenter.cpp
index fcb04d5fa6..c23326fa34 100644
--- a/src/plugins/texteditor/textindenter.cpp
+++ b/src/plugins/texteditor/textindenter.cpp
@@ -78,7 +78,7 @@ IndentationForBlock TextIndenter::indentationForBlocks(const QVector<QTextBlock>
int /*cursorPositionInEditor*/)
{
IndentationForBlock ret;
- for (QTextBlock block : blocks)
+ for (const QTextBlock &block : blocks)
ret.insert(block.blockNumber(), indentFor(block, tabSettings));
return ret;
}
diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp
index afaa82590c..57f49dc08c 100644
--- a/src/plugins/valgrind/memchecktool.cpp
+++ b/src/plugins/valgrind/memchecktool.cpp
@@ -1198,7 +1198,7 @@ HeobDialog::HeobDialog(QWidget *parent) :
auto profilesLayout = new QHBoxLayout;
m_profilesCombo = new QComboBox;
- for (auto profile : m_profiles)
+ for (const auto &profile : m_profiles)
m_profilesCombo->addItem(settings->value(profile + "/" + heobProfileNameC).toString());
if (hasSelProfile) {
int selIdx = m_profiles.indexOf(selProfile);
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-03 16:51:26 +0000