aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/plugins/subversion/settingspage.cpp3
-rw-r--r--src/plugins/subversion/settingspage.h2
-rw-r--r--src/plugins/subversion/subversionplugin.cpp4
3 files changed, 4 insertions, 5 deletions
diff --git a/src/plugins/subversion/settingspage.cpp b/src/plugins/subversion/settingspage.cpp
index 9a31ce18100..e714dfcde9a 100644
--- a/src/plugins/subversion/settingspage.cpp
+++ b/src/plugins/subversion/settingspage.cpp
@@ -102,8 +102,7 @@ void SubversionSettingsPageWidget::apply()
m_onApply();
}
-SubversionSettingsPage::SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings, QObject *parent) :
- Core::IOptionsPage(parent)
+SubversionSettingsPage::SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings)
{
setId(VcsBase::Constants::VCS_ID_SUBVERSION);
setDisplayName(SubversionSettingsPageWidget::tr("Subversion"));
diff --git a/src/plugins/subversion/settingspage.h b/src/plugins/subversion/settingspage.h
index d4dad730b1b..9778dfb2c42 100644
--- a/src/plugins/subversion/settingspage.h
+++ b/src/plugins/subversion/settingspage.h
@@ -35,7 +35,7 @@ class SubversionSettings;
class SubversionSettingsPage final : public Core::IOptionsPage
{
public:
- SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings, QObject *parent);
+ SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings);
};
} // namespace Subversion
diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp
index d1577daaf8b..1193cb1e037 100644
--- a/src/plugins/subversion/subversionplugin.cpp
+++ b/src/plugins/subversion/subversionplugin.cpp
@@ -320,6 +320,8 @@ private:
QAction *m_menuAction = nullptr;
bool m_submitActionTriggered = false;
+
+ SubversionSettingsPage m_settingsPage{[this] { configurationChanged(); }, &m_settings};
};
@@ -386,8 +388,6 @@ SubversionPluginPrivate::SubversionPluginPrivate()
using namespace Core::Constants;
Context context(SUBVERSION_CONTEXT);
- new SubversionSettingsPage([this] { configurationChanged(); }, &m_settings, this);
-
new VcsSubmitEditorFactory(&submitParameters,
[]() { return new SubversionSubmitEditor(&submitParameters); }, this);