aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind
diff options
context:
space:
mode:
Diffstat (limited to 'src/plugins/valgrind')
-rw-r--r--src/plugins/valgrind/memchecktool.cpp1
-rw-r--r--src/plugins/valgrind/valgrindengine.cpp1
-rw-r--r--src/plugins/valgrind/valgrindplugin.cpp12
3 files changed, 3 insertions, 11 deletions
diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp
index a69e2eac60..cab6dea44c 100644
--- a/src/plugins/valgrind/memchecktool.cpp
+++ b/src/plugins/valgrind/memchecktool.cpp
@@ -562,6 +562,7 @@ RunWorker *MemcheckTool::createRunWorker(RunControl *runControl)
connect(runTool, &MemcheckToolRunner::internalParserError, this, &MemcheckTool::internalParserError);
connect(runTool, &MemcheckToolRunner::stopped, this, &MemcheckTool::engineFinished);
+ m_stopAction->disconnect();
connect(m_stopAction, &QAction::triggered, runControl, &RunControl::initiateStop);
m_toolBusy = true;
diff --git a/src/plugins/valgrind/valgrindengine.cpp b/src/plugins/valgrind/valgrindengine.cpp
index 3cb1a4245b..13beca1fa0 100644
--- a/src/plugins/valgrind/valgrindengine.cpp
+++ b/src/plugins/valgrind/valgrindengine.cpp
@@ -106,7 +106,6 @@ void ValgrindToolRunner::stop()
{
m_isStopping = true;
m_runner.stop();
- reportStopped(); // FIXME: Restrict to non-running scenarios?
}
QString ValgrindToolRunner::executable() const
diff --git a/src/plugins/valgrind/valgrindplugin.cpp b/src/plugins/valgrind/valgrindplugin.cpp
index 4cb71eab68..4e250b8b19 100644
--- a/src/plugins/valgrind/valgrindplugin.cpp
+++ b/src/plugins/valgrind/valgrindplugin.cpp
@@ -110,15 +110,6 @@ public:
}
};
-class ValgrindRunControlFactory : public IRunControlFactory
-{
-public:
- IRunConfigurationAspect *createRunConfigurationAspect(RunConfiguration *rc) override
- {
- return new ValgrindRunConfigurationAspect(rc);
- }
-};
-
ValgrindPlugin::~ValgrindPlugin()
{
delete theGlobalSettings;
@@ -131,7 +122,8 @@ bool ValgrindPlugin::initialize(const QStringList &, QString *)
theGlobalSettings->readSettings();
addAutoReleasedObject(new ValgrindOptionsPage);
- addAutoReleasedObject(new ValgrindRunControlFactory);
+
+ RunConfiguration::registerAspect<ValgrindRunConfigurationAspect>();
return true;
}