| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
We do not declare any `throws` and this way we can also use QTC_GUARD
Coverity-Id: 1586292
Change-Id: I75efd625e096bf02c1f7a85b9573bd134a9fb020
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
|
|
|
|
|
|
|
| |
Change-Id: Idef5659934c9de47fd879c73a0fe5dfcb890237c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
|
|
|
|
| |
Change-Id: I6ae4d113e0aca434e99d9864188187100c24e47d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The case where links are combined with other formatting was not correctly
implemented.
Fixes: QTCREATORBUG-30774
Change-Id: Ie56a7f4c9a1f8a9b23848cc6fd4b7749bb6cecd7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
|\
| |
| |
| | |
Change-Id: I77d3656aec10063a90095d5299b85304692d8b32
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After the release of Qt Creator 13.0.0, a couple of bug reports and
comments regarding reduced legibility appeared.
They boil down to:
1) Text appears blurry
2) Text is too small
3) Text contrast is too low
This change fixes the blurryness by setting less custom font weights for
non-HighDpi systems in StyleHelper::uiFont().
Bigger texts are used for the "Session" and "Recent Project" delegates.
The text contrast is being increased by making Token_Text_Accent darker
for light themes and brighter for dark themes.
Token_Background_Muted, which is used as background color is made a bit
brighter for light themes.
Fixes: QTCREATORBUG-30579
Fixes: QTCREATORBUG-30637
Fixes: QTCREATORBUG-30650
Change-Id: I8eeb9db6854a19b0de0bcee14b10e2ef66234e06
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
doc/qtcreator/src/overview/creator-only/creator-reference.qdoc
doc/qtcreator/src/qtcreator-toc.qdoc
Change-Id: Ibea5488fda972321c448c64fad7f657e84d62cdb
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was fixed with e9320a812252b05a6367462fea698d35f9585eae and shortly
after broke again with 4d6827dde9248b6b47949b535ae361e8c6b04cfa
Amends 4d6827dde9248b6b47949b535ae361e8c6b04cfa
Fixes: QTCREATORBUG-28676
Change-Id: I4a69b1ea1430613d1aa22620b8f10ebff73d66ab
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closing the tip label indirectly calls ToolTip::hideTipImmediately via
its eventFilter that closes the tool tip on any FocusIn/Out event on the
application. Since m_tip is reset in hideTipImmediately the outer call
crashes when this nullptr gets dereferenced. Avoid this crash by
resetting m_tip before closing the tip label.
Fixes: QTCREATORBUG-30738
Change-Id: Id3e690141be196db8ac6c4dab3d97627c0657140
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
And remove the "GTK_THEME" hack
Even though Qt Creator now looked fine when started with a
light/mixed theme on a dark system theme, we still had to force
a light default palette on the application at startup.
The issue is that when the user switches the system theme
to dark during Qt Creator's runtime, Qt notices that and changes
the default application palette to dark.
Prevent that by setting a detached default palette on the
application on startup, even if we do not intend to apply custom
colors to it.
Task-number: QTCREATORBUG-28497
Change-Id: I7a43f108c2299967a14f382e52b62c31491e673d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|\|
| |
| |
| |
| |
| |
| | |
Conflicts:
src/plugins/languageclient/languageclientutils.cpp
Change-Id: I8d1945f79d93cecee9b22f409bc5f2eefaf6a4cd
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There are situations where e.g. anti virus software leads to saving files
failing. Provide a way to disable atomic save for debugging purposes.
Task-number: QTCREATORBUG-30728
Change-Id: I1f3df009f89f6c27b2e0c9f91869b2a75f5575d8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
doc/qtcreator/src/overview/creator-only/creator-keyboard-shortcuts.qdoc
doc/qtcreator/src/qtquick/qtquick-live-preview-devices.qdoc
doc/qtcreator/src/qtquick/qtquick-profiler.qdoc
src/plugins/qmlprojectmanager/qmlprojectmanager.qbs
src/plugins/remotelinux/linuxdevicetester.cpp
Change-Id: I3683c1799df05209d05413383456b285a2daf96e
|
| |\|
| | |
| | |
| | | |
Change-Id: I1f87297930db420606aab8d7016c290483f262c0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QDS-12102
Change-Id: Id6fbfcfb44d3b8c290f5e5d74addf33ef4d9a5e5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I1f6114244514a2b786a8b0d364a303b925ad7757
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
Change-Id: I28e2e8cacf9a20c8b2f5073f4a492862d814fb99
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: Iee113981ffa49b4f03b7641e7030a2f19f917fc6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I644db7635010da8bc29d87926a64c4e6939d7c83
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Saves some overhead.
Change-Id: I7d46e41f29e66cd01f5a11f16e6f78ff7a4d0aa8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: Id5d6ee448a7f2cf06cda2e2776f3dbbe7c8f66c4
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
|
|\ \ \ \ \
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
doc/qtcreator/src/qtquick/qtquick-live-preview-devices.qdoc
src/plugins/projectexplorer/projectexplorer.cpp
Change-Id: I682b330a278a329fc6294baeff6a28040abd10bc
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Assert that we don't call it recursively. If so, the waitForSignal()
returns false immediately.
Fixes: QTCREATORBUG-30715
Change-Id: I7195b2b1347f67262cc8ae6db5439f5ddd38b5bb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Avoid blocking Qt Creator whenever it gets active or projects change, if
some kind of network mapped path is in the list of recent projects. We
check for existence of recent projects, and that can take a long time in
that case, especially if the target is not connected. We already avoid
checking on explicit IDevices, but that doesn't help for other kinds of
mounted directories.
Maintain an "exists" state for each item and update that
asynchronously, informing all interested parties of changes with the
recentProjectsChanged signal. The state is saved in the settings,
meaning that projects that were not found previously start out hidden,
under the assumption that the existence check is fast for them if they
become available again.
Fixes: QTCREATORBUG-30681
Change-Id: Ic39a88b6b5128c3ae4582a6c66fc16be4b297e56
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
By checking if the system palette's text is lighter than window
background.
Change-Id: I450976546f949331136cb94f4f07d09b3340a432
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We cannot assume that the default palette on the platform
and its theme fits the Qt Creator theme. If the system is dark, but Qt
Creator's theme is light, we need to set the theme palette on the
application.
Some themes already enforce the theme palette unconditionally (design-
light, and the dark themes). We don't want to set the palette
unconditionally for our flat default themes though, because for example
on macOS the light and dark colors that we get from the system are
always good and match the Qt Creator theme (because we tell the system
that our application is light/dark explicitly). Add a new
DerivePaletteFromThemeIfNeeded flag as an alternative to
DerivePaletteFromTheme for this.
Fixes: QTCREATORBUG-18281
Task-number: QTCREATORBUG-23187
Fixes: QTCREATORBUG-26817
Fixes: QTCREATORBUG-28589
Fixes: QTCREATORBUG-30138
Change-Id: Id0042980807fa2efd663b856a45255bb453227fd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
|\| | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I0892d8e54930bb5a65dc51117b8ca7d70ce300a3
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I, rather naively, cherry-picked the FileTime commit in
QAbstractFileEngine in qtbase, fd295f4bf6002b499f1f238efa5a7c8d9c90be39,
to the Qt 6.7 branch (commit 22d1a437cb4431a3e7ca1bf8e3b6ba4290d0a0cf),
so it will be in effect starting from Qt 6.7.1, which breaks the build
if you're using 6.7 HEAD. Thanks to David Faure for pointing this out in
the code review.
Change-Id: Ia94a75814321c5832099174f9a9c1b47a8cee23d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It is always the same as DerivePaletteFromTheme, so just use that in all
cases.
Change-Id: Iac9b91bb7792778601a59f761e015ff292f86da7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: Iac02bdf550ed313fec3a1c113583cd6ef1581d3e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
src/plugins/remotelinux/linuxdevice.cpp
Change-Id: Iad28a1bfa4632922931d351d2fe27757cf21dec3
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Amends 8ef85e481aa3095667be33b5db34d180cd18be07.
Fixes: QTCREATORBUG-30640
Change-Id: If768a0b75aa7ff2bb02d538c446d5bed64e5dc60
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Amends ba3f0bc841a55ed45cb1f8270cdcc1bfbbb6e18b.
Change-Id: Ib405096a51f4c2583e9e3c281bfea8f6eaa44b48
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit 27ce9634814b79cccef09f8ed91ff7b7967a617b)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit ba3f0bc841a55ed45cb1f8270cdcc1bfbbb6e18b)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Setting m_status to BaseIteratorEnd should only be done in hasNext(),
because the latter is always called first, before any other member
function.
Change-Id: Ie55518a850655730fb760226d58c4fb171a7f2e1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit 1ddc71fcda9c3e368c9edc936efb99b0641f145b)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Only call setPath() in hasNext(), the latter is called before any other
member method, and setPath() is guarded by a bool to only run a single
time.
Split some code to a helper function, which will be reused when porting
to new QAFEngine API.
Change-Id: Ibda0ede18593a3a20729b31e03e994ad2de126de
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit ad446d56897549b2cddb7b42ce7cbd6641a3c59b)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It should be what FilePath::specialRootName() returns,
"__qtc_devices__". Looks like nothing used the string retured by next()
so this didn't cause issues before.
Change-Id: Ib9c48d8ea032b1ca7d9ec08003f9d51c5a2ae528
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit 71e6916b37ed2dd269c97197d0a6d5bb43402882)
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I5b9a50802adc3d2cfc48748235a7cd6ee01fa5a4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit 5760654674bb5a864a6b5ce9032ae9ed5df5a9ad)
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The other two parameters, QDir::Filter and nameFilters string list, can
be retrieved from the baseIterator.
Change-Id: Id33a95f3b490e8f5846e9728fc66da0df5195be9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
(cherry picked from commit 2f78fd4358f0126ac25a17ceeff259c7f53db0de)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QSettings can already read QStringLists, no need to manually re-invent
the wheel - and QSettings actually handles whitespace around the
seperating comma correctly. Fixes `Includes=foo.inc, blah.inc`
Change-Id: Id1849ac0cd5f3bcc8aaaa1c574ec2d086ef3e0f3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie7aef2aeb01251edd6825fcd56a73ab65b57cbf5
Reviewed-by: hjk <hjk@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the device can point us to the local equivalent of a file we can
read that one instead.
Change-Id: I002b5babae13677d5814b639ca40a62f23a8b374
Reviewed-by: hjk <hjk@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie25637d6800e1162b713c1db7ef07f87cc2a4041
Reviewed-by: hjk <hjk@qt.io>
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
cmake/QtCreatorIDEBranding.cmake
doc/qtcreator/src/overview/creator-only/creator-keyboard-shortcuts.qdoc
qbs/modules/qtc/qtc.qbs
src/plugins/remotelinux/linuxdevicetester.cpp
Change-Id: I8434e41dcfbb50f6ed032a3e0af1591eb19b79eb
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is no reason to limit the environment modifications to unique
variables. The environment modifications are processed sequentially
from top to bottom and there may modifications that are done on the
same variable (e.g. once a prepend, once an append,..)
Change-Id: I8a187737be1108e537a926239088c6352dc92957
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`NSApplicationActivateIgnoringOtherApps` is deprecated and doesn't have
any effect any more. Switch this to `NSApplicationActivateAllWindows`
which we actually want when running an application, and remove an
unneeded cast.
Change-Id: I75849533e4b172db577d5484ef12c8ee4df20d59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends ba3f0bc841a55ed45cb1f8270cdcc1bfbbb6e18b.
Change-Id: Ib405096a51f4c2583e9e3c281bfea8f6eaa44b48
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
|
|\ \ \
| | |/
| |/|
| | | |
Change-Id: I9d13aa050b1c7fb0954e2b63d13da2922d8f7218
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I3adcadf18eb19344461c5a6a0b6d3aec9045430c
|