aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/enginemanager.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Core/Utils: Migrate further to Utils::Idhjk2020-07-061-2/+2
| | | | | | | | The coreplugin/id.h header is kept for downstream for now. Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66 (cherry picked from commit 430a33dcd9ac80ddb848e41f8f059102857c88aa) Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Add some additional shortcuts for actionsEike Ziller2020-03-171-1/+1
| | | | | | | | | | | | | | | | | Add Cmd+Shift+- for decreasing font size on macOS. Do not add Cmd+= for increasing size, because it conflicts with the existing shortcut for "Replace and Find Next". Sprinkle some Backspace shortcuts in addition to Delete for removing items. There are (laptop) keyboards that either do not have a designated Delete key (requiring Fn+Backspace) or where the Delete key is not conveniently located/sized, and there is no benefit in making the distinction in that case anyhow. Fixes: QTCREATORBUG-706 Fixes: QTCREATORBUG-13733 Change-Id: I06274a9810b82800ec6158a883c95d2a7ae2465e Reviewed-by: David Schulz <david.schulz@qt.io>
* Avoid warning on empty expressionshjk2019-07-231-1/+1
| | | | | | | | For some reason, Q_UNUSED includes already a semicolon, adding one on the user side creates an additional empty statement. Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Use Utils::FileName for Runnable::executablehjk2019-06-211-1/+1
| | | | | Change-Id: I584bc18aa19a4c9886af7b13e95052dfd4350b34 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-281-1/+1
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/4.9'Eike Ziller2019-05-081-1/+7
|\ | | | | | | | | | | | | | | | | | | | | | | Conflicts: doc/src/howto/creator-sidebar-views.qdoc doc/src/howto/creator-ui.qdoc qbs/modules/qtc/qtc.qbs qtcreator.pri src/plugins/autotest/testresultmodel.cpp src/plugins/autotest/testresultmodel.h Change-Id: I24cc585ca7782cb1d9cb0b8b73b46892b41937fd
| * Debugger: Resolve ambiguity of F10 shortcuthjk2019-04-231-1/+7
| | | | | | | | | | | | | | | | | | | | | | The debugger plugin (correctly) starts in a C_DEBUGGER_NOTRUNNING context, but this was not removed on engine selection, i.e. F10 stayed active for "Start and break on main" while the engine activated F10 for "Next", too. Fixes: QTCREATORBUG-22330 Change-Id: Ia0a477c8519dc0d5097e3f41a60a5a9e86124b69 Reviewed-by: David Schulz <david.schulz@qt.io>
* | Merge remote-tracking branch 'origin/4.9'Orgad Shaneh2019-04-071-64/+83
|\| | | | | | | Change-Id: I7d1912cd5c4d824fd40d3454c5f1bb796f2c21d8
| * Debugger: Re-organize dock widget persistinghjk2019-04-051-64/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looks like the mainwindow cannot be convinced to handle multiple sets of dockwidgets. So switch back to a single set containing everything and keep track of non-default visibility in the perspectives, and persist these sets. The following pass: 1. Start Creator with new settings Goto Debug Mode Move Break dock widget to right, switch on Global log widget Leave Creator Start Creator Goto Debug Mode Check: Debugger Selected, Break on right, Global log visible 2. Start Creator with new settings Goto Debug Mode Move Break dock widget to right, switch on Global log widget Switch to QmlProfiler sub-perspective Leave Creator Start Creator Goto Debug Mode Check QmlProfiler selected Switch to Debugger sub-perspective Check: Debugger Selected, Break on right, Global log visible 3. Start Creator with new settings Use any C++ test project Start debugging / stop at main() (F10) Wait for stop Switch to Edit mode Switch back to Debug mode Check: Only "running" debugger dock widget layout present (not the normal + preset at the same time) Quit Qt Creator while this debugger is running Check: Shuts down without crash 4. Use any C++ test project Start debugging Switch to Debugger Preset perspective Start a second debugger Kill either instance Check: Application dies, Debugger Preset perspective gets displayed Switch to perspective of second instance Check: Perspective looks ok (docks visible as before) Task-number: QTCREATORBUG-21083 Task-number: QTCREATORBUG-21669 Task-number: QTCREATORBUG-21668 Task-number: QTCREATORBUG-21813 Task-number: QTCREATORBUG-21851 Task-number: QTCREATORBUG-22110 Task-number: QTCREATORBUG-22169 Task-number: QTCREATORBUG-22189 Change-Id: Ic9eb41ff7699ac0f48a85e68376daa80b2b6847e Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | Fix Qt 5.13 deprecation warning about QFontMetrics::width()Friedemann Kleint2019-02-151-1/+2
|/ | | | | | | | | Replace by QFontMetrics::horizontalAdvance(), fixing: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Change-Id: I9991ffefe6e87e872dc35ba291d562e06b28ca64 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-12-121-0/+12
|\ | | | | | | | | | | | | | | | | Conflicts: qbs/modules/qtc/qtc.qbs qtcreator.pri src/plugins/cpptools/compileroptionsbuilder.cpp Change-Id: I87f47cecbb924064296a002fd9446a0627acad8e
| * Debugger: Fix switching to previous mode on exitAaron Barany2018-12-101-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior was broken with refactoring done in commit 3b5ecac238b87615b44b27375cef0b4f1d4637e4. This has two main components: 1. Perspective::select() needs to call EngineManager::activateDebugMode() in order to save the previous mode. 2. The contents of the previous function DebuggerPluginPrivate::activatePreviousMode() was placed in EngineManager::deactivateDebugMode() and is called in doFinishDebugger(). Task-number: QTCREATORBUG-21415 Change-Id: Ibca188ba740027769c497e25ea695af8e218ea4e Reviewed-by: hjk <hjk@qt.io>
* | Debugger: Use better names for the columns of the perspective viewhjk2018-11-281-1/+2
| | | | | | | | | | | | Change-Id: Ibf4f07c5e184530e9c3cee920dcbff9b66066c31 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-191-12/+6
|\| | | | | | | | | | | | | Conflicts: src/plugins/winrt/winrtdevicefactory.cpp Change-Id: I33b8697e2ebf2bea051d7f1144449e0743ee16a5
| * Debugger: Fix display of location marker when switching perspectiveshjk2018-11-141-11/+3
| | | | | | | | | | | | Fixes: QTCREATORBUG-21362 Change-Id: I9bc1f0931ea902d04ab256774347b63c1fc64262 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
| * Debugger: Do not pretendhjk2018-11-121-1/+3
| | | | | | | | | | | | | | ... the preset perspective had an associated debugger. Change-Id: Icf4f07c5e184530e9c3cee920dcbff9b66066c31 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-091-1/+4
|\| | | | | | | | | | | | | Conflicts: tests/unit/unittest/unittest.pro Change-Id: I4f0ab05f96ee60900a3a35fad4c7331238367593
| * Debugger: Fix conflict of "Start and Break on Main" and "Step Over"Eike Ziller2018-11-071-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | After the very first start of a debugger they were both enabled. Make sure that the state at startup is the same as the state when switching to "Debugger Preset" later, to make sure that the context is correctly updated in EngineManagerPrivate::activateEngineItem after first start of a debugger. Amends 1c17ed6db8efd767cce99c62f71888dbe55cc1f2 Change-Id: Ib330f06c0f89853b61dc99db05ebe42007ffc48b Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-061-11/+13
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggermainwindow.cpp src/plugins/qbsprojectmanager/qbsbuildstep.cpp src/plugins/winrt/winrtdevicefactory.cpp tests/unit/unittest/gtest-creator-printing.cpp tests/unit/unittest/gtest-creator-printing.h tests/unit/unittest/unittest.pro Change-Id: Ie9b80b87a8a4fa81baf72a2daa7919b21371c15e
| * Debugger: Use engine specific contexts for delegating actionsEike Ziller2018-10-251-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some actions that are engine specific are visible globally in the Debug menu, like stopping, interrupting and continuing the debugger, and various step variants. These are registered in the action manager by the debugger plugin. Avoid duplicating the state management of these actions in the debugger plugin, by registering these actions as disabled dummies. The actual actions of the specific debugger run are now registered in the action manager by the debugger engine instance, for a debugger engine instance specific context. The engine manager sets the engine instance specific context when the UI is switched to the specific debugger run. Change-Id: I0a311cec0856365b830460dec2ce33d14a2289c0 Reviewed-by: hjk <hjk@qt.io>
| * Fix missing translation contextsEike Ziller2018-10-251-2/+2
| | | | | | | | | | | | | | Change-Id: I4402157e7991ad0050333a34394b87ff3d6f4a1b Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com> Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-221-0/+5
|\| | | | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggeritem.cpp tests/unit/unittest/unittest.pro Change-Id: Id2e4e9c2bc87b2556d7c2845aea3fe2fa11b630b
| * Debugger: Use actions in different contextshjk2018-10-171-0/+5
| | | | | | | | | | | | | | ... for F10-as-in-Start-and-break-at-main and F10-as-in-step-over. Change-Id: Ie8e9e9be389a09a1485cadeea8b2d035a130920a Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Debugger: Strip QLatin1* where possibleOrgad Shaneh2018-10-131-1/+1
|/ | | | | Change-Id: Idcab23875b5dc2ecf55e3303f417b995e2252720 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Rename snapshothandler.{cpp,h} to enginemanager.{cpp,h}hjk2018-09-281-0/+463
That's what they are nowadays. Change-Id: I1bd6db18f2142ecf488eba51ca739675eac753c7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>