1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
|
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0+ OR GPL-3.0 WITH Qt-GPL-exception-1.0
#include "makefileparse.h"
#include <qtsupport/qtversionmanager.h>
#include <utils/qtcprocess.h>
#include <QDebug>
#include <QDir>
#include <QFileInfo>
#include <QLoggingCategory>
#include <QRegularExpression>
#include <QTextStream>
using namespace ProjectExplorer;
using namespace QtSupport;
using namespace Utils;
namespace QmakeProjectManager {
namespace Internal {
static QString findQMakeLine(const FilePath &makefile, const QString &key)
{
QFile fi(makefile.toString());
if (fi.exists() && fi.open(QFile::ReadOnly)) {
QTextStream ts(&fi);
while (!ts.atEnd()) {
const QString line = ts.readLine();
if (line.startsWith(key))
return line;
}
}
return QString();
}
/// This function trims the "#Command /path/to/qmake" from the line
static QString trimLine(const QString &line)
{
// Actually the first space after #Command: /path/to/qmake
const int firstSpace = line.indexOf(QLatin1Char(' '), 11);
return line.mid(firstSpace).trimmed();
}
void MakeFileParse::parseArgs(const QString &args, const QString &project,
QList<QMakeAssignment> *assignments,
QList<QMakeAssignment> *afterAssignments)
{
const QRegularExpression regExp(QLatin1String("^([^\\s\\+-]*)\\s*(\\+=|=|-=|~=)(.*)$"));
bool after = false;
bool ignoreNext = false;
m_unparsedArguments = args;
ProcessArgs::ArgIterator ait(&m_unparsedArguments);
while (ait.next()) {
if (ignoreNext) {
// Ignoring
ignoreNext = false;
ait.deleteArg();
} else if (ait.value() == project) {
ait.deleteArg();
} else if (ait.value() == QLatin1String("-after")) {
after = true;
ait.deleteArg();
} else if (ait.value().contains(QLatin1Char('='))) {
const QRegularExpressionMatch match = regExp.match(ait.value());
if (match.hasMatch()) {
QMakeAssignment qa;
qa.variable = match.captured(1);
qa.op = match.captured(2);
qa.value = match.captured(3).trimmed();
if (after)
afterAssignments->append(qa);
else
assignments->append(qa);
} else {
qDebug()<<"regexp did not match";
}
ait.deleteArg();
} else if (ait.value() == QLatin1String("-o")) {
ignoreNext = true;
ait.deleteArg();
#if defined(Q_OS_WIN32)
} else if (ait.value() == QLatin1String("-win32")) {
#elif defined(Q_OS_MAC)
} else if (ait.value() == QLatin1String("-macx")) {
#elif defined(Q_OS_QNX6)
} else if (ait.value() == QLatin1String("-qnx6")) {
#else
} else if (ait.value() == QLatin1String("-unix")) {
#endif
ait.deleteArg();
}
}
}
void dumpQMakeAssignments(const QList<QMakeAssignment> &list)
{
for (const QMakeAssignment &qa : list)
qCDebug(MakeFileParse::logging()) << " " << qa.variable << qa.op << qa.value;
}
QList<QMakeAssignment> MakeFileParse::parseAssignments(const QList<QMakeAssignment> &assignments)
{
bool foundSeparateDebugInfo = false;
bool foundForceDebugInfo = false;
QList<QMakeAssignment> filteredAssignments;
for (const QMakeAssignment &qa : assignments) {
if (qa.variable == QLatin1String("CONFIG")) {
const QStringList values = qa.value.split(QLatin1Char(' '));
QStringList newValues;
for (const QString &value : values) {
if (value == QLatin1String("debug")) {
if (qa.op == QLatin1String("+=")) {
m_qmakeBuildConfig.explicitDebug = true;
m_qmakeBuildConfig.explicitRelease = false;
} else {
m_qmakeBuildConfig.explicitDebug = false;
m_qmakeBuildConfig.explicitRelease = true;
}
} else if (value == QLatin1String("release")) {
if (qa.op == QLatin1String("+=")) {
m_qmakeBuildConfig.explicitDebug = false;
m_qmakeBuildConfig.explicitRelease = true;
} else {
m_qmakeBuildConfig.explicitDebug = true;
m_qmakeBuildConfig.explicitRelease = false;
}
} else if (value == QLatin1String("debug_and_release")) {
if (qa.op == QLatin1String("+=")) {
m_qmakeBuildConfig.explicitBuildAll = true;
m_qmakeBuildConfig.explicitNoBuildAll = false;
} else {
m_qmakeBuildConfig.explicitBuildAll = false;
m_qmakeBuildConfig.explicitNoBuildAll = true;
}
} else if (value == QLatin1String("iphonesimulator")) {
if (qa.op == QLatin1String("+="))
m_config.osType = QMakeStepConfig::IphoneSimulator;
else
m_config.osType = QMakeStepConfig::NoOsType;
} else if (value == QLatin1String("iphoneos")) {
if (qa.op == QLatin1String("+="))
m_config.osType = QMakeStepConfig::IphoneOS;
else
m_config.osType = QMakeStepConfig::NoOsType;
} else if (value == QLatin1String("qml_debug")) {
if (qa.op == QLatin1String("+="))
m_config.linkQmlDebuggingQQ2 = TriState::Enabled;
else
m_config.linkQmlDebuggingQQ2 = TriState::Disabled;
} else if (value == QLatin1String("qtquickcompiler")) {
if (qa.op == QLatin1String("+="))
m_config.useQtQuickCompiler = TriState::Enabled;
else
m_config.useQtQuickCompiler = TriState::Disabled;
} else if (value == QLatin1String("force_debug_info")) {
if (qa.op == QLatin1String("+="))
foundForceDebugInfo = true;
else
foundForceDebugInfo = false;
} else if (value == QLatin1String("separate_debug_info")) {
if (qa.op == QLatin1String("+=")) {
foundSeparateDebugInfo = true;
m_config.separateDebugInfo = TriState::Enabled;
} else {
foundSeparateDebugInfo = false;
m_config.separateDebugInfo = TriState::Disabled;
}
} else {
newValues.append(value);
}
}
if (!newValues.isEmpty()) {
QMakeAssignment newQA = qa;
newQA.value = newValues.join(QLatin1Char(' '));
filteredAssignments.append(newQA);
}
} else {
filteredAssignments.append(qa);
}
}
if (foundForceDebugInfo && foundSeparateDebugInfo) {
m_config.separateDebugInfo = TriState::Enabled;
} else if (foundForceDebugInfo) {
// Found only force_debug_info, so readd it
QMakeAssignment newQA;
newQA.variable = QLatin1String("CONFIG");
newQA.op = QLatin1String("+=");
newQA.value = QLatin1String("force_debug_info");
filteredAssignments.append(newQA);
} else if (foundSeparateDebugInfo) {
// Found only separate_debug_info, so readd it
QMakeAssignment newQA;
newQA.variable = QLatin1String("CONFIG");
newQA.op = QLatin1String("+=");
newQA.value = QLatin1String("separate_debug_info");
filteredAssignments.append(newQA);
}
return filteredAssignments;
}
static FilePath findQMakeBinaryFromMakefile(const FilePath &makefile)
{
QFile fi(makefile.toString());
if (fi.exists() && fi.open(QFile::ReadOnly)) {
QTextStream ts(&fi);
const QRegularExpression r1(QLatin1String("^QMAKE\\s*=(.*)$"));
while (!ts.atEnd()) {
QString line = ts.readLine();
const QRegularExpressionMatch match = r1.match(line);
if (match.hasMatch()) {
QFileInfo qmake(match.captured(1).trimmed());
QString qmakePath = qmake.filePath();
if (!QString::fromLatin1(QTC_HOST_EXE_SUFFIX).isEmpty()
&& !qmakePath.endsWith(QLatin1String(QTC_HOST_EXE_SUFFIX))) {
qmakePath.append(QLatin1String(QTC_HOST_EXE_SUFFIX));
}
// Is qmake still installed?
QFileInfo fi(qmakePath);
if (fi.exists())
return FilePath::fromFileInfo(fi);
}
}
}
return FilePath();
}
MakeFileParse::MakeFileParse(const FilePath &makefile, Mode mode) : m_mode(mode)
{
qCDebug(logging()) << "Parsing makefile" << makefile;
if (!makefile.exists()) {
qCDebug(logging()) << "**doesn't exist";
m_state = MakefileMissing;
return;
}
// Qt Version!
m_qmakePath = findQMakeBinaryFromMakefile(makefile);
qCDebug(logging()) << " qmake:" << m_qmakePath;
QString project = findQMakeLine(makefile, QLatin1String("# Project:")).trimmed();
if (project.isEmpty()) {
m_state = CouldNotParse;
qCDebug(logging()) << "**No Project line";
return;
}
project.remove(0, project.indexOf(QLatin1Char(':')) + 1);
project = project.trimmed();
// Src Pro file
m_srcProFile = makefile.parentDir().resolvePath(project);
qCDebug(logging()) << " source .pro file:" << m_srcProFile;
QString command = findQMakeLine(makefile, QLatin1String("# Command:")).trimmed();
if (command.isEmpty()) {
m_state = CouldNotParse;
qCDebug(logging()) << "**No Command line found";
return;
}
command = trimLine(command);
parseCommandLine(command, project);
m_state = Okay;
}
MakeFileParse::MakefileState MakeFileParse::makeFileState() const
{
return m_state;
}
FilePath MakeFileParse::qmakePath() const
{
return m_qmakePath;
}
FilePath MakeFileParse::srcProFile() const
{
return m_srcProFile;
}
QMakeStepConfig MakeFileParse::config() const
{
return m_config;
}
QString MakeFileParse::unparsedArguments() const
{
return m_unparsedArguments;
}
QtVersion::QmakeBuildConfigs MakeFileParse::effectiveBuildConfig(QtVersion::QmakeBuildConfigs defaultBuildConfig) const
{
QtVersion::QmakeBuildConfigs buildConfig = defaultBuildConfig;
if (m_qmakeBuildConfig.explicitDebug)
buildConfig = buildConfig | QtVersion::DebugBuild;
else if (m_qmakeBuildConfig.explicitRelease)
buildConfig = buildConfig & ~QtVersion::DebugBuild;
if (m_qmakeBuildConfig.explicitBuildAll)
buildConfig = buildConfig | QtVersion::BuildAll;
else if (m_qmakeBuildConfig.explicitNoBuildAll)
buildConfig = buildConfig &~ QtVersion::BuildAll;
return buildConfig;
}
const QLoggingCategory &MakeFileParse::logging()
{
static const QLoggingCategory category("qtc.qmakeprojectmanager.import", QtWarningMsg);
return category;
}
void MakeFileParse::parseCommandLine(const QString &command, const QString &project)
{
QList<QMakeAssignment> assignments;
QList<QMakeAssignment> afterAssignments;
// Split up args into assignments and other arguments, writes m_unparsedArguments
parseArgs(command, project, &assignments, &afterAssignments);
qCDebug(logging()) << " Initial assignments:";
dumpQMakeAssignments(assignments);
// Filter out CONFIG arguments we know into m_qmakeBuildConfig and m_config
const QList<QMakeAssignment> filteredAssignments = parseAssignments(assignments);
qCDebug(logging()) << " After parsing";
dumpQMakeAssignments(filteredAssignments);
qCDebug(logging()) << " Explicit Debug" << m_qmakeBuildConfig.explicitDebug;
qCDebug(logging()) << " Explicit Release" << m_qmakeBuildConfig.explicitRelease;
qCDebug(logging()) << " Explicit BuildAll" << m_qmakeBuildConfig.explicitBuildAll;
qCDebug(logging()) << " Explicit NoBuildAll" << m_qmakeBuildConfig.explicitNoBuildAll;
qCDebug(logging()) << " OsType" << m_config.osType;
qCDebug(logging()) << " LinkQmlDebuggingQQ2"
<< (m_config.linkQmlDebuggingQQ2 == TriState::Enabled);
qCDebug(logging()) << " Qt Quick Compiler"
<< (m_config.useQtQuickCompiler == TriState::Enabled);
qCDebug(logging()) << " Separate Debug Info"
<< (m_config.separateDebugInfo == TriState::Enabled);
// Create command line of all unfiltered arguments
const QList<QMakeAssignment> &assignmentsToUse = m_mode == Mode::FilterKnownConfigValues
? filteredAssignments : assignments;
for (const QMakeAssignment &qa : assignmentsToUse)
ProcessArgs::addArg(&m_unparsedArguments, qa.variable + qa.op + qa.value);
if (!afterAssignments.isEmpty()) {
ProcessArgs::addArg(&m_unparsedArguments, QLatin1String("-after"));
for (const QMakeAssignment &qa : std::as_const(afterAssignments))
ProcessArgs::addArg(&m_unparsedArguments, qa.variable + qa.op + qa.value);
}
}
} // Internal
} // QmakeProjectManager
// Unit tests:
#ifdef WITH_TESTS
# include <QTest>
# include "qmakeprojectmanagerplugin.h"
# include "projectexplorer/outputparser_test.h"
using namespace QmakeProjectManager::Internal;
using namespace ProjectExplorer;
void QmakeProjectManagerPlugin::testMakefileParser_data()
{
QTest::addColumn<QString>("command");
QTest::addColumn<QString>("project");
QTest::addColumn<QString>("unparsedArguments");
QTest::addColumn<int>("osType");
QTest::addColumn<bool>("linkQmlDebuggingQQ2");
QTest::addColumn<bool>("useQtQuickCompiler");
QTest::addColumn<bool>("separateDebugInfo");
QTest::addColumn<int>("effectiveBuildConfig");
QTest::newRow("Qt 5.7")
<< QString::fromLatin1("-spec linux-g++ CONFIG+=debug CONFIG+=qml_debug -o Makefile ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra1")
<< QString::fromLatin1("SOMETHING=ELSE -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug -o Makefile ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra2")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE CONFIG+=debug CONFIG+=qml_debug -o Makefile ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra3")
<< QString::fromLatin1("-spec linux-g++ CONFIG+=debug SOMETHING=ELSE CONFIG+=qml_debug -o Makefile ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra4")
<< QString::fromLatin1("-spec linux-g++ CONFIG+=debug CONFIG+=qml_debug SOMETHING=ELSE -o Makefile ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra5")
<< QString::fromLatin1("-spec linux-g++ CONFIG+=debug CONFIG+=qml_debug -o Makefile SOMETHING=ELSE ../untitled7/untitled7.pro")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.7 extra6")
<< QString::fromLatin1("-spec linux-g++ CONFIG+=debug CONFIG+=qml_debug -o Makefile ../untitled7/untitled7.pro SOMETHING=ELSE")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8")
<< QString::fromLatin1("-o Makefile ../untitled7/untitled7.pro -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra1")
<< QString::fromLatin1("SOMETHING=ELSE -o Makefile ../untitled7/untitled7.pro -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra2")
<< QString::fromLatin1("-o Makefile SOMETHING=ELSE ../untitled7/untitled7.pro -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra3")
<< QString::fromLatin1("-o Makefile ../untitled7/untitled7.pro SOMETHING=ELSE -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra4")
<< QString::fromLatin1("-o Makefile ../untitled7/untitled7.pro -spec linux-g++ SOMETHING=ELSE CONFIG+=debug CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra5")
<< QString::fromLatin1("-o Makefile ../untitled7/untitled7.pro -spec linux-g++ CONFIG+=debug SOMETHING=ELSE CONFIG+=qml_debug")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
QTest::newRow("Qt 5.8 extra6")
<< QString::fromLatin1("-o Makefile ../untitled7/untitled7.pro -spec linux-g++ CONFIG+=debug CONFIG+=qml_debug SOMETHING=ELSE")
<< QString::fromLatin1("../untitled7/untitled7.pro")
<< QString::fromLatin1("-spec linux-g++ SOMETHING=ELSE")
<< static_cast<int>(QMakeStepConfig::NoOsType)
<< true << false << false << 2;
}
void QmakeProjectManagerPlugin::testMakefileParser()
{
QFETCH(QString, command);
QFETCH(QString, project);
QFETCH(QString, unparsedArguments);
QFETCH(int, osType);
QFETCH(bool, linkQmlDebuggingQQ2);
QFETCH(bool, useQtQuickCompiler);
QFETCH(bool, separateDebugInfo);
QFETCH(int, effectiveBuildConfig);
MakeFileParse parser("/tmp/something", MakeFileParse::Mode::FilterKnownConfigValues);
parser.parseCommandLine(command, project);
QCOMPARE(ProcessArgs::splitArgs(parser.unparsedArguments()),
ProcessArgs::splitArgs(unparsedArguments));
QCOMPARE(parser.effectiveBuildConfig({}), effectiveBuildConfig);
const QMakeStepConfig qmsc = parser.config();
QCOMPARE(qmsc.osType, static_cast<QMakeStepConfig::OsType>(osType));
QCOMPARE(qmsc.linkQmlDebuggingQQ2 == TriState::Enabled, linkQmlDebuggingQQ2);
QCOMPARE(qmsc.useQtQuickCompiler == TriState::Enabled, useQtQuickCompiler);
QCOMPARE(qmsc.separateDebugInfo == TriState::Enabled, separateDebugInfo);
}
#endif
|
