1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
|
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include "qmakemakestep.h"
#include "qmakebuildconfiguration.h"
#include "qmakenodes.h"
#include "qmakeparser.h"
#include "qmakeproject.h"
#include "qmakeprojectmanagerconstants.h"
#include "qmakeprojectmanagertr.h"
#include "qmakesettings.h"
#include "qmakestep.h"
#include <projectexplorer/target.h>
#include <projectexplorer/toolchain.h>
#include <projectexplorer/buildsteplist.h>
#include <projectexplorer/gnumakeparser.h>
#include <projectexplorer/processparameters.h>
#include <projectexplorer/projectexplorer.h>
#include <projectexplorer/projectexplorerconstants.h>
#include <projectexplorer/kitinformation.h>
#include <projectexplorer/xcodebuildparser.h>
#include <utils/qtcprocess.h>
#include <utils/variablechooser.h>
#include <QDir>
#include <QFileInfo>
using namespace ProjectExplorer;
using namespace Utils;
namespace QmakeProjectManager {
namespace Internal {
class QmakeMakeStep : public MakeStep
{
public:
QmakeMakeStep(BuildStepList *bsl, Id id);
private:
void finish(ProcessResult result) override;
bool init() override;
void setupOutputFormatter(OutputFormatter *formatter) override;
void doRun() override;
QStringList displayArguments() const override;
bool m_scriptTarget = false;
FilePath m_makeFileToCheck;
bool m_unalignedBuildDir;
bool m_ignoredNonTopLevelBuild = false;
};
QmakeMakeStep::QmakeMakeStep(BuildStepList *bsl, Id id)
: MakeStep(bsl, id)
{
if (bsl->id() == ProjectExplorer::Constants::BUILDSTEPS_CLEAN) {
setIgnoreReturnValue(true);
setUserArguments("clean");
}
supportDisablingForSubdirs();
}
bool QmakeMakeStep::init()
{
// Note: This skips the Makestep::init() level.
if (!AbstractProcessStep::init())
return false;
const auto bc = static_cast<QmakeBuildConfiguration *>(buildConfiguration());
const CommandLine unmodifiedMake = effectiveMakeCommand(Execution);
const FilePath makeExecutable = unmodifiedMake.executable();
if (makeExecutable.isEmpty())
emit addTask(makeCommandMissingTask());
if (!bc || makeExecutable.isEmpty()) {
emitFaultyConfigurationMessage();
return false;
}
// Ignore all but the first make step for a non-top-level build. See QTCREATORBUG-15794.
m_ignoredNonTopLevelBuild = (bc->fileNodeBuild() || bc->subNodeBuild()) && !enabledForSubDirs();
ProcessParameters *pp = processParameters();
pp->setMacroExpander(bc->macroExpander());
FilePath workingDirectory;
if (bc->subNodeBuild())
workingDirectory = bc->qmakeBuildSystem()->buildDir(bc->subNodeBuild()->filePath());
else
workingDirectory = bc->buildDirectory();
pp->setWorkingDirectory(workingDirectory);
CommandLine makeCmd(makeExecutable);
QmakeProjectManager::QmakeProFileNode *subProFile = bc->subNodeBuild();
if (subProFile) {
QString makefile = subProFile->makefile();
if (makefile.isEmpty())
makefile = "Makefile";
// Use Makefile.Debug and Makefile.Release
// for file builds, since the rules for that are
// only in those files.
if (subProFile->isDebugAndRelease() && bc->fileNodeBuild()) {
if (buildType() == QmakeBuildConfiguration::Debug)
makefile += ".Debug";
else
makefile += ".Release";
}
if (makefile != "Makefile")
makeCmd.addArgs({"-f", makefile});
m_makeFileToCheck = workingDirectory / makefile;
} else {
FilePath makefile = bc->makefile();
if (!makefile.isEmpty()) {
makeCmd.addArgs({"-f", makefile.path()});
m_makeFileToCheck = workingDirectory / makefile.path();
} else {
m_makeFileToCheck = workingDirectory / "Makefile";
}
}
makeCmd.addArgs(unmodifiedMake.arguments(), CommandLine::Raw);
if (bc->fileNodeBuild() && subProFile) {
QString objectsDir = subProFile->objectsDirectory();
if (objectsDir.isEmpty()) {
objectsDir = bc->qmakeBuildSystem()->buildDir(subProFile->filePath()).toString();
if (subProFile->isDebugAndRelease()) {
if (bc->buildType() == QmakeBuildConfiguration::Debug)
objectsDir += "/debug";
else
objectsDir += "/release";
}
}
if (subProFile->isObjectParallelToSource()) {
const FilePath sourceFileDir = bc->fileNodeBuild()->filePath().parentDir();
const FilePath proFileDir = subProFile->proFile()->sourceDir().canonicalPath();
if (!objectsDir.endsWith('/'))
objectsDir += QLatin1Char('/');
objectsDir += sourceFileDir.relativeChildPath(proFileDir).toString();
objectsDir = QDir::cleanPath(objectsDir);
}
QString relObjectsDir = QDir(pp->workingDirectory().toString())
.relativeFilePath(objectsDir);
if (relObjectsDir == ".")
relObjectsDir.clear();
if (!relObjectsDir.isEmpty())
relObjectsDir += '/';
QString objectFile = relObjectsDir + bc->fileNodeBuild()->filePath().baseName()
+ subProFile->objectExtension();
makeCmd.addArg(objectFile);
}
pp->setEnvironment(makeEnvironment());
pp->setCommandLine(makeCmd);
auto rootNode = dynamic_cast<QmakeProFileNode *>(project()->rootProjectNode());
QTC_ASSERT(rootNode, return false);
m_scriptTarget = rootNode->projectType() == ProjectType::ScriptTemplate;
m_unalignedBuildDir = !bc->isBuildDirAtSafeLocation();
// A user doing "make clean" indicates they want a proper rebuild, so make sure to really
// execute qmake on the next build.
if (stepList()->id() == ProjectExplorer::Constants::BUILDSTEPS_CLEAN) {
const auto qmakeStep = bc->qmakeStep();
if (qmakeStep)
qmakeStep->setForced(true);
}
return true;
}
void QmakeMakeStep::setupOutputFormatter(OutputFormatter *formatter)
{
formatter->addLineParser(new GnuMakeParser());
ToolChain *tc = ToolChainKitAspect::cxxToolChain(kit());
OutputTaskParser *xcodeBuildParser = nullptr;
if (tc && tc->targetAbi().os() == Abi::DarwinOS) {
xcodeBuildParser = new XcodebuildParser;
formatter->addLineParser(xcodeBuildParser);
}
QList<OutputLineParser *> additionalParsers = kit()->createOutputParsers();
// make may cause qmake to be run, add last to make sure it has a low priority.
additionalParsers << new QMakeParser;
if (xcodeBuildParser) {
for (OutputLineParser * const p : std::as_const(additionalParsers))
p->setRedirectionDetector(xcodeBuildParser);
}
formatter->addLineParsers(additionalParsers);
formatter->addSearchDir(processParameters()->effectiveWorkingDirectory());
AbstractProcessStep::setupOutputFormatter(formatter);
}
void QmakeMakeStep::doRun()
{
if (m_scriptTarget || m_ignoredNonTopLevelBuild) {
emit finished(true);
return;
}
if (!m_makeFileToCheck.exists()) {
if (!ignoreReturnValue())
emit addOutput(Tr::tr("Cannot find Makefile. Check your build settings."), BuildStep::OutputFormat::NormalMessage);
const bool success = ignoreReturnValue();
emit finished(success);
return;
}
AbstractProcessStep::doRun();
}
void QmakeMakeStep::finish(ProcessResult result)
{
if (!isSuccess(result) && !isCanceled() && m_unalignedBuildDir
&& QmakeSettings::warnAgainstUnalignedBuildDir()) {
const QString msg = Tr::tr("The build directory is not at the same level as the source "
"directory, which could be the reason for the build failure.");
emit addTask(BuildSystemTask(Task::Warning, msg));
}
MakeStep::finish(result);
}
QStringList QmakeMakeStep::displayArguments() const
{
const auto bc = static_cast<QmakeBuildConfiguration *>(buildConfiguration());
if (bc && !bc->makefile().isEmpty())
return {"-f", bc->makefile().path()};
return {};
}
///
// QmakeMakeStepFactory
///
QmakeMakeStepFactory::QmakeMakeStepFactory()
{
registerStep<QmakeMakeStep>(Constants::MAKESTEP_BS_ID);
setSupportedProjectType(Constants::QMAKEPROJECT_ID);
setDisplayName(MakeStep::defaultDisplayName());
}
} // Internal
} // QmakeProjectManager
|
