1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include <QScopedPointer>
#include <QLatin1String>
#include <QGraphicsObject>
#include <QApplication>
#include <QSettings>
#include <QFileInfo>
#include <qmljs/qmljsinterpreter.h>
#include <qmljs/qmljsdocument.h>
#include <qmljs/qmljsbind.h>
#include <qmljs/qmljslink.h>
#include <qmljs/qmljscheck.h>
#include <qmljs/qmljscontext.h>
#include <qmljs/qmljsmodelmanagerinterface.h>
#include <qmljs/parser/qmljsast_p.h>
#include <qmljs/parser/qmljsengine_p.h>
#include <qmljs/parser/qmljssourcelocation_p.h>
#include <extensionsystem/pluginmanager.h>
#include <QtTest>
#include <algorithm>
using namespace QmlJS;
using namespace QmlJS::AST;
using namespace QmlJS::StaticAnalysis;
class tst_Check : public QObject
{
Q_OBJECT
public:
tst_Check();
private slots:
void test();
void test_data();
void initTestCase();
private:
ModelManagerInterface m_modelManager; // we indirectly need an instance of the modelmanager
};
tst_Check::tst_Check()
{
}
#ifdef Q_OS_MAC
# define SHARE_PATH "/Resources"
#else
# define SHARE_PATH "/share/qtcreator"
#endif
QString resourcePath()
{
return QDir::cleanPath(QTCREATORDIR + QLatin1String(SHARE_PATH));
}
void tst_Check::initTestCase()
{
// the resource path is wrong, have to load things manually
QFileInfo builtins(resourcePath() + "/qml-type-descriptions/builtins.qmltypes");
QStringList errors, warnings;
CppQmlTypesLoader::defaultQtObjects = CppQmlTypesLoader::loadQmlTypes(QFileInfoList() << builtins, &errors, &warnings);
if (!ModelManagerInterface::instance())
new ModelManagerInterface;
if (!ExtensionSystem::PluginManager::instance())
new ExtensionSystem::PluginManager;
ModelManagerInterface *modelManager = ModelManagerInterface::instance();
PathsAndLanguages lPaths;
QStringList paths(QLibraryInfo::location(QLibraryInfo::Qml2ImportsPath));
for (auto p: paths)
lPaths.maybeInsert(Utils::FilePath::fromString(p), Dialect::Qml);
ModelManagerInterface::importScan(ModelManagerInterface::workingCopy(), lPaths,
modelManager, false);
modelManager->test_joinAllThreads();
}
static bool offsetComparator(const Message &lhs, const Message &rhs)
{
return lhs.location.offset < rhs.location.offset;
}
#define QCOMPARE_NOEXIT(actual, expected) \
QTest::qCompare(actual, expected, #actual, #expected, __FILE__, __LINE__)
void tst_Check::test_data()
{
QTest::addColumn<QString>("path");
for (QFileInfo it : QDir(TESTSRCDIR).entryInfoList(QStringList("*.qml"), QDir::Files, QDir::Name)) {
QTest::newRow(it.fileName().toUtf8()) << it.filePath();
}
}
void tst_Check::test()
{
QFETCH(QString, path);
Utils::FilePath pathPath = Utils::FilePath::fromString(path);
auto mm = ModelManagerInterface::instance();
Snapshot snapshot = mm->snapshot();
Document::MutablePtr doc = Document::create(pathPath, Dialect::Qml);
QFile file(doc->fileName().toString());
file.open(QFile::ReadOnly | QFile::Text);
doc->setSource(QString::fromUtf8(file.readAll()));
file.close();
doc->parse();
snapshot.insert(doc);
mm->updateDocument(doc);
QRegularExpression nDiagRe("// *nDiagnosticMessages *= *([0-9]+)");
auto m = nDiagRe.match(doc->source());
int nDiagnosticMessages = 0;
if (m.hasMatch())
nDiagnosticMessages = m.captured(1).toInt();
QVERIFY(!doc->source().isEmpty());
QCOMPARE(doc->diagnosticMessages().size(), nDiagnosticMessages);
ViewerContext vContext;
vContext.flags = ViewerContext::Complete;
ContextPtr context = Link(snapshot, vContext, LibraryInfo())();
Check checker(doc, context);
QList<Message> messages = checker();
std::sort(messages.begin(), messages.end(), &offsetComparator);
/*
* expected message are marked inside the respective qml file on the line of their occurrence
* with a comment stating error number, start column, and end column with optional state to mark
* e.g. false positives
* if more than 1 message at a line is expected these can be specified by adding further
* line comments in the same line
*/
const QRegularExpression messagePattern(" (-?\\d+) (\\d+) (\\d+)\\s*(# false positive|# wrong warning.*)?");
QList<Message> expectedMessages;
QHash<int, QString> xfails;
for (const SourceLocation &comment : doc->engine()->comments()) {
const QString fullComment = doc->source().mid(comment.begin(), comment.end() - comment.begin());
const QStringList splittedComment = fullComment.split("//");
for (const QString &text : splittedComment) {
const QRegularExpressionMatch match = messagePattern.match(text);
if (!match.hasMatch())
continue;
const int type = match.captured(1).toInt();
const int columnStart = match.captured(2).toInt();
const int columnEnd = match.captured(3).toInt() + 1;
Message message;
message.location = SourceLocation(
comment.offset - comment.startColumn + columnStart,
columnEnd - columnStart,
comment.startLine,
columnStart),
message.type = static_cast<QmlJS::StaticAnalysis::Type>(type);
expectedMessages += message;
if (messagePattern.captureCount() == 4 && !match.captured(4).isEmpty())
xfails.insert(expectedMessages.size() - 1, match.captured(4));
}
}
for (int i = 0; i < messages.size(); ++i) {
if (i >= expectedMessages.size())
break;
Message actual = messages.at(i);
Message expected = expectedMessages.at(i);
bool fail = false;
fail |= !QCOMPARE_NOEXIT(actual.location.startLine, expected.location.startLine);
auto xFail = xfails.find(i);
if (xFail != xfails.end())
QEXPECT_FAIL(path.toUtf8(), xFail.value().toUtf8(), Continue);
fail |= !QCOMPARE_NOEXIT((int)actual.type, (int)expected.type);
if (fail)
return;
fail |= !QCOMPARE_NOEXIT(actual.location.startColumn, expected.location.startColumn);
fail |= !QCOMPARE_NOEXIT(actual.location.offset, expected.location.offset);
fail |= !QCOMPARE_NOEXIT(actual.location.length, expected.location.length);
if (fail) {
qDebug() << "Failed for message on line" << actual.location.startLine << actual.message;
return;
}
}
if (expectedMessages.size() > messages.size()) {
for (int i = messages.size(); i < expectedMessages.size(); ++i) {
Message missingMessage = expectedMessages.at(i);
qDebug() << "expected message of type" << missingMessage.type << "on line" << missingMessage.location.startLine;
}
QVERIFY2(false, "more messages expected");
}
if (expectedMessages.size() < messages.size()) {
for (int i = expectedMessages.size(); i < messages.size(); ++i) {
Message extraMessage = messages.at(i);
qDebug() << "unexpected message of type" << extraMessage.type << "on line" << extraMessage.location.startLine
<< extraMessage.message;
}
QFAIL("fewer messages expected");
}
}
QTEST_GUILESS_MAIN(tst_Check);
#include "tst_check.moc"
|
