summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAurélien Brooke <aurelien@bahiasoft.fr>2024-01-12 13:29:23 +0100
committerAurélien Brooke <aurelien@bahiasoft.fr>2024-01-13 09:09:42 +0100
commit4721805c04ef2acdb87f8b339f125b9a2ee7b392 (patch)
tree216ae155bae8dfbf21d46e0a7338e00e6ff37b24
parente1d69a2ca8ebc436fc87e1a5b0231c9a8f4dafd0 (diff)
QEntity: fix a std::move-from-const in destructor
The quadratic fix proposed by commit cbffb898fc3625a04a9569e232c0f6231d4d3505 was actually not doing anything because std::move() was applied to a const variable. Pick-to: 6.6 6.7 Change-Id: Ieff6341493fd026ad45e0c3e26f0cdb4797b4a6a Reviewed-by: Mike Krus <mike.krus@kdab.com>
-rw-r--r--src/core/nodes/qentity.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/nodes/qentity.cpp b/src/core/nodes/qentity.cpp
index f26da3bea..a77ec09ca 100644
--- a/src/core/nodes/qentity.cpp
+++ b/src/core/nodes/qentity.cpp
@@ -139,7 +139,7 @@ QEntity::QEntity(QEntityPrivate &dd, QNode *parent)
QEntity::~QEntity()
{
// remove all component aggregations
- Q_D(const QEntity);
+ Q_D(QEntity);
// to avoid hammering m_components by repeated removeComponent()
// calls below, move all contents out, so the removeOne() calls in
// removeComponent() don't actually remove something: