summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Lemire <paul.lemire@kdab.com>2015-10-01 09:23:24 +0200
committerPaul Lemire <paul.lemire@kdab.com>2015-10-14 16:01:15 +0000
commitd1e3ae82ef34e372c7f7c7e4533d240753df244e (patch)
treef66a965d2965fd4a5c7e020bbf2b876ffffdd452
parent797f5b02691551ce276b335f1409c3378b973e3e (diff)
QSortCriterion fix: do not pass ref for sort type but value
Change-Id: I415a47cea4ff393ca67c3f162415d5a082c66d0a Reviewed-by: Andy Nichols <andy.nichols@theqtcompany.com>
-rw-r--r--src/render/framegraph/qsortcriterion.cpp3
-rw-r--r--src/render/framegraph/qsortcriterion.h2
2 files changed, 2 insertions, 3 deletions
diff --git a/src/render/framegraph/qsortcriterion.cpp b/src/render/framegraph/qsortcriterion.cpp
index f4a5fdf9d..11577631f 100644
--- a/src/render/framegraph/qsortcriterion.cpp
+++ b/src/render/framegraph/qsortcriterion.cpp
@@ -75,11 +75,10 @@ QSortCriterion::SortType QSortCriterion::sort() const
return d->m_sort;
}
-void QSortCriterion::setSort(QSortCriterion::SortType &sort)
+void QSortCriterion::setSort(QSortCriterion::SortType sort)
{
Q_D(QSortCriterion);
if (d->m_sort != sort) {
-
d->m_sort = sort;
emit sortChanged();
}
diff --git a/src/render/framegraph/qsortcriterion.h b/src/render/framegraph/qsortcriterion.h
index 41ec43393..f056a3b94 100644
--- a/src/render/framegraph/qsortcriterion.h
+++ b/src/render/framegraph/qsortcriterion.h
@@ -62,7 +62,7 @@ public:
Q_ENUM(SortType)
SortType sort() const;
- void setSort(SortType &sort);
+ void setSort(SortType sort);
Q_SIGNALS:
void sortChanged();