summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Kudryavtsev <anton.kudryavtsev@vk.team>2023-10-30 18:54:27 +0300
committerAnton Kudryavtsev <anton.kudryavtsev@vk.team>2023-10-30 22:33:15 +0300
commit11a68f13e9699206309a9ec82e7acab0b8a3a40e (patch)
treead6d42c52c37a0208e4f04fb53be04dddd013460
parent0774a9c556c45d96e40e60e7fe4d040ec860cec1 (diff)
qnetworkcookiejar: optimize validateCookie
Use string view more to reduce allocations Change-Id: Ib73fb9607438c7da115406f61653641163370122 Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
-rw-r--r--src/network/access/qnetworkcookiejar.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/network/access/qnetworkcookiejar.cpp b/src/network/access/qnetworkcookiejar.cpp
index 9d5bc64ad5..82746f91b1 100644
--- a/src/network/access/qnetworkcookiejar.cpp
+++ b/src/network/access/qnetworkcookiejar.cpp
@@ -305,13 +305,14 @@ bool QNetworkCookieJar::deleteCookie(const QNetworkCookie &cookie)
*/
bool QNetworkCookieJar::validateCookie(const QNetworkCookie &cookie, const QUrl &url) const
{
- QString domain = cookie.domain();
+ const QString cookieDomain = cookie.domain();
+ QStringView domain = cookieDomain;
const QString host = url.host();
if (!isParentDomain(domain, host) && !isParentDomain(host, domain))
return false; // not accepted
if (domain.startsWith(u'.'))
- domain = domain.mid(1);
+ domain = domain.sliced(1);
// We shouldn't reject if:
// "[...] the domain-attribute is identical to the canonicalized request-host"