summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGiuseppe D'Angelo <giuseppe.dangelo@kdab.com>2013-09-13 12:40:24 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-09-13 13:53:53 +0200
commit173ce3ab93ea1ff40cd68b6fad46f59773a177ca (patch)
tree9b96b5ae3cb743af1eb1ad22868b82fa95b8003c
parent76ef6aac6ad4ef33d648689589a26e73b92897cc (diff)
Fix Strict Weak Ordering in qdoc's comparator
If both n1 and n2 are "Private", the comment says they're equivalent, but the function is actually stating that n1 < n2 AND n2 < n1. Change-Id: I8e30b32c1e5240551ab1808baf6fc476841dfde4 Reviewed-by: Martin Smith <martin.smith@digia.com> Reviewed-by: Topi Reiniƶ <topi.reinio@digia.com>
-rw-r--r--src/tools/qdoc/qdocindexfiles.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/qdoc/qdocindexfiles.cpp b/src/tools/qdoc/qdocindexfiles.cpp
index cb387a9452..21731f921b 100644
--- a/src/tools/qdoc/qdocindexfiles.cpp
+++ b/src/tools/qdoc/qdocindexfiles.cpp
@@ -1135,7 +1135,7 @@ bool compareNodes(const Node* n1, const Node* n2)
// Private nodes can occur in any order since they won't normally be
// written to the index.
if (n1->access() == Node::Private && n2->access() == Node::Private)
- return true;
+ return false;
if (n1->location().filePath() < n2->location().filePath())
return true;