diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2017-06-06 18:55:46 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2017-06-08 09:36:34 +0000 |
| commit | 2db0531a57cf85cf1637c26ff4813f5e8e102902 (patch) | |
| tree | 4f986b8e5cdf2f0bec0daaa32b4fcb387768a050 | |
| parent | f78a189da5d9e13a96a52b9d17cdc80df06ed8c8 (diff) | |
QKeySequence: remove a clause guarding an impossible condition
All code paths leading up to this line unconditionally dereference the pointer,
so it cannot be nullptr.
Remove the check. It only confuses readers of the code and probably will trigger
warnings with tomorrow's compilers.
Change-Id: I31a643738e951da9c04f0091645016276b047761
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
| -rw-r--r-- | src/gui/kernel/qkeysequence.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/gui/kernel/qkeysequence.cpp b/src/gui/kernel/qkeysequence.cpp index 9905caa92a..b15ea78f7a 100644 --- a/src/gui/kernel/qkeysequence.cpp +++ b/src/gui/kernel/qkeysequence.cpp @@ -1100,7 +1100,6 @@ int QKeySequencePrivate::decodeString(const QString &str, QKeySequence::Sequence << QModifKeyName(Qt::KeypadModifier, QLatin1String("num+")); } } - if (!gmodifs) return ret; QVector<QModifKeyName> modifs; |