summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>2021-06-17 07:47:13 +0200
committerEskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>2021-06-18 10:37:17 +0200
commit30f1f02cf74617bb53a4aa997c1e8d05e98e5f5d (patch)
treef047a62af7559a87f306382928c11b92398d91ce
parente9cdcc7cb314586aec76b8b9979435f0af963443 (diff)
codechecker: Add assert for implicit condition
Since memReq is initialized inside the loop, codechecker complained that we might use uninitialized data if count == 0. So we assert that this is not the case to get rid of the warning. Change-Id: I82152942d2bb61723e9e41489c87bfde9f8bec15 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
-rw-r--r--src/gui/vulkan/qvulkanwindow.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/gui/vulkan/qvulkanwindow.cpp b/src/gui/vulkan/qvulkanwindow.cpp
index 32a1d76748..c57f3bf372 100644
--- a/src/gui/vulkan/qvulkanwindow.cpp
+++ b/src/gui/vulkan/qvulkanwindow.cpp
@@ -1330,6 +1330,7 @@ bool QVulkanWindowPrivate::createTransientImage(VkFormat format,
VkMemoryRequirements memReq;
VkResult err;
+ Q_ASSERT(count > 0);
for (int i = 0; i < count; ++i) {
VkImageCreateInfo imgInfo;
memset(&imgInfo, 0, sizeof(imgInfo));