diff options
authorMarc Mutz <>2012-08-20 15:17:54 +0200
committerQt by Nokia <>2012-08-26 14:34:01 +0200
commit4570d0ac2401f3902cff1bd72cac78f599103096 (patch)
parentbd1a7ed26bf845dea56d6e3afb63665630d0b76f (diff)
QSlotObjectBase: remove misleading comment
These constructors might not benefit from being constexpr (as the objects are only created on the heap), so don't suggest so. There's no disadvantage of them begin constexpr, but their constexpr'ability depends on whether QAtomic has a constexpr constructor, and the added complexity of finding that out isn't worth it. Change-Id: I089a29dcb98ba935c339dce09d71f283522a9afd Reviewed-by: Thiago Macieira <> Reviewed-by: Olivier Goffart <>
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/kernel/qobject_impl.h b/src/corelib/kernel/qobject_impl.h
index f5187c803a..3586b1c7f7 100644
--- a/src/corelib/kernel/qobject_impl.h
+++ b/src/corelib/kernel/qobject_impl.h
@@ -116,7 +116,7 @@ namespace QtPrivate {
typedef void (*ImplFn)(int which, QSlotObjectBase* this_, QObject *receiver, void **args, bool *ret);
const ImplFn impl;
- explicit QSlotObjectBase(ImplFn fn) : ref(1), impl(fn) {} // ### make constexpr once QAtomicInt's ctor is, too
+ explicit QSlotObjectBase(ImplFn fn) : ref(1), impl(fn) {}
inline void destroy() { impl(Destroy, this, 0, 0, 0); }
inline bool compare(void **a) { bool ret; impl(Compare, this, 0, a, &ret); return ret; }
inline void call(QObject *r, void **a) { impl(Call, this, r, a, 0); }