summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIikka Eklund <iikka.eklund@qt.io>2021-10-08 12:49:46 +0300
committerIikka Eklund <iikka.eklund@qt.io>2021-10-25 15:47:46 +0300
commit623e396e881f383950b78518a193aff602d8568e (patch)
tree17e797c16216647ef92c2301b8534d73aa06fe5b
parentcbc29dc16c4e08d6e399c7c26a38736bff80d6e6 (diff)
Change package_revision_mode() to recipe_revision_mode()
The package_revision_mode() is too strict for Qt CI. This mode includes artifacts checksum in package_id which is problematic in Qt CI re-runs (re-run flaky build) which contain different build timestamps (cmake) which end up in library files -> different package_id. The effect was that Conan/Conan server is unable to re-use correct binaries and re-builds (re-staged) dependencies. Pick-to: 6.2 6.2.1 Change-Id: Id54af7455b948c8d68b7206d524f1d0fcfb7b568 Reviewed-by: Toni Saario <toni.saario@qt.io>
-rw-r--r--conanfile.py8
1 files changed, 7 insertions, 1 deletions
diff --git a/conanfile.py b/conanfile.py
index 4d2af9047a..e43dd20983 100644
--- a/conanfile.py
+++ b/conanfile.py
@@ -445,7 +445,13 @@ class QtBase(ConanFile):
def package_id(self):
# https://docs.conan.io/en/latest/creating_packages/define_abi_compatibility.html
- self.info.requires.package_revision_mode()
+
+ # The package_revision_mode() is too strict for Qt CI. This mode includes artifacts
+ # checksum in package_id which is problematic in Qt CI re-runs (re-run flaky
+ # build) which contain different build timestamps (cmake) which end up in library
+ # files -> different package_id.
+ self.info.requires.recipe_revision_mode()
+
# Enable 'qt-conan-common' updates on client side with $conan install .. --update
self.info.python_requires.recipe_revision_mode()