diff options
| author | Mate Barany <mate.barany@qt.io> | 2023-01-11 17:55:16 +0100 |
|---|---|---|
| committer | Mate Barany <mate.barany@qt.io> | 2023-01-12 12:24:36 +0100 |
| commit | 696ad54e5d76dd063cbb02d0c288fdece6ee75d0 (patch) | |
| tree | 834754d8ce458dc6113db20a313eabec3fcba938 | |
| parent | 1c62e821bab505730d4f8bb88a3404fb789a5359 (diff) | |
[doc] Warn users about data races regarding qt_ntfs_permission_lookup
qt_ntfs_permission_lookup is a non-atomic global variable that is prone
to data races. Make a remark about this in the documentation.
Task-number: QTBUG-105804
Pick-to: 6.5 6.4 6.2 5.15
Change-Id: If7c64f3ab7d2c3b1487fe56204a4e66c420b0604
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
| -rw-r--r-- | src/corelib/io/qfiledevice.cpp | 5 | ||||
| -rw-r--r-- | src/corelib/io/qfileinfo.cpp | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/src/corelib/io/qfiledevice.cpp b/src/corelib/io/qfiledevice.cpp index ee8e1b8926..6c790e9d0e 100644 --- a/src/corelib/io/qfiledevice.cpp +++ b/src/corelib/io/qfiledevice.cpp @@ -109,6 +109,11 @@ void QFileDevicePrivate::setError(QFileDevice::FileError err, int errNum) decrementing \c qt_ntfs_permission_lookup by 1. \snippet ntfsp.cpp 1 + + \note Since this is a non-atomic global variable, it is only safe + to increment or decrement \c qt_ntfs_permission_lookup before any + threads other than the main thread have started or after every thread + other than the main thread has ended. */ //************* QFileDevice diff --git a/src/corelib/io/qfileinfo.cpp b/src/corelib/io/qfileinfo.cpp index 22127d86a2..a44f72942a 100644 --- a/src/corelib/io/qfileinfo.cpp +++ b/src/corelib/io/qfileinfo.cpp @@ -273,6 +273,11 @@ QDateTime &QFileInfoPrivate::getFileTime(QAbstractFileEngine::FileTime request) \snippet ntfsp.cpp 1 + \note Since this is a non-atomic global variable, it is only safe + to increment or decrement \c qt_ntfs_permission_lookup before any + threads other than the main thread have started or after every thread + other than the main thread has ended. + \section1 Performance Considerations Some of QFileInfo's functions query the file system, but for |