diff options
| author | Alexandru Croitor <alexandru.croitor@qt.io> | 2020-03-13 16:51:45 +0100 |
|---|---|---|
| committer | Alexandru Croitor <alexandru.croitor@qt.io> | 2020-03-13 19:14:55 +0100 |
| commit | 6e286247e83c82114fa7ceebbacac884c29dd456 (patch) | |
| tree | ef030a804475bd2f7b903af37d58ea56611e5746 | |
| parent | 2537d047857db9f686e66c1e464b4742c23756b3 (diff) | |
CMake: Don't make a private module depend 1kk times on the public one
The exported INTERFACE_LINK_LIBRARIES property now looks a lot more
sane.
Change-Id: I093fcb242607023dd0b103298562b299cb803028
Reviewed-by: Leander Beernaert <leander.beernaert@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
| -rw-r--r-- | cmake/QtBuild.cmake | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/cmake/QtBuild.cmake b/cmake/QtBuild.cmake index 2f5215c1bf..c32678a5cf 100644 --- a/cmake/QtBuild.cmake +++ b/cmake/QtBuild.cmake @@ -1219,7 +1219,7 @@ function(qt_extend_target target) set(target_private "${target}Private") if(TARGET "${target_private}") target_link_libraries("${target_private}" - INTERFACE "${target}" ${arg_PRIVATE_MODULE_INTERFACE}) + INTERFACE ${arg_PRIVATE_MODULE_INTERFACE}) endif() qt_register_target_dependencies("${target}" "${arg_PUBLIC_LIBRARIES}" @@ -2054,6 +2054,7 @@ set(QT_CMAKE_EXPORT_NAMESPACE ${QT_CMAKE_EXPORT_NAMESPACE})") if(NOT ${arg_NO_PRIVATE_MODULE}) target_include_directories("${target_private}" INTERFACE ${interface_includes}) + target_link_libraries("${target_private}" INTERFACE "${target}") endif() if(is_framework AND NOT is_interface_lib) |