summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAhmed Kerimov <kerimov.dev@yandex.ru>2023-10-19 02:17:58 +0300
committerAhmed Kerimov <kerimov.dev@yandex.ru>2023-10-27 00:48:26 +0300
commit70df82a919a584a8e691d9aef633fe7a2e3e0d30 (patch)
treeade3d07dcb71672187c3c5b996566e8b2cca24cd
parent23370ace68a3e48ba14e9de7881a6c160cc98619 (diff)
Prefer using override instead of virtual in qdbusxml2cpp
In C++ 11 override keyword was introduced to allow overridden functions to be marked appropriately. Its presence allows compilers to verify that an overridden function correctly overrides a base class implementation. This can be useful as compilers can generate a compile time error when: - The base class implementation function signature changes. - The user has not created the override with the correct signature. This commit improves the D-Bus interface code generation. Change-Id: I0353575c3f70277d04e41b8fa0096c1b2b28058a Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
-rw-r--r--src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
index b2e59eef31..54fd7b2c7c 100644
--- a/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
+++ b/src/tools/qdbusxml2cpp/qdbusxml2cpp.cpp
@@ -950,7 +950,7 @@ void QDBusXmlToCpp::writeAdaptor(const QString &filename,
<< " \"\")\n"
"public:\n"
" " << className << "(" << parent << " *parent);\n"
- " virtual ~" << className << "();\n\n";
+ " ~" << className << "() override;\n\n";
if (!parentClassName.isEmpty())
hs << " inline " << parent << " *parent() const\n"