diff options
author | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2023-10-31 18:35:36 +0100 |
---|---|---|
committer | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2023-11-01 21:58:13 +0100 |
commit | 7b96f3934c0a4331c4ca7bd4521b945f81a8ed21 (patch) | |
tree | 9f0d9f6bb6731d10040e63b09de35388b3bdd50d | |
parent | 1940f0c7be7c78b8773e9576e3740707bae37889 (diff) |
QDockWidget: use pmf-style connect syntax
Use pmf-style connect syntax for the three connections within
QDockWidgetPrivate.
Change-Id: I091a210d6a822903f0cc183f9090e03b124875e6
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
-rw-r--r-- | src/widgets/widgets/qdockwidget.cpp | 17 | ||||
-rw-r--r-- | src/widgets/widgets/qdockwidget.h | 2 | ||||
-rw-r--r-- | src/widgets/widgets/qdockwidget_p.h | 4 |
3 files changed, 11 insertions, 12 deletions
diff --git a/src/widgets/widgets/qdockwidget.cpp b/src/widgets/widgets/qdockwidget.cpp index 8b005c28fb..23d16dd6d7 100644 --- a/src/widgets/widgets/qdockwidget.cpp +++ b/src/widgets/widgets/qdockwidget.cpp @@ -629,12 +629,13 @@ void QDockWidgetPrivate::init() QAbstractButton *button = new QDockWidgetTitleButton(q); button->setObjectName("qt_dockwidget_floatbutton"_L1); - QObject::connect(button, SIGNAL(clicked()), q, SLOT(_q_toggleTopLevel())); + QObjectPrivate::connect(button, &QAbstractButton::clicked, + this, &QDockWidgetPrivate::toggleTopLevel); layout->setWidgetForRole(QDockWidgetLayout::FloatButton, button); button = new QDockWidgetTitleButton(q); button->setObjectName("qt_dockwidget_closebutton"_L1); - QObject::connect(button, SIGNAL(clicked()), q, SLOT(close())); + QObject::connect(button, &QAbstractButton::clicked, q, &QDockWidget::close); layout->setWidgetForRole(QDockWidgetLayout::CloseButton, button); font = QApplication::font("QDockWidgetTitle"); @@ -645,8 +646,8 @@ void QDockWidgetPrivate::init() toggleViewAction->setMenuRole(QAction::NoRole); fixedWindowTitle = qt_setWindowTitle_helperHelper(q->windowTitle(), q); toggleViewAction->setText(fixedWindowTitle); - QObject::connect(toggleViewAction, SIGNAL(triggered(bool)), - q, SLOT(_q_toggleView(bool))); + QObjectPrivate::connect(toggleViewAction, &QAction::triggered, + this, &QDockWidgetPrivate::toggleView); #endif updateButtons(); @@ -681,7 +682,7 @@ void QDockWidget::initStyleOption(QStyleOptionDockWidget *option) const option->verticalTitleBar = l->verticalTitleBar; } -void QDockWidgetPrivate::_q_toggleView(bool b) +void QDockWidgetPrivate::toggleView(bool b) { Q_Q(QDockWidget); if (b == q->isHidden()) { @@ -729,7 +730,7 @@ void QDockWidgetPrivate::updateButtons() layout->invalidate(); } -void QDockWidgetPrivate::_q_toggleTopLevel() +void QDockWidgetPrivate::toggleTopLevel() { Q_Q(QDockWidget); q->setFloating(!q->isFloating()); @@ -961,7 +962,7 @@ bool QDockWidgetPrivate::mouseDoubleClickEvent(QMouseEvent *event) if (event->button() == Qt::LeftButton && titleArea.contains(event->position().toPoint()) && hasFeature(this, QDockWidget::DockWidgetFloatable)) { - _q_toggleTopLevel(); + toggleTopLevel(); return true; } } @@ -1128,7 +1129,7 @@ void QDockWidgetPrivate::nonClientAreaMouseEvent(QMouseEvent *event) #endif break; case QEvent::NonClientAreaMouseButtonDblClick: - _q_toggleTopLevel(); + toggleTopLevel(); break; default: break; diff --git a/src/widgets/widgets/qdockwidget.h b/src/widgets/widgets/qdockwidget.h index f93c3d7431..282f0b0038 100644 --- a/src/widgets/widgets/qdockwidget.h +++ b/src/widgets/widgets/qdockwidget.h @@ -85,8 +85,6 @@ protected: private: Q_DECLARE_PRIVATE(QDockWidget) Q_DISABLE_COPY(QDockWidget) - Q_PRIVATE_SLOT(d_func(), void _q_toggleView(bool)) - Q_PRIVATE_SLOT(d_func(), void _q_toggleTopLevel()) friend class QDockAreaLayout; friend class QDockWidgetItem; friend class QMainWindowLayout; diff --git a/src/widgets/widgets/qdockwidget_p.h b/src/widgets/widgets/qdockwidget_p.h index 326c55cc78..2adf62d03e 100644 --- a/src/widgets/widgets/qdockwidget_p.h +++ b/src/widgets/widgets/qdockwidget_p.h @@ -52,8 +52,8 @@ class QDockWidgetPrivate : public QWidgetPrivate public: void init(); - void _q_toggleView(bool); // private slot - void _q_toggleTopLevel(); // private slot + void toggleView(bool); + void toggleTopLevel(); void updateButtons(); static Qt::DockWidgetArea toDockWidgetArea(QInternal::DockPosition pos); |