diff options
author | Mårten Nordheim <marten.nordheim@qt.io> | 2023-09-25 16:52:02 +0200 |
---|---|---|
committer | Mårten Nordheim <marten.nordheim@qt.io> | 2023-10-17 21:23:41 +0200 |
commit | 8111a7d08f511c6edb0aa1a6fb00e92d6741be25 (patch) | |
tree | dd966ed11ee5fd0003543cc9efc75622b7c7e9d5 | |
parent | 14510bac9acf16b317b41140b3029dcb385d1ea1 (diff) |
QNetworkInfo[NetworkManager]: Fix double-lookup
Change-Id: Ia44993fa229b223cfa40ed6cf922c4d5cfd3042b
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Mate Barany <mate.barany@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
-rw-r--r-- | src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp b/src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp index da540dbecc..baccf98d22 100644 --- a/src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp +++ b/src/plugins/networkinformation/networkmanager/qnetworkmanagerservice.cpp @@ -92,17 +92,17 @@ QNetworkManagerInterface::~QNetworkManagerInterface() QNetworkManagerInterface::NMState QNetworkManagerInterface::state() const { - if (propertyMap.contains(stateKey())) { - return static_cast<QNetworkManagerInterface::NMState>(propertyMap.value(stateKey()) - .toUInt()); - } + auto it = propertyMap.constFind(stateKey()); + if (it != propertyMap.cend()) + return static_cast<QNetworkManagerInterface::NMState>(it->toUInt()); return QNetworkManagerInterface::NM_STATE_UNKNOWN; } QNetworkManagerInterface::NMConnectivityState QNetworkManagerInterface::connectivityState() const { - if (propertyMap.contains(connectivityKey())) - return static_cast<NMConnectivityState>(propertyMap.value(connectivityKey()).toUInt()); + auto it = propertyMap.constFind(connectivityKey()); + if (it != propertyMap.cend()) + return static_cast<NMConnectivityState>(it->toUInt()); return QNetworkManagerInterface::NM_CONNECTIVITY_UNKNOWN; } |