diff options
| author | Alexander Volkov <avolkov@astralinux.ru> | 2019-08-29 23:32:04 +0300 |
|---|---|---|
| committer | Alexander Volkov <avolkov@astralinux.ru> | 2020-07-24 13:10:51 +0300 |
| commit | 865582bd7fd9b7e22c46db01245fc700e5e2bbd7 (patch) | |
| tree | 14b2941a9b5a8795ce63ef3e6d7b5aad2ab01eb6 | |
| parent | 6533d1a47309956e8acda90eb4c41d245e817c93 (diff) | |
Add -Wsuggest-override for gcc >= 9.2
gcc doesn't report warnings for final methods since version 9.2:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010
Change-Id: I7152351aac0e3bad86d777e119f25137ef97ec6f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| -rw-r--r-- | cmake/QtInternalTargets.cmake | 4 | ||||
| -rw-r--r-- | mkspecs/features/qt_common.prf | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/cmake/QtInternalTargets.cmake b/cmake/QtInternalTargets.cmake index 00a4ad6f75..db3257d2f2 100644 --- a/cmake/QtInternalTargets.cmake +++ b/cmake/QtInternalTargets.cmake @@ -176,6 +176,10 @@ if (MSVC) ) endif() +if (GCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "9.2") + target_compile_options(PlatformCommonInternal INTERFACE $<$<COMPILE_LANGUAGE:CXX>:-Wsuggest-override>) +endif() + function(qt_get_implicit_sse2_genex_condition out_var) set(is_shared_lib "$<STREQUAL:$<TARGET_PROPERTY:TYPE>,SHARED_LIBRARY>") set(is_static_lib "$<STREQUAL:$<TARGET_PROPERTY:TYPE>,STATIC_LIBRARY>") diff --git a/mkspecs/features/qt_common.prf b/mkspecs/features/qt_common.prf index 421adcdaa0..b93c1d42a5 100644 --- a/mkspecs/features/qt_common.prf +++ b/mkspecs/features/qt_common.prf @@ -112,6 +112,8 @@ clang { greaterThan(QT_GCC_MAJOR_VERSION, 6): QMAKE_CXXFLAGS_WARN_ON += -Wno-stringop-overflow # GCC 9 introduced -Wformat-overflow in -Wall, but it is buggy: greaterThan(QT_GCC_MAJOR_VERSION, 8): QMAKE_CXXFLAGS_WARN_ON += -Wno-format-overflow + ver = $${QT_GCC_MAJOR_VERSION}.$${QT_GCC_MINOR_VERSION} + versionAtLeast(ver, 9.2): QMAKE_CXXFLAGS_WARN_ON += -Wsuggest-override } warnings_are_errors:warning_clean { |