summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSergey Borovkov <serge.borovkov@gmail.com>2012-10-25 01:20:01 +0400
committerThe Qt Project <gerrit-noreply@qt-project.org>2012-10-26 14:20:21 +0200
commit8c22c9be3e684db90cb97177e97d1ab40866e680 (patch)
tree1c049c498a11a9b1da819b8f74415012ebf6ad06
parent3ab4afb7439953948f38f3a21f049ad9eb3c4332 (diff)
Remove unnecessary call to png_set_sBit when writing png files
According to libpng documentation - PNG files reduce possible bit depths to 1, 2, 4, 8, and 16. If data is of another bit depth, it's possible to write an sBIT chunk into the file so that decoders can recover the original data if desired. Since we hardcode depth to 8 there is no need to call png_set_sBit Change-Id: I8e3941675019b920051775128ff4cf2bf1ca7c4a Reviewed-by: aavit <eirik.aavitsland@digia.com>
-rw-r--r--src/gui/image/qpnghandler.cpp7
1 files changed, 0 insertions, 7 deletions
diff --git a/src/gui/image/qpnghandler.cpp b/src/gui/image/qpnghandler.cpp
index 2307ceb7ae..8434282178 100644
--- a/src/gui/image/qpnghandler.cpp
+++ b/src/gui/image/qpnghandler.cpp
@@ -849,13 +849,6 @@ bool Q_INTERNAL_WIN_NO_THROW QPNGImageWriter::writeImage(const QImage& image, vo
png_set_gAMA(png_ptr, info_ptr, 1.0/gamma);
}
- png_color_8 sig_bit;
- sig_bit.red = 8;
- sig_bit.green = 8;
- sig_bit.blue = 8;
- sig_bit.alpha = image.hasAlphaChannel() ? 8 : 0;
- png_set_sBIT(png_ptr, info_ptr, &sig_bit);
-
if (image.format() == QImage::Format_MonoLSB)
png_set_packswap(png_ptr);