diff options
author | Oswald Buddenhagen <oswald.buddenhagen@nokia.com> | 2011-09-19 20:18:08 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-09-21 12:07:19 +0200 |
commit | 91d2ee5e09a6b48cd1133c727cd02945f29ea994 (patch) | |
tree | cd609b91d9964b76456f56d4bedcc11b4a7e69ed | |
parent | 4f1e2aa27a35965f8ddf394452a48e3aa473d9ed (diff) |
merge translate() overloads
Change-Id: I58f0d2c2ec6da751860a90096c49c662658643c1
Reviewed-on: http://codereview.qt-project.org/5164
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
Reviewed-by: hjk <qthjk@ovi.com>
-rw-r--r-- | src/corelib/kernel/qtranslator.cpp | 25 | ||||
-rw-r--r-- | src/corelib/kernel/qtranslator.h | 5 |
2 files changed, 5 insertions, 25 deletions
diff --git a/src/corelib/kernel/qtranslator.cpp b/src/corelib/kernel/qtranslator.cpp index 1b3e06dd69..6a3a463f6b 100644 --- a/src/corelib/kernel/qtranslator.cpp +++ b/src/corelib/kernel/qtranslator.cpp @@ -907,41 +907,24 @@ void QTranslatorPrivate::clear() } /*! - Returns the translation for the key (\a context, \a sourceText, - \a disambiguation). If none is found, also tries (\a context, \a - sourceText, ""). If that still fails, returns an empty string. - - If you need to programatically insert translations in to a - QTranslator, this function can be reimplemented. - - \sa load() -*/ -QString QTranslator::translate(const char *context, const char *sourceText, const char *disambiguation) const -{ - Q_D(const QTranslator); - return d->do_translate(context, sourceText, disambiguation, -1); -} - - -/*! \overload translate() Returns the translation for the key (\a context, \a sourceText, \a disambiguation). If none is found, also tries (\a context, \a - sourceText, ""). If that still fails, returns an empty string. + sourceText, ""). If that still fails, returns a null string. If \a n is not -1, it is used to choose an appropriate form for the translation (e.g. "%n file found" vs. "%n files found"). + If you need to programatically insert translations into a + QTranslator, this function can be reimplemented. + \sa load() */ QString QTranslator::translate(const char *context, const char *sourceText, const char *disambiguation, int n) const { Q_D(const QTranslator); - // this step is necessary because the 3-parameter translate() overload is virtual - if (n == -1) - return translate(context, sourceText, disambiguation); return d->do_translate(context, sourceText, disambiguation, n); } diff --git a/src/corelib/kernel/qtranslator.h b/src/corelib/kernel/qtranslator.h index 0a9bbde953..43cd63d1da 100644 --- a/src/corelib/kernel/qtranslator.h +++ b/src/corelib/kernel/qtranslator.h @@ -63,11 +63,8 @@ public: explicit QTranslator(QObject *parent = 0); ~QTranslator(); - // ### Qt 5: Merge (with "int n = -1") virtual QString translate(const char *context, const char *sourceText, - const char *disambiguation = 0) const; - QString translate(const char *context, const char *sourceText, const char *disambiguation, - int n) const; + const char *disambiguation = 0, int n = -1) const; virtual bool isEmpty() const; |