diff options
author | Marc Mutz <marc.mutz@qt.io> | 2023-06-30 10:20:55 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2023-07-04 14:53:15 +0000 |
commit | 97adda8675dcc9ca380a43d49b6c59fcea734090 (patch) | |
tree | fdec795d9caa7c6e86394805dae960b0b53f498c | |
parent | 093a0b4f6ee8f31b059ae83e5526d0da037dbd8e (diff) |
QEventLoopLocker: unexport
Non-polymorphic classes should not be exported wholesale. Luckily, in
this case, all SMFs are either out-of-line or (implicitly or
explicitly) deleted, so we don't need to wait for Qt 7 to do the
change.
This is a prerequisite of adding move semantics to the class, as well
as some other optimizations that require non-exported functions.
As a drive-by, collapse ctor declarations into single lines, because a
follow-up patch will need to touch the original lines, anyway, to add
noexcept, so there's no point in keeping separate lines to optimize
the API review diffs.
Task-number: QTBUG-114793
Pick-to: 6.6
Change-Id: Iccfcc11d37aa9274e48345a1e01e0f827e465644
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
-rw-r--r-- | src/corelib/kernel/qeventloop.h | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/src/corelib/kernel/qeventloop.h b/src/corelib/kernel/qeventloop.h index 98ad1451dd..3c444e8fd3 100644 --- a/src/corelib/kernel/qeventloop.h +++ b/src/corelib/kernel/qeventloop.h @@ -53,16 +53,13 @@ Q_DECLARE_OPERATORS_FOR_FLAGS(QEventLoop::ProcessEventsFlags) class QEventLoopLockerPrivate; -class Q_CORE_EXPORT QEventLoopLocker +class QEventLoopLocker { public: - Q_NODISCARD_CTOR - QEventLoopLocker(); - Q_NODISCARD_CTOR - explicit QEventLoopLocker(QEventLoop *loop); - Q_NODISCARD_CTOR - explicit QEventLoopLocker(QThread *thread); - ~QEventLoopLocker(); + Q_NODISCARD_CTOR Q_CORE_EXPORT QEventLoopLocker(); + Q_NODISCARD_CTOR Q_CORE_EXPORT explicit QEventLoopLocker(QEventLoop *loop); + Q_NODISCARD_CTOR Q_CORE_EXPORT explicit QEventLoopLocker(QThread *thread); + Q_CORE_EXPORT ~QEventLoopLocker(); private: Q_DISABLE_COPY(QEventLoopLocker) |