summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJędrzej Nowacki <jedrzej.nowacki@qt.io>2018-10-05 09:27:38 +0200
committerFrederik Gladhorn <frederik.gladhorn@qt.io>2018-10-31 08:38:50 +0000
commitc4a93281a75b50c1b8c9a5fe0007bd44509100e2 (patch)
tree20745ae02c3402173dd4cb14ba66164c76c40e7c
parent102a919b734440df85617f1e3a8ba43c612839d5 (diff)
Add change log about source incompatibility in moc output
"Use std::addressof for taking an address instead of operator& in moc" (5b99f3a34fef527beb8767eb12657f81ee65b969) introduced a dependency to std memory header. That change exposed code that was including the moc output from within a namespace. That was never supported nor valid, but it used to compile. The problem was not detected earlier because both other includes where already included to support QObject itself and therefore inside the moc output their header guards were disabling their content. Task-number: QTBUG-68191 Task-number: QTBUG-70907 Change-Id: I18462ed17d748a114fe2e5b6bf9aeb56ee26e2db Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
-rw-r--r--dist/changes-5.13.07
1 files changed, 7 insertions, 0 deletions
diff --git a/dist/changes-5.13.0 b/dist/changes-5.13.0
new file mode 100644
index 0000000000..c6db991931
--- /dev/null
+++ b/dist/changes-5.13.0
@@ -0,0 +1,7 @@
+****************************************************************************
+* Important Source Incompatible Changes *
+****************************************************************************
+
+ - Moc generated files include the standard <memory> header file now.
+ A side effect of this is that code including the Moc output from within
+ a namespace will fail to compile.