diff options
author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-11-29 12:53:30 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2011-11-29 05:16:52 +0100 |
commit | c5b55d44032203612f98f89858a2198b4c6606ec (patch) | |
tree | f2dc003fc0092ab3d6f57fcda93b8b9a2c7b87a1 | |
parent | e881f4f5fdedf724ce2a5cd9fe2d448c4f8dbaa3 (diff) |
Cleanup corelib autotests
Don't name test functions using task identifiers from obsolete bug
trackers.
Change-Id: Iba6ae8ad3b39e365c5510ed5c86749a167572829
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
8 files changed, 33 insertions, 33 deletions
diff --git a/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp b/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp index 01fb35c74c..eef504b90d 100644 --- a/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp +++ b/tests/auto/corelib/io/qdiriterator/tst_qdiriterator.cpp @@ -115,7 +115,7 @@ private slots: void absoluteFilePathsFromRelativeIteratorPath(); void recurseWithFilters() const; void longPath(); - void task185502_dirorder(); + void dirorder(); void relativePaths(); #if defined(Q_OS_WIN) && !defined(Q_OS_WINCE) void uncPaths_data(); @@ -550,7 +550,7 @@ void tst_QDirIterator::longPath() dir.rmdir("longpaths"); } -void tst_QDirIterator::task185502_dirorder() +void tst_QDirIterator::dirorder() { QDirIterator iterator("foo", QDirIterator::Subdirectories); while (iterator.hasNext() && iterator.next() != "foo/bar") diff --git a/tests/auto/corelib/io/qfile/tst_qfile.cpp b/tests/auto/corelib/io/qfile/tst_qfile.cpp index 6f295f105b..31ddd6298b 100644 --- a/tests/auto/corelib/io/qfile/tst_qfile.cpp +++ b/tests/auto/corelib/io/qfile/tst_qfile.cpp @@ -213,8 +213,7 @@ private slots: void autocloseHandle(); - // --- Task related tests below this line - void task167217(); + void posAfterFailedStat(); void openDirectory(); void writeNothing(); @@ -2724,10 +2723,10 @@ void tst_QFile::readEof() } } -void tst_QFile::task167217() +void tst_QFile::posAfterFailedStat() { - // Regression introduced in 4.3.0; after a failed stat, pos() could no - // longer be calculated correctly. + // Regression test for a bug introduced in 4.3.0; after a failed stat, + // pos() could no longer be calculated correctly. QFile::remove("tmp.txt"); QFile file("tmp.txt"); QVERIFY(!file.exists()); diff --git a/tests/auto/corelib/io/qtextstream/tst_qtextstream.cpp b/tests/auto/corelib/io/qtextstream/tst_qtextstream.cpp index c8bc826608..b3a30d75e9 100644 --- a/tests/auto/corelib/io/qtextstream/tst_qtextstream.cpp +++ b/tests/auto/corelib/io/qtextstream/tst_qtextstream.cpp @@ -230,9 +230,9 @@ private slots: void generateBOM(); void readBomSeekBackReadBomAgain(); - // task-specific tests - void task180679_alignAccountingStyle(); - void task178772_setCodec(); + // Regression tests for old bugs + void alignAccountingStyle(); + void setCodec(); private: void generateLineData(bool for_QString); @@ -2682,7 +2682,7 @@ void tst_QTextStream::status_write_error() QCOMPARE(fb.data(), QByteArray("hello")); } -void tst_QTextStream::task180679_alignAccountingStyle() +void tst_QTextStream::alignAccountingStyle() { { QString result; @@ -2725,7 +2725,7 @@ void tst_QTextStream::task180679_alignAccountingStyle() } } -void tst_QTextStream::task178772_setCodec() +void tst_QTextStream::setCodec() { QByteArray ba("\xe5 v\xe6r\n\xc3\xa5 v\xc3\xa6r\n"); QString res = QLatin1String("\xe5 v\xe6r"); diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp index 1585f60a43..7fc2b3e330 100644 --- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp +++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp @@ -242,7 +242,7 @@ private slots: void loadUnknownUserType(); void loadBrokenUserType(); - void task172061_invalidDate() const; + void invalidDate() const; void compareCustomTypes() const; void timeToDateTime() const; void copyingUserTypes() const; @@ -252,7 +252,7 @@ private slots: void convertByteArrayToBool_data() const; void toIntFromQString() const; void toIntFromDouble() const; - void task256984_setValue(); + void setValue(); void numericalConvert(); void moreCustomTypes(); @@ -2677,7 +2677,7 @@ void tst_QVariant::loadBrokenUserType() QCOMPARE(ds.status(), QDataStream::ReadPastEnd); } -void tst_QVariant::task172061_invalidDate() const +void tst_QVariant::invalidDate() const { QString foo("Hello"); QVariant variant(foo); @@ -2889,7 +2889,7 @@ void tst_QVariant::toIntFromDouble() const QCOMPARE(result, 2147483630); } -void tst_QVariant::task256984_setValue() +void tst_QVariant::setValue() { QTransform t; //we just take a value so that we're sure that it will be shared QVariant v1 = t; diff --git a/tests/auto/corelib/statemachine/qstatemachine/tst_qstatemachine.cpp b/tests/auto/corelib/statemachine/qstatemachine/tst_qstatemachine.cpp index e0f2797571..ca31b183ab 100644 --- a/tests/auto/corelib/statemachine/qstatemachine/tst_qstatemachine.cpp +++ b/tests/auto/corelib/statemachine/qstatemachine/tst_qstatemachine.cpp @@ -171,7 +171,7 @@ private slots: void goToState(); void goToStateFromSourceWithTransition(); - void task260403_clonedSignals(); + void clonedSignals(); void postEventFromOtherThread(); void eventFilterForApplication(); void eventClassesExported(); @@ -3646,7 +3646,7 @@ public: int eventSignalIndex; }; -void tst_QStateMachine::task260403_clonedSignals() +void tst_QStateMachine::clonedSignals() { SignalEmitter emitter; QStateMachine machine; diff --git a/tests/auto/corelib/tools/qbytearraymatcher/tst_qbytearraymatcher.cpp b/tests/auto/corelib/tools/qbytearraymatcher/tst_qbytearraymatcher.cpp index 09a3dfdf7d..cb153b4f8b 100644 --- a/tests/auto/corelib/tools/qbytearraymatcher/tst_qbytearraymatcher.cpp +++ b/tests/auto/corelib/tools/qbytearraymatcher/tst_qbytearraymatcher.cpp @@ -55,7 +55,7 @@ class tst_QByteArrayMatcher : public QObject private slots: void interface(); - void task251958(); + void indexIn(); }; static QByteArrayMatcher matcher1; @@ -106,7 +106,7 @@ void tst_QByteArrayMatcher::interface() static QByteArrayMatcher matcher; -void tst_QByteArrayMatcher::task251958() +void tst_QByteArrayMatcher::indexIn() { const char p_data[] = { 0x0, 0x0, 0x1 }; QByteArray pattern(p_data, sizeof(p_data)); diff --git a/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp b/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp index 90a8927631..b536b88fa3 100644 --- a/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp +++ b/tests/auto/corelib/tools/qdatetime/tst_qdatetime.cpp @@ -75,7 +75,7 @@ private slots: void timeSpec(); void toTime_t_data(); void toTime_t(); - void task_137698(); + void daylightSavingsTimeChange(); void setDate(); void setTime(); void setTimeSpec(); @@ -1131,15 +1131,16 @@ void tst_QDateTime::toTime_t() } } -void tst_QDateTime::task_137698() +void tst_QDateTime::daylightSavingsTimeChange() { - // This bug is caused by QDateTime knowing more than it lets show - // Internally, if it knows, QDateTime stores a flag indicating if the time is - // DST or not. If it doesn't, it sets to "LocalUnknown" + // This is a regression test for an old bug where starting with a date in + // DST and then moving to a date outside it (or vice-versa) caused 1-hour + // jumps in time when addSecs() was called. // - // The problem happens if you start with a date in DST and then move to a date - // outside it (or vice-versa). Some functions did not reset the flag, which caused - // weird 1-hour jumps in time when addSecs() was called. + // The bug was caused by QDateTime knowing more than it lets show. + // Internally, if it knows, QDateTime stores a flag indicating if the time is + // DST or not. If it doesn't, it sets to "LocalUnknown". The problem happened + // because some functions did not reset the flag when moving in or out of DST. // WARNING: This test only works if there's a Daylight Savings Time change // in the current locale between 2006-11-06 and 2006-10-16 diff --git a/tests/auto/corelib/tools/qvarlengtharray/tst_qvarlengtharray.cpp b/tests/auto/corelib/tools/qvarlengtharray/tst_qvarlengtharray.cpp index c36f293745..a005d5df7a 100644 --- a/tests/auto/corelib/tools/qvarlengtharray/tst_qvarlengtharray.cpp +++ b/tests/auto/corelib/tools/qvarlengtharray/tst_qvarlengtharray.cpp @@ -55,7 +55,7 @@ private slots: void append(); void removeLast(); void oldTests(); - void task214223(); + void appendCausingRealloc(); void resize(); void realloc(); }; @@ -248,11 +248,11 @@ void tst_QVarLengthArray::oldTests() } } -void tst_QVarLengthArray::task214223() +void tst_QVarLengthArray::appendCausingRealloc() { - //creating a QVarLengthArray of the same size as the prealloc size - // will make the next call to append(const T&) corrupt the memory - // you should get a segfault pretty soon after that :-) + // This is a regression test for an old bug where creating a + // QVarLengthArray of the same size as the prealloc size would make + // the next call to append(const T&) corrupt the memory. QVarLengthArray<float, 1> d(1); for (int i=0; i<30; i++) d.append(i); |