diff options
author | Ivan Solovev <ivan.solovev@qt.io> | 2024-02-05 14:33:49 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2024-02-12 20:09:18 +0000 |
commit | c5d0345c3d6177105c2a6cbb2f99ab6c64d333a8 (patch) | |
tree | 01aedcb6bc4548ca367dd7beb83d3316877bba00 | |
parent | b099988f6dfd7c58d36c3625d91fe3314f456fd1 (diff) |
QVulkanWindow::setEnabledFeatures2Modifier(): pass parameter by value
The method takes an std::function as a parameter, so it makes sense to
pass it by value to avoid copying when passing lambdas.
Amends bd78047df34fda3a56b8db069fc97280831ac696
Found in 6.7 API review
Pick-to: 6.7
Change-Id: Ic0608a176bfd26b5b44fae48f29d84737e81a413
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
-rw-r--r-- | src/gui/vulkan/qvulkanwindow.cpp | 4 | ||||
-rw-r--r-- | src/gui/vulkan/qvulkanwindow.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/gui/vulkan/qvulkanwindow.cpp b/src/gui/vulkan/qvulkanwindow.cpp index a2d3e49880..e564fb7148 100644 --- a/src/gui/vulkan/qvulkanwindow.cpp +++ b/src/gui/vulkan/qvulkanwindow.cpp @@ -1691,10 +1691,10 @@ void QVulkanWindow::setEnabledFeaturesModifier(const EnabledFeaturesModifier &mo \since 6.7 \sa EnabledFeatures2Modifier */ -void QVulkanWindow::setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier) +void QVulkanWindow::setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier) { Q_D(QVulkanWindow); - d->enabledFeatures2Modifier = modifier; + d->enabledFeatures2Modifier = std::move(modifier); } /*! diff --git a/src/gui/vulkan/qvulkanwindow.h b/src/gui/vulkan/qvulkanwindow.h index d7933911c0..5b69560456 100644 --- a/src/gui/vulkan/qvulkanwindow.h +++ b/src/gui/vulkan/qvulkanwindow.h @@ -89,7 +89,7 @@ public: void setEnabledFeaturesModifier(const EnabledFeaturesModifier &modifier); typedef std::function<void(VkPhysicalDeviceFeatures2 &)> EnabledFeatures2Modifier; - void setEnabledFeatures2Modifier(const EnabledFeatures2Modifier &modifier); + void setEnabledFeatures2Modifier(EnabledFeatures2Modifier modifier); void setPreferredColorFormats(const QList<VkFormat> &formats); |