diff options
| author | Axel Spoerl <axel.spoerl@qt.io> | 2024-01-09 14:40:11 +0100 |
|---|---|---|
| committer | Axel Spoerl <axel.spoerl@qt.io> | 2024-01-10 08:30:12 +0100 |
| commit | ca2f46c04c26ed4649cb6c2c62d3b2e52cd8d5ad (patch) | |
| tree | 2be33c394908e11019eba40a701d240ce01a6848 | |
| parent | 3c6320c41869e60a44da85d3d11e18e9914c9ca3 (diff) | |
API Review / QDockWidget: Remove const/ref debug operator
Remove the debug operator taking a const QDockWidget & argument.
Leaving the override taking a pointer.
This amends bbeff2a3350dd3396400865525d509b784c2d93e.
Change-Id: I0fbca6ea7dbffe6269c70e5e9eb29af9f84c3600
Found-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Task-number: QTBUG-119952
Pick-to: 6.7 6.6
Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
| -rw-r--r-- | src/widgets/widgets/qdockwidget.cpp | 19 | ||||
| -rw-r--r-- | src/widgets/widgets/qdockwidget.h | 1 |
2 files changed, 9 insertions, 11 deletions
diff --git a/src/widgets/widgets/qdockwidget.cpp b/src/widgets/widgets/qdockwidget.cpp index 2699d43d7e..69679291cb 100644 --- a/src/widgets/widgets/qdockwidget.cpp +++ b/src/widgets/widgets/qdockwidget.cpp @@ -1828,17 +1828,16 @@ QDebug operator<<(QDebug dbg, const QDockWidget *dockWidget) { QDebugStateSaver saver(dbg); dbg.nospace(); - return dockWidget ? dbg << *dockWidget : dbg << "QDockWidget(0x0)"; -} -QDebug operator<<(QDebug dbg, const QDockWidget &dockWidget) -{ - QDebugStateSaver saver(dbg); - dbg.nospace(); - dbg << "QDockWidget(" << static_cast<const void *>(&dockWidget); - dbg << "->(ObjectName=" << dockWidget.objectName(); - dbg << "; floating=" << dockWidget.isFloating(); - dbg << "; features=" << dockWidget.features(); + if (!dockWidget) { + dbg << "QDockWidget(0x0)"; + return dbg; + } + + dbg << "QDockWidget(" << static_cast<const void *>(dockWidget); + dbg << "->(ObjectName=" << dockWidget->objectName(); + dbg << "; floating=" << dockWidget->isFloating(); + dbg << "; features=" << dockWidget->features(); dbg << ";))"; return dbg; } diff --git a/src/widgets/widgets/qdockwidget.h b/src/widgets/widgets/qdockwidget.h index d037d88fb6..6aa9ea55f7 100644 --- a/src/widgets/widgets/qdockwidget.h +++ b/src/widgets/widgets/qdockwidget.h @@ -65,7 +65,6 @@ public: { return (allowedAreas() & area) == area; } #ifndef QT_NO_DEBUG_STREAM - friend Q_WIDGETS_EXPORT QDebug operator<<(QDebug dbg, const QDockWidget &dockWidget); friend Q_WIDGETS_EXPORT QDebug operator<<(QDebug dbg, const QDockWidget *dockWidget); #endif |