summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2024-04-12 13:55:32 -0700
committerThiago Macieira <thiago.macieira@intel.com>2024-04-15 23:50:51 -0700
commitd204ea98730baeeb55d2da229f2ce743df8c583e (patch)
treebba39645c445d239ea0bf19f1f4e4bf6933f476a
parent359df32300f5472f2fddbc83c3fe0851b5547ff6 (diff)
tst_QVariant: fix copy & paste error in double-float comparisons
We wanted to test the (min,max) of each of the two types, but one of the four combinations wasn't correctly done. Task-number: QTBUG-124349 Pick-to: 6.7 Change-Id: Ie28eadac333c4bcd8c08fffd17c5a3ccb4205139 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
-rw-r--r--tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
index 75907ec062..da9450fad9 100644
--- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
+++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp
@@ -3170,7 +3170,7 @@ QT_WARNING_POP
addComparePair(qQNaN(), std::numeric_limits<float>::quiet_NaN());
if (sizeof(qreal) == sizeof(double)) {
addComparePair(std::numeric_limits<float>::min(), std::numeric_limits<double>::min());
- addComparePair(std::numeric_limits<float>::min(), std::numeric_limits<double>::min());
+ addComparePair(std::numeric_limits<float>::min(), std::numeric_limits<double>::max());
addComparePair(std::numeric_limits<float>::max(), std::numeric_limits<double>::min());
addComparePair(std::numeric_limits<float>::max(), std::numeric_limits<double>::max());
addComparePair(double(Q_INT64_C(1) << 53), Q_INT64_C(1) << 53);