summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMårten Nordheim <marten.nordheim@qt.io>2021-01-26 12:43:44 +0100
committerMårten Nordheim <marten.nordheim@qt.io>2021-01-27 17:03:37 +0100
commited05ef77587580bb291c7c1bebeb188fc9a3d883 (patch)
tree66120cd02b98edb2bf0bd6720d0a67cb05612ff9
parent7687e2a4295fedd844c46f921b78f21102d26685 (diff)
Fix static analysis warnings concerning QNetworkInformation
By marking undeclared and unused copy/move constructors as deleted. Change-Id: Ie74b9cb015090dbb425b701a55eadb9d80ab0285 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
-rw-r--r--src/network/kernel/qnetworkinformation.h2
-rw-r--r--src/network/kernel/qnetworkinformation_p.h5
2 files changed, 7 insertions, 0 deletions
diff --git a/src/network/kernel/qnetworkinformation.h b/src/network/kernel/qnetworkinformation.h
index 6321300f40..eddabc9707 100644
--- a/src/network/kernel/qnetworkinformation.h
+++ b/src/network/kernel/qnetworkinformation.h
@@ -89,6 +89,8 @@ Q_SIGNALS:
private:
friend class QNetworkInformationPrivate;
QNetworkInformation(QNetworkInformationBackend *backend);
+
+ Q_DISABLE_COPY_MOVE(QNetworkInformation)
};
QT_END_NAMESPACE
diff --git a/src/network/kernel/qnetworkinformation_p.h b/src/network/kernel/qnetworkinformation_p.h
index fc783fa079..389310cc43 100644
--- a/src/network/kernel/qnetworkinformation_p.h
+++ b/src/network/kernel/qnetworkinformation_p.h
@@ -63,6 +63,7 @@ class Q_NETWORK_EXPORT QNetworkInformationBackend : public QObject
{
Q_OBJECT
public:
+ QNetworkInformationBackend() = default;
virtual ~QNetworkInformationBackend();
virtual QString name() const = 0;
@@ -83,6 +84,7 @@ protected:
private:
QNetworkInformation::Reachability m_reachability = QNetworkInformation::Reachability::Unknown;
+ Q_DISABLE_COPY_MOVE(QNetworkInformationBackend)
friend class QNetworkInformation;
friend class QNetworkInformationPrivate;
};
@@ -96,6 +98,9 @@ public:
virtual QString name() const = 0;
virtual QNetworkInformationBackend *create(QNetworkInformation::Features requiredFeatures) const = 0;
virtual QNetworkInformation::Features featuresSupported() const = 0;
+
+private:
+ Q_DISABLE_COPY_MOVE(QNetworkInformationBackendFactory)
};
#define QNetworkInformationBackendFactory_iid "org.qt-project.Qt.NetworkInformationBackendFactory"
Q_DECLARE_INTERFACE(QNetworkInformationBackendFactory, QNetworkInformationBackendFactory_iid);