summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2019-02-28 10:00:39 -0800
committerThiago Macieira <thiago.macieira@intel.com>2019-03-05 17:59:02 +0000
commitf5cbd61f923023f6f61527546060cef0e8fa2c65 (patch)
tree2626ac0cf4ceb1c406ba73d7e7c7d2953ec9ad70
parent1bd3c17c46eb444a7079f3bd6fa5af5950355212 (diff)
XDG Portal: quick optimization to avoid dup/close of a file descriptor
Just gift it to QDBusUnixFileDescriptor. Change-Id: Ifa822ecdaaa241968ed7fffd158799041653cf78 Reviewed-by: Jan Grulich <jgrulich@redhat.com> Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io>
-rw-r--r--src/platformsupport/services/genericunix/qgenericunixservices.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/platformsupport/services/genericunix/qgenericunixservices.cpp b/src/platformsupport/services/genericunix/qgenericunixservices.cpp
index 1128f5d920..734bdcaf75 100644
--- a/src/platformsupport/services/genericunix/qgenericunixservices.cpp
+++ b/src/platformsupport/services/genericunix/qgenericunixservices.cpp
@@ -206,8 +206,8 @@ static inline QDBusMessage xdgDesktopPortalOpenFile(const QUrl &url)
QLatin1String("org.freedesktop.portal.OpenURI"),
QLatin1String("OpenFile"));
- QDBusUnixFileDescriptor descriptor(fd);
- qt_safe_close(fd);
+ QDBusUnixFileDescriptor descriptor;
+ descriptor.giveFileDescriptor(fd);
// FIXME parent_window_id and handle writable option
message << QString() << QVariant::fromValue(descriptor) << QVariantMap();