diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@digia.com> | 2014-04-02 20:38:57 +0200 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-04-04 19:32:21 +0200 |
| commit | fb143abbfb28d8433b908b09b37b4c7720357892 (patch) | |
| tree | 3f957ebbccd60cf694114bf0b9b6c0d69a4d58d4 | |
| parent | a4ec90175c76ce35688acc06cdf93e9cab886223 (diff) | |
de-duplicate code
Change-Id: Ic056acf739659215241c1cab6a462b1ab591dc78
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
| -rw-r--r-- | qmake/library/qmakebuiltins.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/qmake/library/qmakebuiltins.cpp b/qmake/library/qmakebuiltins.cpp index 36f808197a..5ae99bab92 100644 --- a/qmake/library/qmakebuiltins.cpp +++ b/qmake/library/qmakebuiltins.cpp @@ -1277,9 +1277,9 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional( return ReturnFalse; } int cnt = values(map(args.at(0))).count(); + int val = args.at(1).toQString(m_tmp1).toInt(); if (args.count() == 3) { const ProString &comp = args.at(2); - const int val = args.at(1).toQString(m_tmp1).toInt(); if (comp == QLatin1String(">") || comp == QLatin1String("greaterThan")) { return returnBool(cnt > val); } else if (comp == QLatin1String(">=")) { @@ -1290,13 +1290,13 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional( return returnBool(cnt <= val); } else if (comp == QLatin1String("equals") || comp == QLatin1String("isEqual") || comp == QLatin1String("=") || comp == QLatin1String("==")) { - return returnBool(cnt == val); + // fallthrough } else { evalError(fL1S("Unexpected modifier to count(%2).").arg(comp.toQString(m_tmp1))); return ReturnFalse; } } - return returnBool(cnt == args.at(1).toQString(m_tmp1).toInt()); + return returnBool(cnt == val); } case T_GREATERTHAN: case T_LESSTHAN: { |