summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2024-02-02 22:58:45 -0800
committerThiago Macieira <thiago.macieira@intel.com>2024-03-12 17:23:10 -0800
commitfff9f5047af79e7a8bd7345d9f22126d626e35a7 (patch)
treece7063bf461130878e2e25db158abb5fb9862b53
parent55959aefab1a190435dfacfc2a136ce3314d423c (diff)
qHash: update the pre-AVX512 mask to use the cacheline size
No change in behavior. But instead of trying to guess if we're going to cross a page boundary, we check for the cacheline: if we don't cross a cacheline boundary, then we can't cross a page boundary either. Testing bit 4 can be implemented with a shorter instruction than a test for bit 11. f43de: 40 f6 c7 20 test $0x20,%dil Change-Id: I664b9f014ffc48cbb49bfffd17b04817a0fb8c6b Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
-rw-r--r--src/corelib/tools/qhash.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/corelib/tools/qhash.cpp b/src/corelib/tools/qhash.cpp
index 8077141795..87ccc46d71 100644
--- a/src/corelib/tools/qhash.cpp
+++ b/src/corelib/tools/qhash.cpp
@@ -756,16 +756,16 @@ aeshash128_lt16(__m128i state0, const __m128i *src, const __m128i *srcend, size_
// including NULLs at the end because the length is in the key)
// WARNING: this may produce valgrind warnings, but it's safe
- constexpr quintptr PageSize = 4096;
+ constexpr quintptr CachelineSize = 64;
__m128i data;
- if ((quintptr(src) & (PageSize / 2)) == 0) {
- // lower half of the page:
+ if ((quintptr(src) & (CachelineSize / 2)) == 0) {
+ // lower half of the cacheline:
__m128i mask = _mm_loadu_si128(reinterpret_cast<const __m128i *>(maskarray + 15 - len));
data = loadu128<ZX>(src);
data = _mm_and_si128(data, mask);
} else {
- // upper half of the page:
+ // upper half of the cacheline:
__m128i control = _mm_loadu_si128(reinterpret_cast<const __m128i *>(shufflecontrol + 15 - len));
data = loadu128<ZX>(advance<ZX>(srcend, -1));
data = _mm_shuffle_epi8(data, control);