diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2014-11-27 15:02:50 +0100 |
|---|---|---|
| committer | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2015-02-02 11:14:59 +0000 |
| commit | aa30f49d6a38c77693ecf58ea9cbd13470e5fe9c (patch) | |
| tree | 571f9387ce53f085b4208698c3e7967f1e5eb281 /qmake/generators/win32/msvc_vcproj.cpp | |
| parent | 2b31356ac9faaa3ad9522d3e8b0dd00d90877476 (diff) | |
prune pointless assignments of QString::replace() and remove() results
they operate in-place.
Change-Id: Iab6f2f6a9f6f67b9d70feb77ec719e424909022d
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Diffstat (limited to 'qmake/generators/win32/msvc_vcproj.cpp')
| -rw-r--r-- | qmake/generators/win32/msvc_vcproj.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qmake/generators/win32/msvc_vcproj.cpp b/qmake/generators/win32/msvc_vcproj.cpp index 33d01a41ef..7faab0b1bc 100644 --- a/qmake/generators/win32/msvc_vcproj.cpp +++ b/qmake/generators/win32/msvc_vcproj.cpp @@ -1693,11 +1693,11 @@ QString VcprojGenerator::fixFilename(QString ofile) const ofile = Option::fixPathToLocalOS(ofile); int slashfind = ofile.lastIndexOf(Option::dir_sep); if(slashfind == -1) { - ofile = ofile.replace('-', '_'); + ofile.replace('-', '_'); } else { int hyphenfind = ofile.indexOf('-', slashfind); while (hyphenfind != -1 && slashfind < hyphenfind) { - ofile = ofile.replace(hyphenfind, 1, '_'); + ofile.replace(hyphenfind, 1, '_'); hyphenfind = ofile.indexOf('-', hyphenfind + 1); } } |