diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2014-11-27 15:02:50 +0100 |
|---|---|---|
| committer | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2015-02-02 11:14:59 +0000 |
| commit | aa30f49d6a38c77693ecf58ea9cbd13470e5fe9c (patch) | |
| tree | 571f9387ce53f085b4208698c3e7967f1e5eb281 /qmake/option.cpp | |
| parent | 2b31356ac9faaa3ad9522d3e8b0dd00d90877476 (diff) | |
prune pointless assignments of QString::replace() and remove() results
they operate in-place.
Change-Id: Iab6f2f6a9f6f67b9d70feb77ec719e424909022d
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Diffstat (limited to 'qmake/option.cpp')
| -rw-r--r-- | qmake/option.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/qmake/option.cpp b/qmake/option.cpp index cb851229b4..d92f3b7ac2 100644 --- a/qmake/option.cpp +++ b/qmake/option.cpp @@ -530,15 +530,15 @@ Option::fixString(QString string, uchar flags) //fix separators if (flags & Option::FixPathToNormalSeparators) { - string = string.replace('\\', '/'); + string.replace('\\', '/'); } else if (flags & Option::FixPathToLocalSeparators) { #if defined(Q_OS_WIN32) - string = string.replace('/', '\\'); + string.replace('/', '\\'); #else - string = string.replace('\\', '/'); + string.replace('\\', '/'); #endif } else if(flags & Option::FixPathToTargetSeparators) { - string = string.replace('/', Option::dir_sep).replace('\\', Option::dir_sep); + string.replace('/', Option::dir_sep).replace('\\', Option::dir_sep); } if ((string.startsWith("\"") && string.endsWith("\"")) || |