summaryrefslogtreecommitdiffstats
path: root/src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch
diff options
context:
space:
mode:
authorLaszlo Agocs <laszlo.agocs@qt.io>2020-05-18 15:16:30 +0200
committerLaszlo Agocs <laszlo.agocs@qt.io>2020-05-26 15:11:40 +0200
commit752497910b67b2a1a80560840ca44548d8893434 (patch)
tree541501c9abfd97c3d2fa450d2e6abb60582c4420 /src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch
parent7db527dbdd911c79f31425d099d1fc9c63e42453 (diff)
Remove ANGLE
This marks the end of EGL and OpenGL ES support on Windows. The concepts of -opengl dynamic, -opengl desktop, QT_OPENGL=software, etc. remain unchanged, with the exception of the disapperance of everything ANGLE related. CMake builds now work identically to qmake on Windows: they default to 'dynamic' OpenGL on Windows, unless -DINPUT_opengl=desktop is specified. On Windows, Qt 6 is expected to default to the "dynamic" OpenGL model by default, just like Qt 5.15. This can be changed by switching to "desktop" OpenGL, which will link to opengl32 (publicly, so other libs and applications will do so as well) and disallows using another OpenGL DLL. The "dynamic" mode is essential still because the fallback to a software rasterizer, such as the opengl32sw.dll we ship with the Qt packages, has to to work exactly like in Qt 5, the removal of ANGLE does not change this concept in any way (except of course that the middle option of using ANGLE is now gone) When it comes to the windows plugin's OpenGL blacklist feature, it works like before and accepts the ANGLE/D3D related keywords. They will then be ignored. Similarly, requesting QT_OPENGL=angle is ignored (but will show a warning). The D3D11 and DXGI configure time tests are removed: Qt 5.14 already depends on D3D 11.1 and DXGI 1.3 headers being available unconditionally on Win32 (in QRhi's D3D11 backend). No need to test for these. [ChangeLog][Windows] ANGLE is no longer included with Qt. Dynamic OpenGL builds work like before but ANGLE is no longer an option. OpenGL proper or an alternative opengl32 implementation are the two remaining options now. Attempting to set QT_OPENGL=angle or Qt::AA_UseOpenGLES will have no effect on Windows. Fixes: QTBUG-79103 Change-Id: Ia404e0d07f3fe191b27434d863c81180112ecb3b Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Diffstat (limited to 'src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch')
-rw-r--r--src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch78
1 files changed, 0 insertions, 78 deletions
diff --git a/src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch b/src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch
deleted file mode 100644
index fce3fd76b2..0000000000
--- a/src/angle/patches/0013-ANGLE-clean-up-displays-on-dll-unload.patch
+++ /dev/null
@@ -1,78 +0,0 @@
-From d8ca4f6d0d8fffd8319f340685e03751049678ae Mon Sep 17 00:00:00 2001
-From: Oliver Wolff <oliver.wolff@qt.io>
-Date: Tue, 16 Apr 2019 10:19:27 +0200
-Subject: [PATCH] ANGLE: clean up displays on dll unload
-
-If the displays are not cleaned up on dll unloading, profilers might
-report memory leaks.
-
-Change-Id: I04cbc3c2448bfb450f7d840e216827f86856e963
----
- src/3rdparty/angle/src/libANGLE/Display.cpp | 17 +++++++++++++++++
- src/3rdparty/angle/src/libANGLE/Display.h | 1 +
- .../angle/src/libGLESv2/global_state.cpp | 2 ++
- 3 files changed, 20 insertions(+)
-
-diff --git a/src/3rdparty/angle/src/libANGLE/Display.cpp b/src/3rdparty/angle/src/libANGLE/Display.cpp
-index 735b472787..0bb0bb05b1 100644
---- a/src/3rdparty/angle/src/libANGLE/Display.cpp
-+++ b/src/3rdparty/angle/src/libANGLE/Display.cpp
-@@ -364,6 +364,23 @@ Display *Display::GetDisplayFromDevice(Device *device, const AttributeMap &attri
- return display;
- }
-
-+//static
-+void Display::CleanupDisplays()
-+{
-+ // ~Display takes care of removing the entry from the according map
-+ {
-+ ANGLEPlatformDisplayMap *displays = GetANGLEPlatformDisplayMap();
-+ while (!displays->empty())
-+ delete displays->begin()->second;
-+ }
-+
-+ {
-+ DevicePlatformDisplayMap *displays = GetDevicePlatformDisplayMap();
-+ while (!displays->empty())
-+ delete displays->begin()->second;
-+ }
-+}
-+
- Display::Display(EGLenum platform, EGLNativeDisplayType displayId, Device *eglDevice)
- : mImplementation(nullptr),
- mDisplayId(displayId),
-diff --git a/src/3rdparty/angle/src/libANGLE/Display.h b/src/3rdparty/angle/src/libANGLE/Display.h
-index aa1d1c3b37..2a1c386d75 100644
---- a/src/3rdparty/angle/src/libANGLE/Display.h
-+++ b/src/3rdparty/angle/src/libANGLE/Display.h
-@@ -65,6 +65,7 @@ class Display final : angle::NonCopyable
- static Display *GetDisplayFromDevice(Device *device, const AttributeMap &attribMap);
- static Display *GetDisplayFromNativeDisplay(EGLNativeDisplayType nativeDisplay,
- const AttributeMap &attribMap);
-+ static void CleanupDisplays();
-
- static const ClientExtensions &GetClientExtensions();
- static const std::string &GetClientExtensionString();
-diff --git a/src/3rdparty/angle/src/libGLESv2/global_state.cpp b/src/3rdparty/angle/src/libGLESv2/global_state.cpp
-index c5f3dfe4e1..26045bf5b2 100644
---- a/src/3rdparty/angle/src/libGLESv2/global_state.cpp
-+++ b/src/3rdparty/angle/src/libGLESv2/global_state.cpp
-@@ -13,6 +13,7 @@
- #include "common/tls.h"
-
- #include "libANGLE/Thread.h"
-+#include "libANGLE/Display.h"
-
- namespace gl
- {
-@@ -140,6 +141,7 @@ extern "C" BOOL WINAPI DllMain(HINSTANCE, DWORD reason, LPVOID)
- return static_cast<BOOL>(egl::DeallocateCurrentThread());
-
- case DLL_PROCESS_DETACH:
-+ egl::Display::CleanupDisplays();
- return static_cast<BOOL>(egl::TerminateProcess());
- }
-
---
-2.20.1.windows.1
-