diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-11-02 14:58:31 +0100 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-11-03 13:06:15 +0100 |
| commit | 742de50c5ec01f93cf0e193a8a131cbd913cb787 (patch) | |
| tree | 95343d40491cdf9d7a50cba60d8135ec8a49093a /src/gui/kernel/qevent.cpp | |
| parent | a31dde22dbb37643dcabab12b2ac4e2f1d79f958 (diff) | |
Address API review comments for QInput/QPointingDevice
- Give default constructor an optional parent, as is standard for QObjects
- remove default for QObject parent from inheritance constructor
- make QPointingDeviceUniqueId comparison inline, remove superfluous
inline of hidden friends
- mark read only properties as CONSTANT
- remove bit-size from enum types; they are stored in the private,
and there are just a few instances; no need to save a few bytes at the
expense of performance and code cleanliness
Change-Id: Ie7d4a587362714e9d3bc41447cef786bbdb382c6
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'src/gui/kernel/qevent.cpp')
| -rw-r--r-- | src/gui/kernel/qevent.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/gui/kernel/qevent.cpp b/src/gui/kernel/qevent.cpp index 0c3b631608..7db77f5ee5 100644 --- a/src/gui/kernel/qevent.cpp +++ b/src/gui/kernel/qevent.cpp @@ -5328,14 +5328,6 @@ qint64 QPointingDeviceUniqueId::numericId() const noexcept */ /*! - \internal -*/ -bool QPointingDeviceUniqueId::equals(QPointingDeviceUniqueId other) const noexcept -{ - return numericId() == other.numericId(); -} - -/*! \relates QPointingDeviceUniqueId \since 5.8 |